peter
482dd28006
Resolves the 5 /code-review high findings on this branch: - a11y sweep: extend aria-label to the remaining icon-only Plex card buttons the first pass missed — PlexPosterCard Info, SeasonCard watched-toggle + add-season (EpisodeCard already had them). "Fix a principle everywhere, in one sweep." - new shared lib/parseId.ts `parsePositiveIntId`, used by BOTH readSelectedId (now guarding the stored ?pl fallback the same as the URL — was unguarded) and plexSubUrl's ?v=playlist decode; removes the hand-duplicated guard. - PAGE_KEY exported from navigationInit and imported by NavigationProvider (was defined in both). - hoist a `watchedLabel` const per card so title + aria-label can't drift. +8 tests (parseId unit + guarded-stored ?pl); full FE gate green (tsc/eslint/ prettier/knip, 317 vitest).
24 lines
816 B
TypeScript
24 lines
816 B
TypeScript
import { describe, it, expect } from "vitest";
|
|
import { parsePositiveIntId } from "./parseId";
|
|
|
|
describe("parsePositiveIntId", () => {
|
|
it("accepts a positive integer", () => {
|
|
expect(parsePositiveIntId("1")).toBe(1);
|
|
expect(parsePositiveIntId("42")).toBe(42);
|
|
});
|
|
|
|
it("rejects empty / nullish", () => {
|
|
expect(parsePositiveIntId("")).toBeNull();
|
|
expect(parsePositiveIntId(null)).toBeNull();
|
|
expect(parsePositiveIntId(undefined)).toBeNull();
|
|
});
|
|
|
|
it("rejects zero, negative, fractional, and non-numeric", () => {
|
|
expect(parsePositiveIntId("0")).toBeNull();
|
|
expect(parsePositiveIntId("-1")).toBeNull();
|
|
expect(parsePositiveIntId("1.5")).toBeNull();
|
|
expect(parsePositiveIntId("abc")).toBeNull();
|
|
expect(parsePositiveIntId(" ")).toBeNull(); // Number(" ")===0
|
|
});
|
|
});
|