peter
4aaaaa7860
The code cited its plan instead of saying why: `E28 review J4`, `(R6 S3b)`, `S1 justified…`,
`deep-review round 5`. That plan lives in the private ops repo, so for every reader of this one the
citation was noise, and a sentence whose subject was the plan step ("round 2 showed…") hid its
lesson behind an id. Each one is gone and the "why" kept: a bare citation is deleted, a sentence
carrying a lesson is reworded around it ("a later attempt showed…").
Measured (`scripts/audit_metrics.py`, product code): 652 lines in 270 files carried an epic code by
the definition the next commit holds (507 / 241 by the old, two-digit-only one) -> 0. Across all
code, tests, scripts and configs: ~1100 epic-code lines plus ~320 sprint/round ids.
Behaviour unchanged, checked mechanically: every changed .py file has the same AST once docstrings
are blanked; css/sh/toml/yml/json files are identical once comments are stripped; the only
non-comment changes in TS/JS are test titles, one description string in a contract table, and five
ESLint messages, whose text is all the gates snapshot diff holds. Not touched: Markdown (docs and
the changelog keep their history), Alembic migrations, TV episode notation (`S2 · E5`), DESIGN.md
ids (`C1`, `B4`, `S3h`), tracker ids (`SEC-16`, `DX-17`).
One stale claim fixed on the way: test_hls_reaper's docstring said the player checkpoints "every
10 s whether or not it is playing", which plex/stream.py calls wrong; it now says what the code does.
39 lines
1.6 KiB
TypeScript
39 lines
1.6 KiB
TypeScript
import { readdirSync, readFileSync } from "node:fs";
|
|
import { QueryClient } from "@tanstack/react-query";
|
|
import { describe, expect, it, vi } from "vitest";
|
|
|
|
import { qk } from "./queryKeys";
|
|
import { invalidateSubscription } from "./subscriptionCache";
|
|
|
|
// A subscription change touches the same reads wherever it is made, and each site kept
|
|
// its own list — the channel menu's unsubscribe left the feed showing the channel's videos, the
|
|
// channel page's left the status counts stale. One set, one function, every site on it.
|
|
describe("a subscription change", () => {
|
|
it("refreshes the channel, the lists, the counts and the feed", () => {
|
|
const qc = new QueryClient();
|
|
const spy = vi.spyOn(qc, "invalidateQueries");
|
|
invalidateSubscription(qc, "UC1");
|
|
expect(spy.mock.calls.map(([f]) => f?.queryKey)).toEqual([
|
|
qk.channel("UC1"),
|
|
qk.channels(),
|
|
qk.myStatus(),
|
|
qk.feed(),
|
|
qk.feedSummary(),
|
|
qk.discoveredChannels(),
|
|
]);
|
|
});
|
|
|
|
it("is refreshed through that one function wherever it is made", () => {
|
|
const root = new URL("../components/", import.meta.url);
|
|
const sites = readdirSync(root)
|
|
.filter((f) => f.endsWith(".tsx") && !f.includes(".test."))
|
|
.map((f) => [f, readFileSync(new URL(f, root), "utf8")] as const)
|
|
.filter(([, src]) => /api\.(un)?subscribeChannel\(/.test(src));
|
|
expect(sites.length).toBeGreaterThanOrEqual(3);
|
|
for (const [f, src] of sites) {
|
|
const calls = src.match(/api\.(un)?subscribeChannel\(/g)!.length;
|
|
expect(src.match(/invalidateSubscription\(/g)?.length ?? 0, f).toBe(calls);
|
|
}
|
|
});
|
|
});
|