peter
4aaaaa7860
The code cited its plan instead of saying why: `E28 review J4`, `(R6 S3b)`, `S1 justified…`,
`deep-review round 5`. That plan lives in the private ops repo, so for every reader of this one the
citation was noise, and a sentence whose subject was the plan step ("round 2 showed…") hid its
lesson behind an id. Each one is gone and the "why" kept: a bare citation is deleted, a sentence
carrying a lesson is reworded around it ("a later attempt showed…").
Measured (`scripts/audit_metrics.py`, product code): 652 lines in 270 files carried an epic code by
the definition the next commit holds (507 / 241 by the old, two-digit-only one) -> 0. Across all
code, tests, scripts and configs: ~1100 epic-code lines plus ~320 sprint/round ids.
Behaviour unchanged, checked mechanically: every changed .py file has the same AST once docstrings
are blanked; css/sh/toml/yml/json files are identical once comments are stripped; the only
non-comment changes in TS/JS are test titles, one description string in a contract table, and five
ESLint messages, whose text is all the gates snapshot diff holds. Not touched: Markdown (docs and
the changelog keep their history), Alembic migrations, TV episode notation (`S2 · E5`), DESIGN.md
ids (`C1`, `B4`, `S3h`), tracker ids (`SEC-16`, `DX-17`).
One stale claim fixed on the way: test_hls_reaper's docstring said the player checkpoints "every
10 s whether or not it is playing", which plex/stream.py calls wrong; it now says what the code does.
77 lines
2.6 KiB
TypeScript
77 lines
2.6 KiB
TypeScript
// @vitest-environment jsdom
|
|
//
|
|
// The sidebar's playlist picker: typing a name offers "Create …" — but only
|
|
// once the lists have loaded. Over a failed load the create row pushed the error and its Retry out
|
|
// of the list at the first keystroke, and whether the name already existed was unknown anyway.
|
|
import { describe, it, expect, vi, afterEach, beforeAll } from "vitest";
|
|
import { render, cleanup, screen, fireEvent, waitFor } from "@testing-library/react";
|
|
import { QueryClient, QueryClientProvider } from "@tanstack/react-query";
|
|
import { FloatingTree } from "@floating-ui/react";
|
|
|
|
vi.mock("react-i18next", async (importOriginal) => {
|
|
const actual = await importOriginal<typeof import("react-i18next")>();
|
|
return {
|
|
...actual,
|
|
useTranslation: () => ({
|
|
t: (key: string, o?: { name?: string }) => (o?.name != null ? `${key}:${o.name}` : key),
|
|
i18n: { language: "en" },
|
|
}),
|
|
};
|
|
});
|
|
vi.mock("./plexContext", () => ({
|
|
usePlex: () => ({}),
|
|
usePlexActions: () => ({ setPlaylistOpen: vi.fn() }),
|
|
}));
|
|
|
|
import { PlaylistPicker } from "./PlexSidebar";
|
|
import { api } from "../lib/api";
|
|
|
|
beforeAll(() => {
|
|
class Stub {
|
|
observe() {}
|
|
unobserve() {}
|
|
disconnect() {}
|
|
takeRecords() {
|
|
return [];
|
|
}
|
|
}
|
|
globalThis.ResizeObserver ??= Stub as unknown as typeof ResizeObserver;
|
|
});
|
|
|
|
afterEach(() => {
|
|
cleanup();
|
|
vi.restoreAllMocks();
|
|
});
|
|
|
|
function mount() {
|
|
const qc = new QueryClient({ defaultOptions: { queries: { retry: false } } });
|
|
render(
|
|
<QueryClientProvider client={qc}>
|
|
<FloatingTree>
|
|
<PlaylistPicker />
|
|
</FloatingTree>
|
|
</QueryClientProvider>,
|
|
);
|
|
return screen.getByRole("combobox");
|
|
}
|
|
|
|
describe("the sidebar playlist picker", () => {
|
|
it("keeps the load error and its Retry while a name is typed, with no Create row", async () => {
|
|
vi.spyOn(api, "plexPlaylists").mockRejectedValue(new TypeError("Failed to fetch"));
|
|
const input = mount();
|
|
fireEvent.focus(input);
|
|
fireEvent.change(input, { target: { value: "Road trip" } });
|
|
await waitFor(() => expect(screen.getByRole("alert", { hidden: true })).toBeTruthy());
|
|
expect(screen.getByText("common.retry")).toBeTruthy();
|
|
expect(screen.queryByText("plex.playlist.createNamed:Road trip")).toBeNull();
|
|
});
|
|
|
|
it("offers Create for a new name once the lists are in", async () => {
|
|
vi.spyOn(api, "plexPlaylists").mockResolvedValue({ playlists: [] } as never);
|
|
const input = mount();
|
|
fireEvent.focus(input);
|
|
fireEvent.change(input, { target: { value: "Road trip" } });
|
|
expect(await screen.findByText("plex.playlist.createNamed:Road trip")).toBeTruthy();
|
|
});
|
|
});
|