peter
4aaaaa7860
The code cited its plan instead of saying why: `E28 review J4`, `(R6 S3b)`, `S1 justified…`,
`deep-review round 5`. That plan lives in the private ops repo, so for every reader of this one the
citation was noise, and a sentence whose subject was the plan step ("round 2 showed…") hid its
lesson behind an id. Each one is gone and the "why" kept: a bare citation is deleted, a sentence
carrying a lesson is reworded around it ("a later attempt showed…").
Measured (`scripts/audit_metrics.py`, product code): 652 lines in 270 files carried an epic code by
the definition the next commit holds (507 / 241 by the old, two-digit-only one) -> 0. Across all
code, tests, scripts and configs: ~1100 epic-code lines plus ~320 sprint/round ids.
Behaviour unchanged, checked mechanically: every changed .py file has the same AST once docstrings
are blanked; css/sh/toml/yml/json files are identical once comments are stripped; the only
non-comment changes in TS/JS are test titles, one description string in a contract table, and five
ESLint messages, whose text is all the gates snapshot diff holds. Not touched: Markdown (docs and
the changelog keep their history), Alembic migrations, TV episode notation (`S2 · E5`), DESIGN.md
ids (`C1`, `B4`, `S3h`), tracker ids (`SEC-16`, `DX-17`).
One stale claim fixed on the way: test_hls_reaper's docstring said the player checkpoints "every
10 s whether or not it is playing", which plex/stream.py calls wrong; it now says what the code does.
50 lines
2.0 KiB
TypeScript
50 lines
2.0 KiB
TypeScript
// @vitest-environment jsdom
|
|
//
|
|
// A failed download's explanation: the failure-catalog entry first, its category as the fallback.
|
|
// The second case runs the REAL i18next with the real locales, because the fallback is
|
|
// i18next's list-key lookup, not code of ours — an older client meeting a detail it has no copy for
|
|
// must still say the category, not print a key.
|
|
import { describe, expect, it } from "vitest";
|
|
import i18n from "../i18n";
|
|
import { failCopyKeys } from "./downloadFailure";
|
|
|
|
describe("failCopyKeys", () => {
|
|
it("puts a catalog entry before its category, and is the category alone without one", () => {
|
|
expect(
|
|
failCopyKeys({ error_code: "login_required", error_detail: "facebook.login_wall" }, "body"),
|
|
).toEqual([
|
|
"downloads.errors.fail.catalog.facebook.login_wall.body",
|
|
"downloads.errors.fail.cat.login_required.body",
|
|
"downloads.errors.fail.cat.unknown.body",
|
|
]);
|
|
expect(failCopyKeys({ error_code: "network", error_detail: null }, "short")).toEqual([
|
|
"downloads.errors.fail.cat.network.short",
|
|
"downloads.errors.fail.cat.unknown.short",
|
|
]);
|
|
expect(failCopyKeys({ error_code: null, error_detail: null }, "short")).toEqual([
|
|
"downloads.errors.fail.cat.unknown.short",
|
|
]);
|
|
});
|
|
|
|
it("reads the entry's copy, and the category's for an entry this client does not know", async () => {
|
|
await i18n.changeLanguage("en");
|
|
expect(
|
|
i18n.t(
|
|
failCopyKeys(
|
|
{ error_code: "login_required", error_detail: "facebook.login_wall" },
|
|
"short",
|
|
),
|
|
),
|
|
).toBe("Facebook sign-in required");
|
|
expect(
|
|
i18n.t(
|
|
failCopyKeys({ error_code: "login_required", error_detail: "facebook.newer" }, "short"),
|
|
),
|
|
).toBe("Sign-in required");
|
|
// A category this client has no copy for (a newer backend): the generic sentence, never a key.
|
|
expect(i18n.t(failCopyKeys({ error_code: "rate_limited", error_detail: null }, "short"))).toBe(
|
|
"Couldn't download",
|
|
);
|
|
});
|
|
});
|