peter
4aaaaa7860
The code cited its plan instead of saying why: `E28 review J4`, `(R6 S3b)`, `S1 justified…`,
`deep-review round 5`. That plan lives in the private ops repo, so for every reader of this one the
citation was noise, and a sentence whose subject was the plan step ("round 2 showed…") hid its
lesson behind an id. Each one is gone and the "why" kept: a bare citation is deleted, a sentence
carrying a lesson is reworded around it ("a later attempt showed…").
Measured (`scripts/audit_metrics.py`, product code): 652 lines in 270 files carried an epic code by
the definition the next commit holds (507 / 241 by the old, two-digit-only one) -> 0. Across all
code, tests, scripts and configs: ~1100 epic-code lines plus ~320 sprint/round ids.
Behaviour unchanged, checked mechanically: every changed .py file has the same AST once docstrings
are blanked; css/sh/toml/yml/json files are identical once comments are stripped; the only
non-comment changes in TS/JS are test titles, one description string in a contract table, and five
ESLint messages, whose text is all the gates snapshot diff holds. Not touched: Markdown (docs and
the changelog keep their history), Alembic migrations, TV episode notation (`S2 · E5`), DESIGN.md
ids (`C1`, `B4`, `S3h`), tracker ids (`SEC-16`, `DX-17`).
One stale claim fixed on the way: test_hls_reaper's docstring said the player checkpoints "every
10 s whether or not it is playing", which plex/stream.py calls wrong; it now says what the code does.
33 lines
1.3 KiB
TypeScript
33 lines
1.3 KiB
TypeScript
import { readFileSync } from "node:fs";
|
|
|
|
import { describe, expect, it } from "vitest";
|
|
|
|
import { redact, SEVERITY } from "./log";
|
|
|
|
// The browser log and the server log are ONE log: a client batch lands in `log_events` beside
|
|
// the server's rows. So the two must agree on what is safe to keep and on what a level is worth —
|
|
// asserted against the backend's own files, not a copy of them.
|
|
const backend = (path: string) =>
|
|
readFileSync(new URL(`../../../backend/${path}`, import.meta.url), "utf-8");
|
|
|
|
const { cases } = JSON.parse(backend("tests/fixtures/log_redaction_cases.json")) as {
|
|
cases: { name: string; key: string; value: unknown; expected: unknown }[];
|
|
};
|
|
|
|
describe("redaction matches the server's (shared cases)", () => {
|
|
it.each(cases.map((c) => [c.name, c] as const))("%s", (_name, c) => {
|
|
expect(redact(c.value, c.key)).toEqual(c.expected);
|
|
});
|
|
});
|
|
|
|
describe("severity numbers match logs.SEVERITY", () => {
|
|
it("names the same levels with the same numbers", () => {
|
|
const block = /SEVERITY: dict\[str, int\] = \{([^}]*)\}/.exec(backend("app/logs.py"))?.[1];
|
|
expect(block).toBeTruthy();
|
|
const server = Object.fromEntries(
|
|
[...block!.matchAll(/"(\w+)":\s*(\d+)/g)].map((m) => [m[1], Number(m[2])]),
|
|
);
|
|
expect(SEVERITY).toEqual(server);
|
|
});
|
|
});
|