peter
84db570951
A session's marks are weighed per field against when each page of a never-refetched list was read: a page read before the mark (a Show more / Load more on its way) takes it, one read after keeps the server's word. The live search lays them over its rows too, not only the related list. Items of the built-in Watch later list ARE the bookmark, so adding, removing and moving them go through features/video/videoWrites and mark the video; the contract test covers those writes and catches a write that is named without being called on the spot. The player's watched toggle follows a mark confirmed elsewhere since it opened (the related row's menu, a notice's Undo); Restart on the related row after a description link goes back to it. The file viewer tells the help sheet its keys wait under a layer; refusalReason replaces the last two open-coded reads. Auto-advance wears list glyphs of its own (the skip arrows are Previous / Next beside it), and the auto-advance and loop cycles are `lit`, not toggles: no aria-pressed, the name says the mode. Both places render from one list of controls, so the docked tooltips name the mode too. The English cap message and admin hint quote "Show more"; the hint says refunds are limited.
45 lines
2.1 KiB
TypeScript
45 lines
2.1 KiB
TypeScript
import { readdirSync, readFileSync } from "node:fs";
|
|
import { describe, expect, it } from "vitest";
|
|
|
|
// The whole app source: a state write can be made from any page.
|
|
const root = new URL("../../", import.meta.url);
|
|
const sources = () =>
|
|
readdirSync(root, { recursive: true, encoding: "utf8" })
|
|
.map((f) => f.replace(/\\/g, "/"))
|
|
.filter((f) => /\.tsx?$/.test(f) && !f.includes(".test."))
|
|
.map((f) => ({ f, src: readFileSync(new URL(f, root), "utf8") }));
|
|
|
|
// The api's own definitions of these writes, and the one module that may call them.
|
|
const ALLOWED = new Set([
|
|
"lib/api/feed.ts",
|
|
"lib/api/playlists.ts",
|
|
"features/video/videoWrites.ts",
|
|
]);
|
|
|
|
// A related list and a live search are never refetched, so a state, Watch-later or playlist-item
|
|
// write that does not reach them (`markVideo`) leaves them showing the old mark for the session —
|
|
// the built-in Watch later list's items ARE the mark. videoWrites makes those writes and the mark
|
|
// together; a direct api call skips the mark.
|
|
const WRITES =
|
|
/\bapi\s*\.\s*(setState|clearState|watchLaterAdd|watchLaterRemove|addToPlaylist|removeFromPlaylist|moveToPlaylist)\b/;
|
|
|
|
describe("a video's state, Watch-later and playlist-item writes", () => {
|
|
it("go through features/video/videoWrites, never the api directly", () => {
|
|
const offenders = sources()
|
|
.filter(({ f }) => !ALLOWED.has(f))
|
|
// Only the api object's members count (React's own `setState` is not ours) — named, not only
|
|
// called: `(saved ? api.watchLaterAdd : api.watchLaterRemove)(id)` makes the write too. The
|
|
// dot may sit on the next line of a chain.
|
|
.filter(({ src }) => WRITES.test(src))
|
|
.map(({ f }) => f);
|
|
expect(offenders).toEqual([]);
|
|
});
|
|
|
|
it("catches a write named without being called on the spot, and a playlist item's", () => {
|
|
expect(WRITES.test("(saved ? api.watchLaterAdd : api.watchLaterRemove)(id)")).toBe(true);
|
|
expect(WRITES.test("await api\n .removeFromPlaylist(listId, id)")).toBe(true);
|
|
expect(WRITES.test("api.moveToPlaylist(a, id, b)")).toBe(true);
|
|
expect(WRITES.test("this.setState(next); api.playlists()")).toBe(false);
|
|
});
|
|
});
|