peter
4aaaaa7860
The code cited its plan instead of saying why: `E28 review J4`, `(R6 S3b)`, `S1 justified…`,
`deep-review round 5`. That plan lives in the private ops repo, so for every reader of this one the
citation was noise, and a sentence whose subject was the plan step ("round 2 showed…") hid its
lesson behind an id. Each one is gone and the "why" kept: a bare citation is deleted, a sentence
carrying a lesson is reworded around it ("a later attempt showed…").
Measured (`scripts/audit_metrics.py`, product code): 652 lines in 270 files carried an epic code by
the definition the next commit holds (507 / 241 by the old, two-digit-only one) -> 0. Across all
code, tests, scripts and configs: ~1100 epic-code lines plus ~320 sprint/round ids.
Behaviour unchanged, checked mechanically: every changed .py file has the same AST once docstrings
are blanked; css/sh/toml/yml/json files are identical once comments are stripped; the only
non-comment changes in TS/JS are test titles, one description string in a contract table, and five
ESLint messages, whose text is all the gates snapshot diff holds. Not touched: Markdown (docs and
the changelog keep their history), Alembic migrations, TV episode notation (`S2 · E5`), DESIGN.md
ids (`C1`, `B4`, `S3h`), tracker ids (`SEC-16`, `DX-17`).
One stale claim fixed on the way: test_hls_reaper's docstring said the player checkpoints "every
10 s whether or not it is playing", which plex/stream.py calls wrong; it now says what the code does.
73 lines
2.9 KiB
TypeScript
73 lines
2.9 KiB
TypeScript
// @vitest-environment jsdom
|
|
//
|
|
// A side panel's groups in edit mode move without a drag too (WCAG 2.5.7): each carries an Up / Down
|
|
// pair, named by its group, and a move lands in the stored order.
|
|
import { describe, it, expect, vi, afterEach } from "vitest";
|
|
import { render, screen, fireEvent, cleanup, within } from "@testing-library/react";
|
|
|
|
vi.mock("react-i18next", async (importOriginal) => {
|
|
const actual = await importOriginal<typeof import("react-i18next")>();
|
|
return {
|
|
...actual,
|
|
useTranslation: () => ({
|
|
t: (key: string, o?: { name?: string }) => (o?.name ? `${key}:${o.name}` : key),
|
|
}),
|
|
};
|
|
});
|
|
|
|
import PanelGroups, { type PanelItem } from "./PanelGroups";
|
|
import type { PanelLayout } from "../../lib/panelLayout";
|
|
|
|
afterEach(cleanup);
|
|
|
|
const items: PanelItem[] = ["a", "b", "c"].map((id) => ({
|
|
id,
|
|
title: `Group ${id}`,
|
|
body: <p>{id} body</p>,
|
|
}));
|
|
const layout = (order: string[]): PanelLayout => ({ order, collapsed: {}, hidden: {} });
|
|
|
|
function mount(order: string[], editing = true) {
|
|
const setLayout = vi.fn();
|
|
render(
|
|
<PanelGroups items={items} layout={layout(order)} setLayout={setLayout} editing={editing} />,
|
|
);
|
|
const pair = (title: string) => screen.getByRole("group", { name: new RegExp(title) });
|
|
const btn = (title: string, name: string) =>
|
|
within(pair(title)).getByRole("button", { name }) as HTMLButtonElement;
|
|
return { setLayout, btn };
|
|
}
|
|
|
|
describe("PanelGroups — reordering without a drag", () => {
|
|
it("moves a group up or down, the ends held off", () => {
|
|
const { setLayout, btn } = mount(["a", "b", "c"]);
|
|
expect(btn("Group a", "common.order.up").disabled).toBe(true);
|
|
expect(btn("Group c", "common.order.down").disabled).toBe(true);
|
|
fireEvent.click(btn("Group a", "common.order.down"));
|
|
expect(setLayout).toHaveBeenLastCalledWith(expect.objectContaining({ order: ["b", "a", "c"] }));
|
|
fireEvent.click(btn("Group c", "common.order.up"));
|
|
expect(setLayout).toHaveBeenLastCalledWith(expect.objectContaining({ order: ["a", "c", "b"] }));
|
|
});
|
|
|
|
it("moves a group the stored order does not hold yet", () => {
|
|
// "c" became available after the layout was saved: it renders last, and still moves.
|
|
const { setLayout, btn } = mount(["a", "b"]);
|
|
fireEvent.click(btn("Group c", "common.order.up"));
|
|
expect(setLayout).toHaveBeenLastCalledWith(expect.objectContaining({ order: ["a", "c", "b"] }));
|
|
});
|
|
|
|
it("offers no move outside edit mode", () => {
|
|
mount(["a", "b", "c"], false);
|
|
expect(screen.queryByRole("button", { name: "common.order.up" })).toBeNull();
|
|
});
|
|
});
|
|
|
|
// Every group's grip was "Drag to reorder" — a screen reader heard the same name five
|
|
// times and could not tell which group it would lift. It names its group, as the playlist grips do.
|
|
describe("PanelGroups — the drag grip", () => {
|
|
it("is named by its group", () => {
|
|
mount(["a", "b", "c"]);
|
|
expect(screen.getByRole("button", { name: "common.order.dragNamed:Group b" })).toBeTruthy();
|
|
});
|
|
});
|