peter
4aaaaa7860
The code cited its plan instead of saying why: `E28 review J4`, `(R6 S3b)`, `S1 justified…`,
`deep-review round 5`. That plan lives in the private ops repo, so for every reader of this one the
citation was noise, and a sentence whose subject was the plan step ("round 2 showed…") hid its
lesson behind an id. Each one is gone and the "why" kept: a bare citation is deleted, a sentence
carrying a lesson is reworded around it ("a later attempt showed…").
Measured (`scripts/audit_metrics.py`, product code): 652 lines in 270 files carried an epic code by
the definition the next commit holds (507 / 241 by the old, two-digit-only one) -> 0. Across all
code, tests, scripts and configs: ~1100 epic-code lines plus ~320 sprint/round ids.
Behaviour unchanged, checked mechanically: every changed .py file has the same AST once docstrings
are blanked; css/sh/toml/yml/json files are identical once comments are stripped; the only
non-comment changes in TS/JS are test titles, one description string in a contract table, and five
ESLint messages, whose text is all the gates snapshot diff holds. Not touched: Markdown (docs and
the changelog keep their history), Alembic migrations, TV episode notation (`S2 · E5`), DESIGN.md
ids (`C1`, `B4`, `S3h`), tracker ids (`SEC-16`, `DX-17`).
One stale claim fixed on the way: test_hls_reaper's docstring said the player checkpoints "every
10 s whether or not it is playing", which plex/stream.py calls wrong; it now says what the code does.
105 lines
3.6 KiB
TypeScript
105 lines
3.6 KiB
TypeScript
// @vitest-environment jsdom
|
|
//
|
|
// The channel manager's card layout as a keyboard list: each card is an item, and Enter opens
|
|
// the channel through the name ChannelLink renders. VirtualGrid is replaced by a stand-in that mounts
|
|
// every item — jsdom has no layout for the virtualizer to measure — and registers with listNav exactly
|
|
// when the real one would: when it is asked to (`keyboardNav`).
|
|
import { Fragment, useRef } from "react";
|
|
import { afterEach, describe, expect, it, vi } from "vitest";
|
|
import { act, cleanup, render } from "@testing-library/react";
|
|
import type { VirtualGridProps } from "./ui/VirtualGrid";
|
|
|
|
vi.mock("react-i18next", async (importOriginal) => {
|
|
const actual = await importOriginal<typeof import("react-i18next")>();
|
|
return { ...actual, useTranslation: () => ({ t: (key: string) => key }) };
|
|
});
|
|
vi.mock("./ui/VirtualGrid", async () => {
|
|
const { useListNav } = await import("../lib/listNav");
|
|
return {
|
|
default: function GridStandIn({
|
|
items,
|
|
getKey,
|
|
renderItem,
|
|
keyboardNav,
|
|
}: VirtualGridProps<unknown>) {
|
|
const ref = useRef<HTMLDivElement>(null);
|
|
useListNav(ref, { enabled: !!keyboardNav });
|
|
return (
|
|
<div ref={ref}>
|
|
{items.map((item, i) => (
|
|
<Fragment key={getKey(item)}>{renderItem(item, 0, i)}</Fragment>
|
|
))}
|
|
</div>
|
|
);
|
|
},
|
|
};
|
|
});
|
|
|
|
import ChannelLayoutGrid from "./ChannelLayoutGrid";
|
|
import ChannelLink from "./ChannelLink";
|
|
import { type Column } from "./ui/DataTable";
|
|
|
|
afterEach(cleanup);
|
|
|
|
type Ch = { id: string; title: string };
|
|
const rows: Ch[] = [
|
|
{ id: "UCa", title: "Alpha" },
|
|
{ id: "UCb", title: "Beta" },
|
|
];
|
|
|
|
function press(key: string) {
|
|
act(() => {
|
|
(document.activeElement ?? document.body).dispatchEvent(
|
|
new KeyboardEvent("keydown", { key, bubbles: true, cancelable: true }),
|
|
);
|
|
});
|
|
}
|
|
|
|
const focusedTitle = () =>
|
|
(document.activeElement as HTMLElement).querySelector("[data-nav-open]")?.textContent;
|
|
|
|
describe("ChannelLayoutGrid · keyboard", () => {
|
|
it("walks the cards with j/k and opens the channel on Enter", () => {
|
|
const opened: string[] = [];
|
|
const columns: Column<Ch>[] = [
|
|
{
|
|
key: "channel",
|
|
header: "Channel",
|
|
cardPrimary: true,
|
|
render: (c) => (
|
|
<ChannelLink
|
|
id={c.id}
|
|
title={c.title}
|
|
thumbnailUrl={null}
|
|
onView={() => opened.push(c.id)}
|
|
/>
|
|
),
|
|
},
|
|
];
|
|
render(<ChannelLayoutGrid rows={rows} columns={columns} rowKey={(c) => c.id} />);
|
|
press("j");
|
|
expect(focusedTitle()).toBe("Alpha");
|
|
press("j");
|
|
expect(focusedTitle()).toBe("Beta");
|
|
press("Enter");
|
|
expect(opened).toEqual(["UCb"]);
|
|
});
|
|
});
|
|
|
|
describe('ChannelLayoutGrid · the card\'s "…"', () => {
|
|
it("docks it in the heading row beside the name, not in the meta line", () => {
|
|
const columns: Column<Ch>[] = [
|
|
{ key: "channel", header: "Channel", cardPrimary: true, render: (c) => <b>{c.title}</b> },
|
|
{ key: "stored", header: "Stored", render: () => <i>12</i> },
|
|
{ key: "actions", header: "", render: (c) => <u data-testid={`more-${c.id}`}>…</u> },
|
|
];
|
|
const { getByTestId, getByText } = render(
|
|
<ChannelLayoutGrid rows={rows} columns={columns} rowKey={(c) => c.id} moreKey="actions" />,
|
|
);
|
|
const heading = getByText("Alpha").closest("div")!.parentElement!;
|
|
expect(heading.contains(getByTestId("more-UCa"))).toBe(true);
|
|
// Exactly once: a slotted column is not also painted in the meta line.
|
|
expect(document.querySelectorAll('[data-testid="more-UCa"]')).toHaveLength(1);
|
|
});
|
|
});
|