peter
4aaaaa7860
The code cited its plan instead of saying why: `E28 review J4`, `(R6 S3b)`, `S1 justified…`,
`deep-review round 5`. That plan lives in the private ops repo, so for every reader of this one the
citation was noise, and a sentence whose subject was the plan step ("round 2 showed…") hid its
lesson behind an id. Each one is gone and the "why" kept: a bare citation is deleted, a sentence
carrying a lesson is reworded around it ("a later attempt showed…").
Measured (`scripts/audit_metrics.py`, product code): 652 lines in 270 files carried an epic code by
the definition the next commit holds (507 / 241 by the old, two-digit-only one) -> 0. Across all
code, tests, scripts and configs: ~1100 epic-code lines plus ~320 sprint/round ids.
Behaviour unchanged, checked mechanically: every changed .py file has the same AST once docstrings
are blanked; css/sh/toml/yml/json files are identical once comments are stripped; the only
non-comment changes in TS/JS are test titles, one description string in a contract table, and five
ESLint messages, whose text is all the gates snapshot diff holds. Not touched: Markdown (docs and
the changelog keep their history), Alembic migrations, TV episode notation (`S2 · E5`), DESIGN.md
ids (`C1`, `B4`, `S3h`), tracker ids (`SEC-16`, `DX-17`).
One stale claim fixed on the way: test_hls_reaper's docstring said the player checkpoints "every
10 s whether or not it is playing", which plex/stream.py calls wrong; it now says what the code does.
36 lines
1.2 KiB
TypeScript
36 lines
1.2 KiB
TypeScript
// @vitest-environment jsdom
|
|
//
|
|
// A card's numbers follow a language switch. The formatters read the UI language, but the
|
|
// React Compiler memoizes a call on its ARGUMENTS — `formatRuntime(card.duration_seconds)` stayed
|
|
// "2 hr 4 min" after switching to Hungarian while the hero beside it said "2 ó 16 p". Real catalog.
|
|
import { describe, it, expect, afterEach, vi } from "vitest";
|
|
import { render, screen, cleanup, act } from "@testing-library/react";
|
|
import { setLanguage } from "../i18n";
|
|
import { PlexPosterCard } from "./plexCards";
|
|
import type { PlexCard } from "../lib/api";
|
|
|
|
afterEach(() => {
|
|
cleanup();
|
|
setLanguage("en");
|
|
});
|
|
|
|
const movie: PlexCard = {
|
|
id: "m1",
|
|
type: "movie",
|
|
title: "Heat",
|
|
thumb: "/api/plex/image/m1",
|
|
duration_seconds: 2 * 3600 + 4 * 60,
|
|
rating: 8.3,
|
|
};
|
|
|
|
describe("a card after a language switch", () => {
|
|
it("says its runtime and rating in the new language", () => {
|
|
setLanguage("en");
|
|
render(<PlexPosterCard card={movie} onOpen={vi.fn()} />);
|
|
expect(screen.getByText("2 hr 4 min")).toBeTruthy();
|
|
act(() => setLanguage("hu"));
|
|
expect(screen.getByText("2 ó 4 p")).toBeTruthy();
|
|
expect(screen.getByText("8,3")).toBeTruthy();
|
|
});
|
|
});
|