peter
4aaaaa7860
The code cited its plan instead of saying why: `E28 review J4`, `(R6 S3b)`, `S1 justified…`,
`deep-review round 5`. That plan lives in the private ops repo, so for every reader of this one the
citation was noise, and a sentence whose subject was the plan step ("round 2 showed…") hid its
lesson behind an id. Each one is gone and the "why" kept: a bare citation is deleted, a sentence
carrying a lesson is reworded around it ("a later attempt showed…").
Measured (`scripts/audit_metrics.py`, product code): 652 lines in 270 files carried an epic code by
the definition the next commit holds (507 / 241 by the old, two-digit-only one) -> 0. Across all
code, tests, scripts and configs: ~1100 epic-code lines plus ~320 sprint/round ids.
Behaviour unchanged, checked mechanically: every changed .py file has the same AST once docstrings
are blanked; css/sh/toml/yml/json files are identical once comments are stripped; the only
non-comment changes in TS/JS are test titles, one description string in a contract table, and five
ESLint messages, whose text is all the gates snapshot diff holds. Not touched: Markdown (docs and
the changelog keep their history), Alembic migrations, TV episode notation (`S2 · E5`), DESIGN.md
ids (`C1`, `B4`, `S3h`), tracker ids (`SEC-16`, `DX-17`).
One stale claim fixed on the way: test_hls_reaper's docstring said the player checkpoints "every
10 s whether or not it is playing", which plex/stream.py calls wrong; it now says what the code does.
28 lines
1.4 KiB
TypeScript
28 lines
1.4 KiB
TypeScript
import type { ComponentType } from "react";
|
|
import { createStore } from "./store";
|
|
|
|
// A control that lives where the toasts live, under them (the debug recorder's pill).
|
|
//
|
|
// The toast stack already solves the hard part of "always visible, never in the way": it has a host
|
|
// in the page and one inside every overlay — the dialogs, both players, the fullscreen player — the
|
|
// topmost host shows it, and inside an overlay it sits above the player's control band. A control
|
|
// that must stay reachable while the user reproduces a bug anywhere needs exactly that, so it rides
|
|
// the same hosts instead of rebuilding them: `ui/Toaster` renders whatever is docked here below its
|
|
// stack, in the host that is on top.
|
|
//
|
|
// One slot, not a list: one surface uses it, and a second would have to decide how they share the
|
|
// corner before this grows.
|
|
const docked = createStore<ComponentType | null>(null);
|
|
|
|
/** Dock `component` under the toasts until the returned function undocks it. */
|
|
export function dockUnderToasts(component: ComponentType): () => void {
|
|
// Always the updater form: a component IS a function, so `set(component)` would be taken for one
|
|
// and called with the previous value instead of stored.
|
|
docked.set(() => component);
|
|
return () =>
|
|
docked.set((current: ComponentType | null) => (current === component ? null : current));
|
|
}
|
|
|
|
/** What is docked (the Toaster reads it). */
|
|
export const useToastDock = (): ComponentType | null => docked.useValue();
|