peter
4aaaaa7860
The code cited its plan instead of saying why: `E28 review J4`, `(R6 S3b)`, `S1 justified…`,
`deep-review round 5`. That plan lives in the private ops repo, so for every reader of this one the
citation was noise, and a sentence whose subject was the plan step ("round 2 showed…") hid its
lesson behind an id. Each one is gone and the "why" kept: a bare citation is deleted, a sentence
carrying a lesson is reworded around it ("a later attempt showed…").
Measured (`scripts/audit_metrics.py`, product code): 652 lines in 270 files carried an epic code by
the definition the next commit holds (507 / 241 by the old, two-digit-only one) -> 0. Across all
code, tests, scripts and configs: ~1100 epic-code lines plus ~320 sprint/round ids.
Behaviour unchanged, checked mechanically: every changed .py file has the same AST once docstrings
are blanked; css/sh/toml/yml/json files are identical once comments are stripped; the only
non-comment changes in TS/JS are test titles, one description string in a contract table, and five
ESLint messages, whose text is all the gates snapshot diff holds. Not touched: Markdown (docs and
the changelog keep their history), Alembic migrations, TV episode notation (`S2 · E5`), DESIGN.md
ids (`C1`, `B4`, `S3h`), tracker ids (`SEC-16`, `DX-17`).
One stale claim fixed on the way: test_hls_reaper's docstring said the player checkpoints "every
10 s whether or not it is playing", which plex/stream.py calls wrong; it now says what the code does.
32 lines
1.2 KiB
TypeScript
32 lines
1.2 KiB
TypeScript
// @vitest-environment jsdom
|
|
//
|
|
// "Skip to content" moves the focus to the page's <main> itself. Following its
|
|
// `#content` fragment would push a history entry, and the app reads every popstate as a page change.
|
|
import { afterEach, describe, expect, it } from "vitest";
|
|
import { cleanup, fireEvent, render, screen } from "@testing-library/react";
|
|
import { SkipLink } from "./SkipLink";
|
|
import { CONTENT_ID } from "./landmarks";
|
|
|
|
afterEach(cleanup);
|
|
|
|
describe("SkipLink", () => {
|
|
it("focuses the content region without touching the address", () => {
|
|
render(
|
|
<>
|
|
<SkipLink label="Skip to content" />
|
|
<main id={CONTENT_ID} tabIndex={-1}>
|
|
page
|
|
</main>
|
|
</>,
|
|
);
|
|
const before = window.location.href;
|
|
const link = screen.getByRole("link", { name: "Skip to content" });
|
|
// Off screen until focused, then a full-size button (sr-only / not-sr-only zeroed its padding).
|
|
expect(link.className).toContain("focus:translate-y-0");
|
|
expect(link.className).not.toMatch(/sr-only/);
|
|
fireEvent.click(link);
|
|
expect(document.activeElement?.id).toBe(CONTENT_ID);
|
|
expect(window.location.href).toBe(before);
|
|
});
|
|
});
|