peter
4aaaaa7860
The code cited its plan instead of saying why: `E28 review J4`, `(R6 S3b)`, `S1 justified…`,
`deep-review round 5`. That plan lives in the private ops repo, so for every reader of this one the
citation was noise, and a sentence whose subject was the plan step ("round 2 showed…") hid its
lesson behind an id. Each one is gone and the "why" kept: a bare citation is deleted, a sentence
carrying a lesson is reworded around it ("a later attempt showed…").
Measured (`scripts/audit_metrics.py`, product code): 652 lines in 270 files carried an epic code by
the definition the next commit holds (507 / 241 by the old, two-digit-only one) -> 0. Across all
code, tests, scripts and configs: ~1100 epic-code lines plus ~320 sprint/round ids.
Behaviour unchanged, checked mechanically: every changed .py file has the same AST once docstrings
are blanked; css/sh/toml/yml/json files are identical once comments are stripped; the only
non-comment changes in TS/JS are test titles, one description string in a contract table, and five
ESLint messages, whose text is all the gates snapshot diff holds. Not touched: Markdown (docs and
the changelog keep their history), Alembic migrations, TV episode notation (`S2 · E5`), DESIGN.md
ids (`C1`, `B4`, `S3h`), tracker ids (`SEC-16`, `DX-17`).
One stale claim fixed on the way: test_hls_reaper's docstring said the player checkpoints "every
10 s whether or not it is playing", which plex/stream.py calls wrong; it now says what the code does.
52 lines
2.1 KiB
TypeScript
52 lines
2.1 KiB
TypeScript
// @vitest-environment jsdom
|
||
//
|
||
// Audit: the Switch was a bare 36×20 track — under the 24 floor on a mouse, never the 44 touch box
|
||
// DESIGN.md A3 lists it under, and its name was optional, so the Plex-sync switch shipped nameless.
|
||
import { afterEach, describe, expect, it, vi } from "vitest";
|
||
import { cleanup, fireEvent, render, screen } from "@testing-library/react";
|
||
|
||
import { Switch, SwitchRow } from "./form";
|
||
|
||
afterEach(cleanup);
|
||
|
||
describe("Switch", () => {
|
||
it("is a named switch whose own box meets the 24 floor and grows to the touch target", () => {
|
||
const onChange = vi.fn();
|
||
render(<Switch label="Dark mode" checked={false} onChange={onChange} />);
|
||
const sw = screen.getByRole("switch", { name: "Dark mode" });
|
||
expect(sw.getAttribute("aria-checked")).toBe("false");
|
||
expect(sw.className).toContain("h-6");
|
||
expect(sw.className).toContain("pointer-coarse:min-h-(--touch-target)");
|
||
fireEvent.click(sw);
|
||
expect(onChange).toHaveBeenCalledWith(true);
|
||
});
|
||
|
||
it("cannot be rendered without a name", () => {
|
||
// @ts-expect-error — `label` is required: a switch has no text of its own to be named by.
|
||
render(<Switch checked onChange={() => {}} />);
|
||
expect(screen.getByRole("switch")).toBeTruthy();
|
||
});
|
||
});
|
||
|
||
describe("SwitchRow", () => {
|
||
// Owner decision F12: a settings row toggles from its whole surface, as on iOS and in Material.
|
||
it("toggles from its text as well as from the switch, once per click", () => {
|
||
const onChange = vi.fn();
|
||
render(
|
||
<SwitchRow label="Dark mode" hint="Easier on the eyes" checked={false} onChange={onChange} />,
|
||
);
|
||
fireEvent.click(screen.getByText("Dark mode"));
|
||
expect(onChange).toHaveBeenCalledTimes(1);
|
||
fireEvent.click(screen.getByRole("switch", { name: "Dark mode" }));
|
||
expect(onChange).toHaveBeenCalledTimes(2);
|
||
expect(onChange).toHaveBeenLastCalledWith(true);
|
||
});
|
||
|
||
it("does nothing from its text while disabled", () => {
|
||
const onChange = vi.fn();
|
||
render(<SwitchRow label="Sync" checked onChange={onChange} disabled />);
|
||
fireEvent.click(screen.getByText("Sync"));
|
||
expect(onChange).not.toHaveBeenCalled();
|
||
});
|
||
});
|