peter
4aaaaa7860
The code cited its plan instead of saying why: `E28 review J4`, `(R6 S3b)`, `S1 justified…`,
`deep-review round 5`. That plan lives in the private ops repo, so for every reader of this one the
citation was noise, and a sentence whose subject was the plan step ("round 2 showed…") hid its
lesson behind an id. Each one is gone and the "why" kept: a bare citation is deleted, a sentence
carrying a lesson is reworded around it ("a later attempt showed…").
Measured (`scripts/audit_metrics.py`, product code): 652 lines in 270 files carried an epic code by
the definition the next commit holds (507 / 241 by the old, two-digit-only one) -> 0. Across all
code, tests, scripts and configs: ~1100 epic-code lines plus ~320 sprint/round ids.
Behaviour unchanged, checked mechanically: every changed .py file has the same AST once docstrings
are blanked; css/sh/toml/yml/json files are identical once comments are stripped; the only
non-comment changes in TS/JS are test titles, one description string in a contract table, and five
ESLint messages, whose text is all the gates snapshot diff holds. Not touched: Markdown (docs and
the changelog keep their history), Alembic migrations, TV episode notation (`S2 · E5`), DESIGN.md
ids (`C1`, `B4`, `S3h`), tracker ids (`SEC-16`, `DX-17`).
One stale claim fixed on the way: test_hls_reaper's docstring said the player checkpoints "every
10 s whether or not it is playing", which plex/stream.py calls wrong; it now says what the code does.
25 lines
1.1 KiB
TypeScript
25 lines
1.1 KiB
TypeScript
// The owner's pick: the channel page's tall header folds to one row once the grid scrolls. The header
|
|
// is fixed, so folding gives the scroller its height back — these are the rules that keep that from
|
|
// flickering on a page barely taller than the window.
|
|
import { describe, expect, it } from "vitest";
|
|
import { FOLD_AT, nextFolded } from "./scrollFold";
|
|
|
|
const SAVING = 200;
|
|
|
|
describe("nextFolded", () => {
|
|
it("folds once the content scrolls past the fold point", () => {
|
|
expect(nextFolded(false, { top: FOLD_AT + 1, room: 5000 }, SAVING)).toBe(true);
|
|
expect(nextFolded(false, { top: FOLD_AT, room: 5000 }, SAVING)).toBe(false);
|
|
});
|
|
|
|
it("does not fold a page that could not stay scrolled once the header gave its height back", () => {
|
|
expect(nextFolded(false, { top: 100, room: SAVING + FOLD_AT }, SAVING)).toBe(false);
|
|
expect(nextFolded(false, { top: 100, room: SAVING + FOLD_AT + 1 }, SAVING)).toBe(true);
|
|
});
|
|
|
|
it("stays folded until the very top, not back at the fold point", () => {
|
|
expect(nextFolded(true, { top: 1, room: 5000 }, SAVING)).toBe(true);
|
|
expect(nextFolded(true, { top: 0, room: 5000 }, SAVING)).toBe(false);
|
|
});
|
|
});
|