peter
062015ba27
Split the two URL-derived nav seeds out of NavigationProvider into navigationInit.ts so they're unit-testable and the provider stays react-refresh-clean (component-only exports). channelViewFrom also dedups the identical _chan/?chan resolve the channelView seed and the onPop handler each hand-rolled — locking the S1 fix (a popstate on a URL-only bookmark entry must restore the channel from ?chan, not close it). Pure code motion. Tests: the full loadInitialPage precedence matrix (?page > ?v > ?pl > filters/?chan > stored landing > feed, with the beats-a-lower-param cases) and channelViewFrom (_chan+name, ?chan fallback, state-over-url, closed → null). 15 tests; full FE gate green (tsc/eslint/prettier/knip).
96 lines
3.5 KiB
TypeScript
96 lines
3.5 KiB
TypeScript
// @vitest-environment jsdom
|
|
//
|
|
// NavigationProvider's URL-derived seeds, backfilling the E4 deep-review's deferred coverage:
|
|
// • loadInitialPage — the bookmark deep-link precedence (?page > ?v > ?pl > filters/?chan > the
|
|
// account's stored landing page > feed).
|
|
// • channelViewFrom — the shared _chan/?chan resolver behind BOTH the channelView seed and the
|
|
// onPop handler (the S1 fix): a popstate landing on a URL-only bookmark entry must restore the
|
|
// channel from ?chan, not close it.
|
|
// Only getAccountRaw is stubbed (the account's stored landing page); everything else is real.
|
|
import { describe, it, expect, beforeEach, vi } from "vitest";
|
|
|
|
const { stored } = vi.hoisted(() => ({ stored: {} as Record<string, string | null> }));
|
|
vi.mock("../lib/storage", async (importOriginal) => {
|
|
const actual = await importOriginal<typeof import("../lib/storage")>();
|
|
return { ...actual, getAccountRaw: (k: string) => stored[k] ?? null };
|
|
});
|
|
|
|
import { loadInitialPage, channelViewFrom } from "./navigationInit";
|
|
import { LS } from "../lib/storage";
|
|
|
|
const setUrl = (search: string) => window.history.replaceState(null, "", search || "/");
|
|
|
|
beforeEach(() => {
|
|
setUrl("/");
|
|
for (const k of Object.keys(stored)) delete stored[k];
|
|
});
|
|
|
|
describe("loadInitialPage precedence", () => {
|
|
it("?page wins and is validated", () => {
|
|
setUrl("?page=stats");
|
|
expect(loadInitialPage()).toBe("stats");
|
|
});
|
|
it("an invalid ?page falls back to feed", () => {
|
|
setUrl("?page=bogus");
|
|
expect(loadInitialPage()).toBe("feed");
|
|
});
|
|
it("?v implies the plex module", () => {
|
|
setUrl("?v=show:1");
|
|
expect(loadInitialPage()).toBe("plex");
|
|
});
|
|
it("?pl implies playlists", () => {
|
|
setUrl("?pl=3");
|
|
expect(loadInitialPage()).toBe("playlists");
|
|
});
|
|
it("a filter param implies the feed", () => {
|
|
setUrl("?tags=1,2");
|
|
expect(loadInitialPage()).toBe("feed");
|
|
});
|
|
it("?chan (the channel overlay) implies the feed", () => {
|
|
setUrl("?chan=UC1");
|
|
expect(loadInitialPage()).toBe("feed");
|
|
});
|
|
it("?page beats a lower-precedence param", () => {
|
|
setUrl("?page=stats&v=show:1");
|
|
expect(loadInitialPage()).toBe("stats");
|
|
});
|
|
it("?v beats ?pl and filters", () => {
|
|
setUrl("?v=show:1&pl=3&tags=1");
|
|
expect(loadInitialPage()).toBe("plex");
|
|
});
|
|
it("a bare URL uses the account's stored landing page", () => {
|
|
stored[LS.page] = "downloads";
|
|
expect(loadInitialPage()).toBe("downloads");
|
|
});
|
|
it("a bare URL with no / invalid stored page defaults to feed", () => {
|
|
expect(loadInitialPage()).toBe("feed");
|
|
stored[LS.page] = "nope";
|
|
expect(loadInitialPage()).toBe("feed");
|
|
});
|
|
});
|
|
|
|
describe("channelViewFrom", () => {
|
|
it("reads _chan (+ _chanName) from an in-app entry", () => {
|
|
expect(channelViewFrom({ _chan: "UC1", _chanName: "Chan" }, "")).toEqual({
|
|
id: "UC1",
|
|
name: "Chan",
|
|
});
|
|
});
|
|
it("_chan without a name yields an undefined name", () => {
|
|
expect(channelViewFrom({ _chan: "UC1" }, "")).toEqual({ id: "UC1", name: undefined });
|
|
});
|
|
it("falls back to the ?chan URL param when the entry has no _chan (fresh bookmark) — the S1 fix", () => {
|
|
expect(channelViewFrom(null, "?chan=UC9")).toEqual({ id: "UC9", name: undefined });
|
|
});
|
|
it("prefers _chan over the URL param", () => {
|
|
expect(channelViewFrom({ _chan: "UCstate" }, "?chan=UCurl")).toEqual({
|
|
id: "UCstate",
|
|
name: undefined,
|
|
});
|
|
});
|
|
it("returns null when neither is present (channel closed)", () => {
|
|
expect(channelViewFrom({}, "")).toBeNull();
|
|
expect(channelViewFrom(null, "/")).toBeNull();
|
|
});
|
|
});
|