peter
4aaaaa7860
The code cited its plan instead of saying why: `E28 review J4`, `(R6 S3b)`, `S1 justified…`,
`deep-review round 5`. That plan lives in the private ops repo, so for every reader of this one the
citation was noise, and a sentence whose subject was the plan step ("round 2 showed…") hid its
lesson behind an id. Each one is gone and the "why" kept: a bare citation is deleted, a sentence
carrying a lesson is reworded around it ("a later attempt showed…").
Measured (`scripts/audit_metrics.py`, product code): 652 lines in 270 files carried an epic code by
the definition the next commit holds (507 / 241 by the old, two-digit-only one) -> 0. Across all
code, tests, scripts and configs: ~1100 epic-code lines plus ~320 sprint/round ids.
Behaviour unchanged, checked mechanically: every changed .py file has the same AST once docstrings
are blanked; css/sh/toml/yml/json files are identical once comments are stripped; the only
non-comment changes in TS/JS are test titles, one description string in a contract table, and five
ESLint messages, whose text is all the gates snapshot diff holds. Not touched: Markdown (docs and
the changelog keep their history), Alembic migrations, TV episode notation (`S2 · E5`), DESIGN.md
ids (`C1`, `B4`, `S3h`), tracker ids (`SEC-16`, `DX-17`).
One stale claim fixed on the way: test_hls_reaper's docstring said the player checkpoints "every
10 s whether or not it is playing", which plex/stream.py calls wrong; it now says what the code does.
40 lines
1.5 KiB
TypeScript
40 lines
1.5 KiB
TypeScript
import { readdirSync, readFileSync } from "node:fs";
|
|
|
|
import { describe, expect, it } from "vitest";
|
|
|
|
// DESIGN.md B4, UX-15. One `h1` per page: the shell's hidden page name, or a view's own visible
|
|
// title through `PageHeading`, which makes the shell's step aside. A hand-written `<h1>` inside the
|
|
// shell would be a second one, beside the page name the shell already put there.
|
|
function sources(): Array<[string, string]> {
|
|
const walk = (u: URL, prefix: string): Array<[string, string]> =>
|
|
readdirSync(u, { withFileTypes: true }).flatMap((e) => {
|
|
if (e.isDirectory()) return walk(new URL(`${e.name}/`, u), `${prefix}${e.name}/`);
|
|
if (!/\.tsx$/.test(e.name) || e.name.includes(".test.")) return [];
|
|
return [
|
|
[`${prefix}${e.name}`, readFileSync(new URL(e.name, u), "utf-8")] as [string, string],
|
|
];
|
|
});
|
|
return walk(new URL("../", import.meta.url), "");
|
|
}
|
|
|
|
// Pages that render OUTSIDE the app shell own their h1 (no shell, no hidden page name).
|
|
const STANDALONE = new Set([
|
|
"components/Welcome.tsx",
|
|
"components/WatchPage.tsx",
|
|
"components/legal/LegalLayout.tsx",
|
|
"design-lab/DesignLab.tsx",
|
|
// The shell's hidden h1 and the primitive itself.
|
|
"components/ui/PageShell.tsx",
|
|
"components/ui/Headings.tsx",
|
|
]);
|
|
|
|
describe("the page heading", () => {
|
|
it("is written as PageHeading inside the shell, never as a hand <h1>", () => {
|
|
const own = sources()
|
|
.filter(([name]) => !STANDALONE.has(name))
|
|
.filter(([, src]) => /<h1[\s>]/.test(src))
|
|
.map(([name]) => name);
|
|
expect(own).toEqual([]);
|
|
});
|
|
});
|