peter
4aaaaa7860
The code cited its plan instead of saying why: `E28 review J4`, `(R6 S3b)`, `S1 justified…`,
`deep-review round 5`. That plan lives in the private ops repo, so for every reader of this one the
citation was noise, and a sentence whose subject was the plan step ("round 2 showed…") hid its
lesson behind an id. Each one is gone and the "why" kept: a bare citation is deleted, a sentence
carrying a lesson is reworded around it ("a later attempt showed…").
Measured (`scripts/audit_metrics.py`, product code): 652 lines in 270 files carried an epic code by
the definition the next commit holds (507 / 241 by the old, two-digit-only one) -> 0. Across all
code, tests, scripts and configs: ~1100 epic-code lines plus ~320 sprint/round ids.
Behaviour unchanged, checked mechanically: every changed .py file has the same AST once docstrings
are blanked; css/sh/toml/yml/json files are identical once comments are stripped; the only
non-comment changes in TS/JS are test titles, one description string in a contract table, and five
ESLint messages, whose text is all the gates snapshot diff holds. Not touched: Markdown (docs and
the changelog keep their history), Alembic migrations, TV episode notation (`S2 · E5`), DESIGN.md
ids (`C1`, `B4`, `S3h`), tracker ids (`SEC-16`, `DX-17`).
One stale claim fixed on the way: test_hls_reaper's docstring said the player checkpoints "every
10 s whether or not it is playing", which plex/stream.py calls wrong; it now says what the code does.
56 lines
2.0 KiB
TypeScript
56 lines
2.0 KiB
TypeScript
// @vitest-environment jsdom
|
|
//
|
|
// One screenshot of this tab. The browser's picker is stubbed (jsdom has no Screen Capture API):
|
|
// a cancelled or refused picker is the user saying no (null, no error); anything else is an error;
|
|
// a tab that was shared but gave no frame is an error too, not a silent nothing; and the capture is
|
|
// stopped whatever happened — nothing keeps sharing the tab after one frame.
|
|
import { afterEach, describe, expect, it, vi } from "vitest";
|
|
|
|
import { captureTab } from "./captureTab";
|
|
|
|
function stubPicker(result: () => Promise<MediaStream>) {
|
|
Object.defineProperty(navigator, "mediaDevices", {
|
|
configurable: true,
|
|
value: { getDisplayMedia: vi.fn(result) },
|
|
});
|
|
}
|
|
|
|
function fakeStream() {
|
|
const track = { stop: vi.fn() };
|
|
return { stream: { getTracks: () => [track] } as unknown as MediaStream, track };
|
|
}
|
|
|
|
afterEach(() => {
|
|
vi.restoreAllMocks();
|
|
Reflect.deleteProperty(navigator, "mediaDevices");
|
|
});
|
|
|
|
describe("captureTab", () => {
|
|
it.each(["NotAllowedError", "AbortError"])(
|
|
"a %s from the picker is the user saying no",
|
|
async (name) => {
|
|
stubPicker(() => Promise.reject(new DOMException("no", name)));
|
|
await expect(captureTab()).resolves.toBeNull();
|
|
},
|
|
);
|
|
|
|
it("any other failure of the picker is an error", async () => {
|
|
stubPicker(() => Promise.reject(new DOMException("broken", "NotReadableError")));
|
|
await expect(captureTab()).rejects.toMatchObject({ name: "NotReadableError" });
|
|
});
|
|
|
|
it("a shared tab that gives no frame is an error, and the capture is stopped", async () => {
|
|
vi.useFakeTimers();
|
|
const { stream, track } = fakeStream();
|
|
stubPicker(() => Promise.resolve(stream));
|
|
vi.spyOn(HTMLMediaElement.prototype, "play").mockResolvedValue();
|
|
// jsdom's video never has a size: no frame arrives.
|
|
const result = captureTab();
|
|
const settled = expect(result).rejects.toMatchObject({ name: "NoFrameError" });
|
|
await vi.advanceTimersByTimeAsync(2_000);
|
|
await settled;
|
|
expect(track.stop).toHaveBeenCalled();
|
|
vi.useRealTimers();
|
|
});
|
|
});
|