peter
4aaaaa7860
The code cited its plan instead of saying why: `E28 review J4`, `(R6 S3b)`, `S1 justified…`,
`deep-review round 5`. That plan lives in the private ops repo, so for every reader of this one the
citation was noise, and a sentence whose subject was the plan step ("round 2 showed…") hid its
lesson behind an id. Each one is gone and the "why" kept: a bare citation is deleted, a sentence
carrying a lesson is reworded around it ("a later attempt showed…").
Measured (`scripts/audit_metrics.py`, product code): 652 lines in 270 files carried an epic code by
the definition the next commit holds (507 / 241 by the old, two-digit-only one) -> 0. Across all
code, tests, scripts and configs: ~1100 epic-code lines plus ~320 sprint/round ids.
Behaviour unchanged, checked mechanically: every changed .py file has the same AST once docstrings
are blanked; css/sh/toml/yml/json files are identical once comments are stripped; the only
non-comment changes in TS/JS are test titles, one description string in a contract table, and five
ESLint messages, whose text is all the gates snapshot diff holds. Not touched: Markdown (docs and
the changelog keep their history), Alembic migrations, TV episode notation (`S2 · E5`), DESIGN.md
ids (`C1`, `B4`, `S3h`), tracker ids (`SEC-16`, `DX-17`).
One stale claim fixed on the way: test_hls_reaper's docstring said the player checkpoints "every
10 s whether or not it is playing", which plex/stream.py calls wrong; it now says what the code does.
51 lines
1.6 KiB
TypeScript
51 lines
1.6 KiB
TypeScript
// @vitest-environment jsdom
|
|
//
|
|
// The stamp `rememberNavPosition` leaves in history.state survives a reload, but module state does not:
|
|
// the listener that reads it was installed by the first push, so after F5 the first Back onto a
|
|
// stamped entry restored nothing. Its own file, because the point is a
|
|
// module that has made NO push yet — any other test in history.navPosition would have made one.
|
|
import { useRef } from "react";
|
|
import { afterEach, expect, it } from "vitest";
|
|
import { act, cleanup, render, waitFor } from "@testing-library/react";
|
|
import "./history";
|
|
import { navItemAttrs, useListNav } from "./listNav";
|
|
|
|
function List({ id, count }: { id: string; count: number }) {
|
|
const ref = useRef<HTMLDivElement>(null);
|
|
useListNav(ref, { enabled: true });
|
|
return (
|
|
<div ref={ref}>
|
|
{Array.from({ length: count }, (_, i) => (
|
|
<div key={i} data-testid={`${id}${i}`} {...navItemAttrs(i)}>
|
|
{id}
|
|
{i}
|
|
</div>
|
|
))}
|
|
</div>
|
|
);
|
|
}
|
|
|
|
afterEach(() => {
|
|
cleanup();
|
|
window.history.replaceState(null, "");
|
|
});
|
|
|
|
it("restores on a landing before this load has pushed anything", async () => {
|
|
// An entry stamped before the reload: list 1 of 2, item 1.
|
|
const state = { sfPage: "home", sfNav: { list: 1, lists: 2, index: 1 } };
|
|
window.history.replaceState(state, "");
|
|
render(
|
|
<>
|
|
<List id="a" count={2} />
|
|
<List id="b" count={3} />
|
|
</>,
|
|
);
|
|
act(() => {
|
|
window.dispatchEvent(new PopStateEvent("popstate", { state }));
|
|
});
|
|
await waitFor(() =>
|
|
expect((document.activeElement as HTMLElement | null)?.dataset.testid).toBe("b1"),
|
|
);
|
|
expect(window.history.state.sfNav).toBeUndefined();
|
|
});
|