peter
4aaaaa7860
The code cited its plan instead of saying why: `E28 review J4`, `(R6 S3b)`, `S1 justified…`,
`deep-review round 5`. That plan lives in the private ops repo, so for every reader of this one the
citation was noise, and a sentence whose subject was the plan step ("round 2 showed…") hid its
lesson behind an id. Each one is gone and the "why" kept: a bare citation is deleted, a sentence
carrying a lesson is reworded around it ("a later attempt showed…").
Measured (`scripts/audit_metrics.py`, product code): 652 lines in 270 files carried an epic code by
the definition the next commit holds (507 / 241 by the old, two-digit-only one) -> 0. Across all
code, tests, scripts and configs: ~1100 epic-code lines plus ~320 sprint/round ids.
Behaviour unchanged, checked mechanically: every changed .py file has the same AST once docstrings
are blanked; css/sh/toml/yml/json files are identical once comments are stripped; the only
non-comment changes in TS/JS are test titles, one description string in a contract table, and five
ESLint messages, whose text is all the gates snapshot diff holds. Not touched: Markdown (docs and
the changelog keep their history), Alembic migrations, TV episode notation (`S2 · E5`), DESIGN.md
ids (`C1`, `B4`, `S3h`), tracker ids (`SEC-16`, `DX-17`).
One stale claim fixed on the way: test_hls_reaper's docstring said the player checkpoints "every
10 s whether or not it is playing", which plex/stream.py calls wrong; it now says what the code does.
44 lines
1.8 KiB
TypeScript
44 lines
1.8 KiB
TypeScript
import { describe, expect, it } from "vitest";
|
|
|
|
import { eslint } from "./lintProbe.testkit";
|
|
|
|
// "Every request is logged" lives in eslint.config.js, not prose: `fetch`, `XMLHttpRequest`
|
|
// and `WebSocket` each belong to ONE module that logs them, and `console` to none. A restriction
|
|
// that matches nothing looks exactly like a clean codebase, so this asserts the rules FIRE — and
|
|
// that each owner is exempt from its own global only.
|
|
const RULES = new Set(["no-restricted-globals", "no-restricted-properties", "no-console"]);
|
|
|
|
async function flagged(source: string, filePath: string): Promise<string[]> {
|
|
const [result] = await eslint.lintText(source, { filePath });
|
|
return (result?.messages ?? [])
|
|
.filter((m) => m.ruleId && RULES.has(m.ruleId))
|
|
.map((m) => `${m.ruleId}: ${m.message}`);
|
|
}
|
|
|
|
const ALL = [
|
|
`export const a = () => fetch("/x");`,
|
|
`export const b = () => new XMLHttpRequest();`,
|
|
`export const c = () => new WebSocket("wss://x");`,
|
|
`export const d = () => window.fetch("/x");`,
|
|
`export const e = () => navigator.sendBeacon("/x");`,
|
|
`export const f = () => console.log("x");`,
|
|
].join("\n");
|
|
|
|
describe("network and console boundary", () => {
|
|
it("refuses every way out of the browser, and console, in an ordinary module", async () => {
|
|
const found = await flagged(ALL, "src/components/__network_probe.tsx");
|
|
expect(found).toHaveLength(6);
|
|
expect(found.filter((f) => f.startsWith("no-console"))).toHaveLength(1);
|
|
});
|
|
|
|
it.each([
|
|
["src/lib/http.ts", "fetch"],
|
|
["src/lib/api/core.ts", "XMLHttpRequest"],
|
|
])("%s may use %s — and nothing else", async (owner, own) => {
|
|
const found = await flagged(ALL, owner);
|
|
// Its own global goes quiet; the other two globals, the two properties and console still fire.
|
|
expect(found).toHaveLength(5);
|
|
expect(found.some((f) => f.includes(`\`${own}\``))).toBe(false);
|
|
});
|
|
});
|