peter
4aaaaa7860
The code cited its plan instead of saying why: `E28 review J4`, `(R6 S3b)`, `S1 justified…`,
`deep-review round 5`. That plan lives in the private ops repo, so for every reader of this one the
citation was noise, and a sentence whose subject was the plan step ("round 2 showed…") hid its
lesson behind an id. Each one is gone and the "why" kept: a bare citation is deleted, a sentence
carrying a lesson is reworded around it ("a later attempt showed…").
Measured (`scripts/audit_metrics.py`, product code): 652 lines in 270 files carried an epic code by
the definition the next commit holds (507 / 241 by the old, two-digit-only one) -> 0. Across all
code, tests, scripts and configs: ~1100 epic-code lines plus ~320 sprint/round ids.
Behaviour unchanged, checked mechanically: every changed .py file has the same AST once docstrings
are blanked; css/sh/toml/yml/json files are identical once comments are stripped; the only
non-comment changes in TS/JS are test titles, one description string in a contract table, and five
ESLint messages, whose text is all the gates snapshot diff holds. Not touched: Markdown (docs and
the changelog keep their history), Alembic migrations, TV episode notation (`S2 · E5`), DESIGN.md
ids (`C1`, `B4`, `S3h`), tracker ids (`SEC-16`, `DX-17`).
One stale claim fixed on the way: test_hls_reaper's docstring said the player checkpoints "every
10 s whether or not it is playing", which plex/stream.py calls wrong; it now says what the code does.
51 lines
3.0 KiB
TypeScript
51 lines
3.0 KiB
TypeScript
import { useEffect, useEffectEvent, type RefObject } from "react";
|
|
import { useLayer } from "./layerStack";
|
|
|
|
/** While `active`, close (call `onClose`) on Escape or a mousedown outside ALL of the given
|
|
* element(s). The reusable half of the popover/dropdown pattern that several components each
|
|
* hand-rolled; positioning stays with the caller (it varies per popover). Pass the panel ref
|
|
* (and optionally a trigger ref so clicking the trigger doesn't immediately re-close).
|
|
*
|
|
* Escape is dispatched through the shared `layerStack`: the popover registers as a layer and
|
|
* closes only when it is topmost, so a Modal or another popover opened above it takes the Escape
|
|
* first, and a player below defers to it. This replaces the old blanket `stopPropagation` — which
|
|
* swallowed a player's own Escape (e.g. PlexPlayer's auto-skip-cancel) whenever any popover was open. */
|
|
export function useDismiss(
|
|
active: boolean,
|
|
onClose: () => void,
|
|
refs: RefObject<HTMLElement | null> | RefObject<HTMLElement | null>[],
|
|
): void {
|
|
// Registration + topmost-only Escape. `trapsTab: false`, because this hook installs NO Tab trap:
|
|
// it owns Escape and the outside-press, nothing more. Claiming the trap made a dialog underneath
|
|
// stand its own down (`anyBlockingLayerAbove`) for a layer that traps nothing, so Tab walked out
|
|
// of the dialog while one of its own menus was open — measured in a real browser on the Plex
|
|
// player, whose settings and track menus are both dismissables. Every
|
|
// consumer renders its panel INSIDE the surface below it, so that surface's trap already spans
|
|
// the panel; a portaled one would need its own trap and must not use this default.
|
|
useLayer(active, onClose, { trapsTab: false });
|
|
|
|
// Outside-press stays per-instance (the refs/positioning are the caller's): close on a mousedown
|
|
// that lands outside every registered element.
|
|
// Both arguments are read through an effect event so the listener can stay subscribed once per open/close —
|
|
// which is the point of the `[active]` dep list — without going STALE. The disabled dep list this
|
|
// replaces asserted that onClose was "read fresh from this run's closure"; it was not. The closure
|
|
// is built when `active` last flipped, so a caller that re-rendered with a different handler while
|
|
// the popover stayed open kept getting the old one called (regression test in useDismiss.dom.test).
|
|
// `refs` is the weaker case — the ref OBJECTS are stable, so a late-mounting node is seen either
|
|
// way — but a caller that changes WHICH refs it passes while open was equally ignored.
|
|
const onPress = useEffectEvent((e: MouseEvent) => {
|
|
const list = Array.isArray(refs) ? refs : [refs];
|
|
const target = e.target as Node;
|
|
if (!list.some((r) => r.current?.contains(target))) onClose();
|
|
});
|
|
|
|
useEffect(() => {
|
|
if (!active) return;
|
|
const onDown = (e: MouseEvent) => onPress(e);
|
|
document.addEventListener("mousedown", onDown);
|
|
return () => {
|
|
document.removeEventListener("mousedown", onDown);
|
|
};
|
|
}, [active]);
|
|
}
|