peter
4aaaaa7860
The code cited its plan instead of saying why: `E28 review J4`, `(R6 S3b)`, `S1 justified…`,
`deep-review round 5`. That plan lives in the private ops repo, so for every reader of this one the
citation was noise, and a sentence whose subject was the plan step ("round 2 showed…") hid its
lesson behind an id. Each one is gone and the "why" kept: a bare citation is deleted, a sentence
carrying a lesson is reworded around it ("a later attempt showed…").
Measured (`scripts/audit_metrics.py`, product code): 652 lines in 270 files carried an epic code by
the definition the next commit holds (507 / 241 by the old, two-digit-only one) -> 0. Across all
code, tests, scripts and configs: ~1100 epic-code lines plus ~320 sprint/round ids.
Behaviour unchanged, checked mechanically: every changed .py file has the same AST once docstrings
are blanked; css/sh/toml/yml/json files are identical once comments are stripped; the only
non-comment changes in TS/JS are test titles, one description string in a contract table, and five
ESLint messages, whose text is all the gates snapshot diff holds. Not touched: Markdown (docs and
the changelog keep their history), Alembic migrations, TV episode notation (`S2 · E5`), DESIGN.md
ids (`C1`, `B4`, `S3h`), tracker ids (`SEC-16`, `DX-17`).
One stale claim fixed on the way: test_hls_reaper's docstring said the player checkpoints "every
10 s whether or not it is playing", which plex/stream.py calls wrong; it now says what the code does.
45 lines
2.1 KiB
JavaScript
45 lines
2.1 KiB
JavaScript
#!/usr/bin/env node
|
|
// Does frontend/node_modules hold exactly what frontend/package-lock.json pins?
|
|
//
|
|
// The local gate's frontend lanes run against the HOST's node_modules, and nothing tied that tree to
|
|
// the lock: a `git pull` that bumped a dependency, or an `npm install` that was never committed, left
|
|
// tsc/eslint/vitest judging the code against packages the build image (`npm ci`) does not use — a
|
|
// green that proves nothing about what ships, in either direction. CI is immune (it runs `npm ci`);
|
|
// this makes the local lanes say so instead of quietly differing.
|
|
//
|
|
// Checks every package the lock places under node_modules/: present, at the pinned version. A package
|
|
// marked `optional` may be absent (a platform binary for another OS). Exit 1 with the list and the
|
|
// one command that fixes it.
|
|
import { existsSync, readFileSync } from "node:fs";
|
|
import { dirname, join } from "node:path";
|
|
import { fileURLToPath } from "node:url";
|
|
|
|
const FRONTEND = join(dirname(fileURLToPath(import.meta.url)), "..", "frontend");
|
|
const lock = JSON.parse(readFileSync(join(FRONTEND, "package-lock.json"), "utf8"));
|
|
|
|
const problems = [];
|
|
for (const [path, entry] of Object.entries(lock.packages ?? {})) {
|
|
if (!path.startsWith("node_modules/") || entry.link) continue;
|
|
const manifest = join(FRONTEND, path, "package.json");
|
|
if (!existsSync(manifest)) {
|
|
if (!entry.optional) problems.push(`missing ${path.slice(13)}@${entry.version}`);
|
|
continue;
|
|
}
|
|
const installed = JSON.parse(readFileSync(manifest, "utf8")).version;
|
|
if (installed !== entry.version)
|
|
problems.push(
|
|
`mismatch ${path.slice(13)}: installed ${installed}, lock pins ${entry.version}`,
|
|
);
|
|
}
|
|
|
|
if (problems.length) {
|
|
console.error(`frontend/node_modules does not match package-lock.json (${problems.length}):`);
|
|
for (const p of problems.slice(0, 20)) console.error(` ${p}`);
|
|
if (problems.length > 20) console.error(` … and ${problems.length - 20} more`);
|
|
console.error("Fix: cd frontend && npm ci");
|
|
process.exit(1);
|
|
}
|
|
console.log(
|
|
`node_modules matches package-lock.json (${Object.keys(lock.packages).length - 1} entries)`,
|
|
);
|