peter
4aaaaa7860
The code cited its plan instead of saying why: `E28 review J4`, `(R6 S3b)`, `S1 justified…`,
`deep-review round 5`. That plan lives in the private ops repo, so for every reader of this one the
citation was noise, and a sentence whose subject was the plan step ("round 2 showed…") hid its
lesson behind an id. Each one is gone and the "why" kept: a bare citation is deleted, a sentence
carrying a lesson is reworded around it ("a later attempt showed…").
Measured (`scripts/audit_metrics.py`, product code): 652 lines in 270 files carried an epic code by
the definition the next commit holds (507 / 241 by the old, two-digit-only one) -> 0. Across all
code, tests, scripts and configs: ~1100 epic-code lines plus ~320 sprint/round ids.
Behaviour unchanged, checked mechanically: every changed .py file has the same AST once docstrings
are blanked; css/sh/toml/yml/json files are identical once comments are stripped; the only
non-comment changes in TS/JS are test titles, one description string in a contract table, and five
ESLint messages, whose text is all the gates snapshot diff holds. Not touched: Markdown (docs and
the changelog keep their history), Alembic migrations, TV episode notation (`S2 · E5`), DESIGN.md
ids (`C1`, `B4`, `S3h`), tracker ids (`SEC-16`, `DX-17`).
One stale claim fixed on the way: test_hls_reaper's docstring said the player checkpoints "every
10 s whether or not it is playing", which plex/stream.py calls wrong; it now says what the code does.
57 lines
2.3 KiB
TypeScript
57 lines
2.3 KiB
TypeScript
import { describe, it, expect } from "vitest";
|
|
import { pickDefaultToSeed, preferSticky } from "./savedViews";
|
|
|
|
const v = (id: number) => ({ id, name: `v${id}` });
|
|
|
|
describe("preferSticky", () => {
|
|
it("returns null when nothing matches", () => {
|
|
expect(preferSticky([], 3)).toBeNull();
|
|
expect(preferSticky([], null)).toBeNull();
|
|
});
|
|
|
|
it("returns the only match regardless of stickyId", () => {
|
|
expect(preferSticky([v(5)], null)?.id).toBe(5);
|
|
expect(preferSticky([v(5)], 99)?.id).toBe(5);
|
|
});
|
|
|
|
it("prefers the sticky view among several identical-filter matches", () => {
|
|
// A (id 1) is earlier in the list, B (id 2) was explicitly applied (sticky).
|
|
expect(preferSticky([v(1), v(2)], 2)?.id).toBe(2);
|
|
});
|
|
|
|
it("without a sticky match, prefers the starred default over an earlier twin", () => {
|
|
// The first-load seed applies the default's filters and leaves the name to this tie-break: an
|
|
// earlier view with the same filters must not take the default's name.
|
|
const d = (id: number, is_default = false) => ({ id, name: `v${id}`, is_default });
|
|
expect(preferSticky([d(1), d(2, true)], null)?.id).toBe(2);
|
|
expect(preferSticky([d(1), d(2, true)], 99)?.id).toBe(2);
|
|
expect(preferSticky([d(1), d(2, true)], 1)?.id).toBe(1);
|
|
});
|
|
|
|
it("falls back to the first match when the sticky id isn't among the matches", () => {
|
|
expect(preferSticky([v(1), v(2)], 99)?.id).toBe(1);
|
|
expect(preferSticky([v(1), v(2)], null)?.id).toBe(1);
|
|
});
|
|
});
|
|
|
|
describe("pickDefaultToSeed", () => {
|
|
const dv = (id: number, is_default = false) => ({ id, name: `v${id}`, is_default });
|
|
|
|
it("returns the starred default when the module is a fresh start", () => {
|
|
expect(pickDefaultToSeed([dv(1), dv(2, true)], true)?.id).toBe(2);
|
|
});
|
|
|
|
it("returns null when the module already has stored filters / a URL override (canSeed=false)", () => {
|
|
expect(pickDefaultToSeed([dv(1), dv(2, true)], false)).toBeNull();
|
|
});
|
|
|
|
it("returns null when there is no starred default, even on a fresh start", () => {
|
|
expect(pickDefaultToSeed([dv(1), dv(2)], true)).toBeNull();
|
|
expect(pickDefaultToSeed([], true)).toBeNull();
|
|
});
|
|
|
|
it("picks the first default deterministically if several are somehow flagged", () => {
|
|
expect(pickDefaultToSeed([dv(1, true), dv(2, true)], true)?.id).toBe(1);
|
|
});
|
|
});
|