peter
04ecd8b3a7
ESLint 9 flat config, pinned. Narrow by design: the load-bearing rule is react-hooks (rules-of-hooks + exhaustive-deps) — 33 disable comments existed for a rule nothing ran. tsc already owns unused vars / undefined / types, so those are turned off here to report each finding once. no-explicit-any is off: all 19 live in the api.ts god-module that R7 rewrites, and it flips the rule back on then. reportUnusedDisableDirectives is an error, which immediately caught two inert `eslint-disable` comments (App.tsx, AddToPlaylist.tsx) whose effects have stable deps — removed. no-unused-expressions allows the side-effect ternary idiom the codebase already uses (`v.paused ? v.play() : v.pause()`). Errors: 0. Remaining 38 are warnings (28 react-refresh DX, 10 exhaustive-deps) — pre-existing, visible in the lint output, tracked to their epics.
54 lines
2.6 KiB
JavaScript
54 lines
2.6 KiB
JavaScript
import js from "@eslint/js";
|
|
import tseslint from "typescript-eslint";
|
|
import reactHooks from "eslint-plugin-react-hooks";
|
|
import reactRefresh from "eslint-plugin-react-refresh";
|
|
import prettier from "eslint-config-prettier";
|
|
import globals from "globals";
|
|
|
|
// Flat config (ESLint 9). Deliberately NARROW: the high-value rule here is
|
|
// react-hooks/exhaustive-deps — 33 suppressions across the app exist for it, and until this
|
|
// sprint nothing ran to make them mean anything. tsc already owns unused vars, undefined names
|
|
// and types (noUnusedLocals/Parameters + strict), so typescript-eslint's non-type-checked
|
|
// `recommended` is layered on but its overlap with tsc is turned off below to avoid double-reporting
|
|
// and a churny diff. `eslint-config-prettier` is LAST so formatting rules never fight Prettier.
|
|
//
|
|
// reportUnusedDisableDirectives: a `// eslint-disable` that no longer suppresses anything is itself
|
|
// an error — that is what keeps inert disable comments from re-accumulating (the S1b mandate).
|
|
export default tseslint.config(
|
|
{ ignores: ["dist", "node_modules", "playwright-report", "test-results", "e2e/.auth"] },
|
|
{
|
|
files: ["src/**/*.{ts,tsx}"],
|
|
extends: [js.configs.recommended, ...tseslint.configs.recommended],
|
|
languageOptions: {
|
|
ecmaVersion: 2022,
|
|
globals: { ...globals.browser },
|
|
},
|
|
plugins: {
|
|
"react-hooks": reactHooks,
|
|
"react-refresh": reactRefresh,
|
|
},
|
|
linterOptions: {
|
|
reportUnusedDisableDirectives: "error",
|
|
},
|
|
rules: {
|
|
...reactHooks.configs.recommended.rules,
|
|
"react-refresh/only-export-components": ["warn", { allowConstantExport: true }],
|
|
// tsc already enforces these under strict + noUnusedLocals/Parameters — let it own them so a
|
|
// finding is reported once, by one tool, and this config stays about hooks + refresh safety.
|
|
"@typescript-eslint/no-unused-vars": "off",
|
|
"no-undef": "off",
|
|
// The 19 `any`s all live in the api.ts god-module, which R7 (Frontend API layer) rewrites.
|
|
// Turning the rule on now would either block the gate on pre-existing debt or scatter 19
|
|
// suppressions — R7 flips this back to "error" when it types that layer. Tracked, not ignored.
|
|
"@typescript-eslint/no-explicit-any": "off",
|
|
// Side-effect ternaries/short-circuits are an established idiom here (`cond ? a() : b()`,
|
|
// `v.paused ? v.play() : v.pause()`) — allow them rather than rewrite working code to if/else.
|
|
"@typescript-eslint/no-unused-expressions": [
|
|
"error",
|
|
{ allowShortCircuit: true, allowTernary: true },
|
|
],
|
|
},
|
|
},
|
|
prettier,
|
|
);
|