peter
a210992bfc
The browser now keeps its half of the one event shape logs.py defines: lib/log.ts is a levelled, redacted, bounded (2000 events) in-memory ring with the server's level names and severity numbers. Nothing leaves the browser yet; sending is the consented diagnostics level (S5). - lib/http.ts `send` is the one fetch: every request carries an X-Request-Id and becomes one http.request event. The server echoes the matched route template in X-Route (only for a matched route, so a raw path with a value in it is never sent back); without one the client templates the path itself. req, beacon, the upload XHR, the public watch page and the legal pages all go through it. - Hooks: app start snapshot, uncaught errors and rejections, History push/replace/popstate (a scroll-only replace is not an event; parameter values only at DEBUG, typed search only at TRACE), notifications, the error dialog, the crash boundary, failed queries and mutations (key head only), and the messages socket (lifecycle, frame types at DEBUG). - Redaction is one contract: backend/tests/fixtures/log_redaction_cases.json runs against both redact() implementations. - Lint: fetch, XMLHttpRequest and WebSocket each belong to one logging module, console to none; a contract test proves the rules fire. Fixes a socket takeover: the close of a socket released by the last subscriber cleared the newer socket a quick re-subscribe had opened and scheduled a third, leaving two live sockets that delivered every message twice (measured in Chromium: 3 created / 2 live before, 2 / 1 after).
83 lines
3.1 KiB
TypeScript
83 lines
3.1 KiB
TypeScript
// @vitest-environment jsdom
|
|
//
|
|
// E22 S4: what the user was SHOWN — a toast, the blocking error dialog, the crash screen — and what
|
|
// failed behind the scenes (a query, a mutation) all land in the client log. Each producer is its
|
|
// own module, so each is asserted here through the real thing, not a mock of it.
|
|
import { afterEach, describe, expect, it, vi } from "vitest";
|
|
import { cleanup, render } from "@testing-library/react";
|
|
|
|
import { clear, events } from "../lib/log";
|
|
import { notify } from "../lib/notifications";
|
|
import { reportError } from "../lib/errorDialog";
|
|
import { createQueryClient } from "../lib/queryClient";
|
|
import ErrorBoundary from "./ErrorBoundary";
|
|
import { HttpError } from "../lib/api/core";
|
|
|
|
afterEach(() => {
|
|
cleanup();
|
|
clear();
|
|
vi.restoreAllMocks();
|
|
});
|
|
|
|
const logged = (code: string) => events().filter((e) => e.event === code);
|
|
|
|
describe("client log wiring", () => {
|
|
it("records every notification at its level", () => {
|
|
notify({ level: "success", title: "Saved", message: "Playlist renamed" });
|
|
notify({ level: "error", message: "Could not reach someone@mail.example" });
|
|
expect(logged("ui.notify").map((e) => [e.level, e.msg, e.attrs])).toEqual([
|
|
["INFO", "Playlist renamed", { level: "success", title: "Saved" }],
|
|
["ERROR", "Could not reach [email]", { level: "error" }],
|
|
]);
|
|
});
|
|
|
|
it("records the blocking error dialog", () => {
|
|
reportError("The server refused", "Couldn't save");
|
|
expect(logged("ui.error_dialog")).toMatchObject([
|
|
{ level: "ERROR", msg: "The server refused", attrs: { title: "Couldn't save" } },
|
|
]);
|
|
});
|
|
|
|
it("records a failed query by its resource only — the rest of the key is filter state", async () => {
|
|
const client = createQueryClient();
|
|
await client
|
|
.fetchQuery({
|
|
queryKey: ["videos", { tags: ["private-tag"] }],
|
|
queryFn: () => Promise.reject(new HttpError(503, "down")),
|
|
})
|
|
.catch(() => {});
|
|
expect(logged("query.failed")).toMatchObject([
|
|
{ level: "WARNING", attrs: { key: "videos", status: 503, message: "down" } },
|
|
]);
|
|
expect(JSON.stringify(events())).not.toContain("private-tag");
|
|
});
|
|
|
|
it("records a failed mutation", async () => {
|
|
const client = createQueryClient();
|
|
const mutation = client.getMutationCache().build(client, {
|
|
mutationKey: ["playlists", 42],
|
|
mutationFn: () => Promise.reject(new HttpError(409, "conflict")),
|
|
meta: { errorShownInline: true },
|
|
});
|
|
await mutation.execute(undefined).catch(() => {});
|
|
expect(logged("mutation.failed")).toMatchObject([
|
|
{ level: "WARNING", attrs: { key: "playlists", status: 409 } },
|
|
]);
|
|
});
|
|
|
|
it("records a render crash with its component stack", () => {
|
|
vi.spyOn(console, "error").mockImplementation(() => {}); // React reports the crash itself too
|
|
const Boom = () => {
|
|
throw new Error("render exploded");
|
|
};
|
|
render(
|
|
<ErrorBoundary>
|
|
<Boom />
|
|
</ErrorBoundary>,
|
|
);
|
|
const [crash] = logged("ui.crash");
|
|
expect(crash).toMatchObject({ level: "CRITICAL", attrs: { message: "render exploded" } });
|
|
expect(String(crash!.attrs!.component_stack)).toContain("Boom");
|
|
});
|
|
});
|