peter
4aaaaa7860
The code cited its plan instead of saying why: `E28 review J4`, `(R6 S3b)`, `S1 justified…`,
`deep-review round 5`. That plan lives in the private ops repo, so for every reader of this one the
citation was noise, and a sentence whose subject was the plan step ("round 2 showed…") hid its
lesson behind an id. Each one is gone and the "why" kept: a bare citation is deleted, a sentence
carrying a lesson is reworded around it ("a later attempt showed…").
Measured (`scripts/audit_metrics.py`, product code): 652 lines in 270 files carried an epic code by
the definition the next commit holds (507 / 241 by the old, two-digit-only one) -> 0. Across all
code, tests, scripts and configs: ~1100 epic-code lines plus ~320 sprint/round ids.
Behaviour unchanged, checked mechanically: every changed .py file has the same AST once docstrings
are blanked; css/sh/toml/yml/json files are identical once comments are stripped; the only
non-comment changes in TS/JS are test titles, one description string in a contract table, and five
ESLint messages, whose text is all the gates snapshot diff holds. Not touched: Markdown (docs and
the changelog keep their history), Alembic migrations, TV episode notation (`S2 · E5`), DESIGN.md
ids (`C1`, `B4`, `S3h`), tracker ids (`SEC-16`, `DX-17`).
One stale claim fixed on the way: test_hls_reaper's docstring said the player checkpoints "every
10 s whether or not it is playing", which plex/stream.py calls wrong; it now says what the code does.
40 lines
1.7 KiB
TypeScript
40 lines
1.7 KiB
TypeScript
/** Where removed rows go back when their Undo comes LATER than the removal.
|
|
*
|
|
* A raw index recorded at removal time drifts: an add or a reorder landing in between (another tab,
|
|
* the rail, the player) shifts everything after it, and the row came back one or more places off.
|
|
* So each removed row goes back right after the row that preceded it in the list
|
|
* it was removed from — its neighbour, looked up in the list as it stands NOW — or at the start when
|
|
* it was first or no earlier neighbour is left. Rows already back in the list are skipped (the
|
|
* server's add is idempotent and would leave them where they are).
|
|
*
|
|
* @param before the list's ids when the rows were removed, in stored order
|
|
* @param removed the ids taken out
|
|
* @param now the list's ids at Undo time, in stored order
|
|
* @returns the ids to add back and, paired one to one, the index each lands at — ascending, the
|
|
* shape the server's insert takes (each index counts the rows put back before it). */
|
|
export function reinsertAt(
|
|
before: readonly string[],
|
|
removed: readonly string[],
|
|
now: readonly string[],
|
|
): { keys: string[]; positions: number[] } {
|
|
const out = new Set(removed);
|
|
const list = [...now];
|
|
const placed: string[] = [];
|
|
for (let i = 0; i < before.length; i++) {
|
|
const id = before[i]!;
|
|
if (!out.has(id) || now.includes(id)) continue;
|
|
let at = 0;
|
|
for (let j = i - 1; j >= 0; j--) {
|
|
const k = list.indexOf(before[j]!);
|
|
if (k >= 0) {
|
|
at = k + 1;
|
|
break;
|
|
}
|
|
}
|
|
list.splice(at, 0, id);
|
|
placed.push(id);
|
|
}
|
|
const keys = placed.map((id) => ({ id, at: list.indexOf(id) })).sort((a, b) => a.at - b.at);
|
|
return { keys: keys.map((k) => k.id), positions: keys.map((k) => k.at) };
|
|
}
|