peter
4aaaaa7860
The code cited its plan instead of saying why: `E28 review J4`, `(R6 S3b)`, `S1 justified…`,
`deep-review round 5`. That plan lives in the private ops repo, so for every reader of this one the
citation was noise, and a sentence whose subject was the plan step ("round 2 showed…") hid its
lesson behind an id. Each one is gone and the "why" kept: a bare citation is deleted, a sentence
carrying a lesson is reworded around it ("a later attempt showed…").
Measured (`scripts/audit_metrics.py`, product code): 652 lines in 270 files carried an epic code by
the definition the next commit holds (507 / 241 by the old, two-digit-only one) -> 0. Across all
code, tests, scripts and configs: ~1100 epic-code lines plus ~320 sprint/round ids.
Behaviour unchanged, checked mechanically: every changed .py file has the same AST once docstrings
are blanked; css/sh/toml/yml/json files are identical once comments are stripped; the only
non-comment changes in TS/JS are test titles, one description string in a contract table, and five
ESLint messages, whose text is all the gates snapshot diff holds. Not touched: Markdown (docs and
the changelog keep their history), Alembic migrations, TV episode notation (`S2 · E5`), DESIGN.md
ids (`C1`, `B4`, `S3h`), tracker ids (`SEC-16`, `DX-17`).
One stale claim fixed on the way: test_hls_reaper's docstring said the player checkpoints "every
10 s whether or not it is playing", which plex/stream.py calls wrong; it now says what the code does.
58 lines
2.1 KiB
TypeScript
58 lines
2.1 KiB
TypeScript
import { readdirSync, readFileSync } from "node:fs";
|
|
import { fileURLToPath } from "node:url";
|
|
import js from "@eslint/js";
|
|
import { ESLint } from "eslint";
|
|
import globals from "globals";
|
|
import prettier from "prettier";
|
|
import { describe, expect, it } from "vitest";
|
|
|
|
// The repo-root `scripts/*.mjs` (the lock check `siftlode check` runs, the CHANGELOG generator its
|
|
// release runs) sit outside every lint lane: the eslint and prettier lanes run from frontend/, and an
|
|
// ESLint config cannot reach past its own directory. This holds them to the same bar as
|
|
// the frontend's plain-JS config files — `js.configs.recommended` under Node, and the frontend's
|
|
// Prettier style. Not the typed rules: they are not in a tsc project (docs/gates.md).
|
|
|
|
const REPO = fileURLToPath(new URL("../../../", import.meta.url));
|
|
const FRONTEND = `${REPO}frontend/`;
|
|
const SCRIPTS = readdirSync(`${REPO}scripts`)
|
|
.filter((f) => f.endsWith(".mjs"))
|
|
.map((f) => `scripts/${f}`);
|
|
|
|
describe("repo-root scripts", () => {
|
|
it("are found", () => {
|
|
expect(SCRIPTS).toContain("scripts/check-node-modules.mjs");
|
|
});
|
|
|
|
it("pass the plain-JS lint", async () => {
|
|
const eslint = new ESLint({
|
|
cwd: REPO,
|
|
overrideConfigFile: true,
|
|
overrideConfig: [
|
|
{
|
|
files: ["scripts/*.mjs"],
|
|
...js.configs.recommended,
|
|
languageOptions: { globals: globals.node },
|
|
linterOptions: { reportUnusedDisableDirectives: "error" },
|
|
},
|
|
],
|
|
});
|
|
const hits = (await eslint.lintFiles(SCRIPTS)).flatMap((r) =>
|
|
r.messages.map((m) => `${r.filePath}:${m.line} ${m.ruleId ?? "parse"}: ${m.message}`),
|
|
);
|
|
expect(hits).toEqual([]);
|
|
});
|
|
|
|
it("are formatted in the frontend's Prettier style", async () => {
|
|
const options = await prettier.resolveConfig(`${FRONTEND}eslint.config.js`);
|
|
const unformatted: string[] = [];
|
|
for (const f of SCRIPTS) {
|
|
const ok = await prettier.check(readFileSync(REPO + f, "utf8"), {
|
|
...options,
|
|
filepath: REPO + f,
|
|
});
|
|
if (!ok) unformatted.push(f);
|
|
}
|
|
expect(unformatted).toEqual([]);
|
|
});
|
|
});
|