peter
4aaaaa7860
The code cited its plan instead of saying why: `E28 review J4`, `(R6 S3b)`, `S1 justified…`,
`deep-review round 5`. That plan lives in the private ops repo, so for every reader of this one the
citation was noise, and a sentence whose subject was the plan step ("round 2 showed…") hid its
lesson behind an id. Each one is gone and the "why" kept: a bare citation is deleted, a sentence
carrying a lesson is reworded around it ("a later attempt showed…").
Measured (`scripts/audit_metrics.py`, product code): 652 lines in 270 files carried an epic code by
the definition the next commit holds (507 / 241 by the old, two-digit-only one) -> 0. Across all
code, tests, scripts and configs: ~1100 epic-code lines plus ~320 sprint/round ids.
Behaviour unchanged, checked mechanically: every changed .py file has the same AST once docstrings
are blanked; css/sh/toml/yml/json files are identical once comments are stripped; the only
non-comment changes in TS/JS are test titles, one description string in a contract table, and five
ESLint messages, whose text is all the gates snapshot diff holds. Not touched: Markdown (docs and
the changelog keep their history), Alembic migrations, TV episode notation (`S2 · E5`), DESIGN.md
ids (`C1`, `B4`, `S3h`), tracker ids (`SEC-16`, `DX-17`).
One stale claim fixed on the way: test_hls_reaper's docstring said the player checkpoints "every
10 s whether or not it is playing", which plex/stream.py calls wrong; it now says what the code does.
41 lines
1.7 KiB
TypeScript
41 lines
1.7 KiB
TypeScript
import { readdirSync, readFileSync } from "node:fs";
|
|
|
|
import { describe, expect, it } from "vitest";
|
|
|
|
// The keyboard row of a listbox has one look, ui/AnchoredPopover's `ROVING_HIGHLIGHT`
|
|
// (a menu row, a combobox option, the command palette, the Plex typeahead). A listbox that paints its
|
|
// own drifted: the palette's `bg-card` row was ~1.07:1 on its glass, and the Plex typeahead carried a
|
|
// hand copy of the recipe that would not follow a change to it.
|
|
function sources(): Array<[string, string]> {
|
|
const walk = (u: URL, prefix: string): Array<[string, string]> =>
|
|
readdirSync(u, { withFileTypes: true }).flatMap((e) => {
|
|
if (e.isDirectory()) return walk(new URL(`${e.name}/`, u), `${prefix}${e.name}/`);
|
|
if (!/\.tsx?$/.test(e.name) || e.name.includes(".test.")) return [];
|
|
return [
|
|
[`${prefix}${e.name}`, readFileSync(new URL(e.name, u), "utf-8")] as [string, string],
|
|
];
|
|
});
|
|
return walk(new URL("../", import.meta.url), "");
|
|
}
|
|
|
|
describe("the roving highlight", () => {
|
|
it("is painted only by the recipe in ui/AnchoredPopover", () => {
|
|
const copies = sources()
|
|
.filter(
|
|
([name]) => name !== "components/ui/AnchoredPopover.tsx" && !name.startsWith("design-lab/"),
|
|
)
|
|
.filter(([, src]) => /(^|[\s"`'])bg-accent\/35(?![\w/-])/.test(src))
|
|
.map(([name]) => name);
|
|
expect(copies).toEqual([]);
|
|
});
|
|
|
|
it("is what every hand-built option row takes", () => {
|
|
const own = sources()
|
|
.filter(([, src]) => src.includes('role="option"'))
|
|
// A PopoverItem row takes the recipe itself (the Combobox's options).
|
|
.filter(([, src]) => !src.includes("ROVING_HIGHLIGHT") && !src.includes("<PopoverItem"))
|
|
.map(([name]) => name);
|
|
expect(own).toEqual([]);
|
|
});
|
|
});
|