peter
4aaaaa7860
The code cited its plan instead of saying why: `E28 review J4`, `(R6 S3b)`, `S1 justified…`,
`deep-review round 5`. That plan lives in the private ops repo, so for every reader of this one the
citation was noise, and a sentence whose subject was the plan step ("round 2 showed…") hid its
lesson behind an id. Each one is gone and the "why" kept: a bare citation is deleted, a sentence
carrying a lesson is reworded around it ("a later attempt showed…").
Measured (`scripts/audit_metrics.py`, product code): 652 lines in 270 files carried an epic code by
the definition the next commit holds (507 / 241 by the old, two-digit-only one) -> 0. Across all
code, tests, scripts and configs: ~1100 epic-code lines plus ~320 sprint/round ids.
Behaviour unchanged, checked mechanically: every changed .py file has the same AST once docstrings
are blanked; css/sh/toml/yml/json files are identical once comments are stripped; the only
non-comment changes in TS/JS are test titles, one description string in a contract table, and five
ESLint messages, whose text is all the gates snapshot diff holds. Not touched: Markdown (docs and
the changelog keep their history), Alembic migrations, TV episode notation (`S2 · E5`), DESIGN.md
ids (`C1`, `B4`, `S3h`), tracker ids (`SEC-16`, `DX-17`).
One stale claim fixed on the way: test_hls_reaper's docstring said the player checkpoints "every
10 s whether or not it is playing", which plex/stream.py calls wrong; it now says what the code does.
52 lines
1.9 KiB
TypeScript
52 lines
1.9 KiB
TypeScript
// @vitest-environment jsdom
|
|
//
|
|
// A store is read from React through `useValue()`, a name the React Compiler knows as a hook. Its
|
|
// old name, `use()`, it did not: the call was compiled as an ordinary one and memoized, so it ran
|
|
// on the first render alone. Read straight from a component, Back to top never re-rendered;
|
|
// read inside a hook that compiles memo scopes around it, usePlaylistActions rendered fewer hooks
|
|
// on its second render and threw (the moment that hook started to compile). Vitest builds
|
|
// with the same compiler as the app (reactPlugin), so this renders the compiled code.
|
|
import { describe, it, expect, afterEach } from "vitest";
|
|
import { render, screen, act, cleanup } from "@testing-library/react";
|
|
import { useState } from "react";
|
|
import { createStore } from "./store";
|
|
|
|
afterEach(cleanup);
|
|
|
|
const count = createStore(0);
|
|
|
|
// A hook shaped like usePlaylistActions: other hooks around the read, and a callback built from it.
|
|
function useCountLabel(prefix: string) {
|
|
const [step] = useState(1);
|
|
const value = count.useValue();
|
|
const next = () => count.set(value + step);
|
|
return { label: `${prefix}${value}`, next };
|
|
}
|
|
|
|
function Counter() {
|
|
const { label, next } = useCountLabel("n=");
|
|
return <button onClick={next}>{label}</button>;
|
|
}
|
|
|
|
function Bare() {
|
|
return <span>{`bare=${count.useValue()}`}</span>;
|
|
}
|
|
|
|
describe("a store read from React", () => {
|
|
it("re-renders a compiled hook and a compiled component on every change", () => {
|
|
act(() => count.set(0));
|
|
render(
|
|
<>
|
|
<Counter />
|
|
<Bare />
|
|
</>,
|
|
);
|
|
act(() => count.set(1));
|
|
expect(screen.getByRole("button").textContent).toBe("n=1");
|
|
expect(screen.getByText("bare=1")).toBeTruthy();
|
|
act(() => screen.getByRole("button").click());
|
|
expect(screen.getByRole("button").textContent).toBe("n=2");
|
|
expect(screen.getByText("bare=2")).toBeTruthy();
|
|
});
|
|
});
|