peter
4aaaaa7860
The code cited its plan instead of saying why: `E28 review J4`, `(R6 S3b)`, `S1 justified…`,
`deep-review round 5`. That plan lives in the private ops repo, so for every reader of this one the
citation was noise, and a sentence whose subject was the plan step ("round 2 showed…") hid its
lesson behind an id. Each one is gone and the "why" kept: a bare citation is deleted, a sentence
carrying a lesson is reworded around it ("a later attempt showed…").
Measured (`scripts/audit_metrics.py`, product code): 652 lines in 270 files carried an epic code by
the definition the next commit holds (507 / 241 by the old, two-digit-only one) -> 0. Across all
code, tests, scripts and configs: ~1100 epic-code lines plus ~320 sprint/round ids.
Behaviour unchanged, checked mechanically: every changed .py file has the same AST once docstrings
are blanked; css/sh/toml/yml/json files are identical once comments are stripped; the only
non-comment changes in TS/JS are test titles, one description string in a contract table, and five
ESLint messages, whose text is all the gates snapshot diff holds. Not touched: Markdown (docs and
the changelog keep their history), Alembic migrations, TV episode notation (`S2 · E5`), DESIGN.md
ids (`C1`, `B4`, `S3h`), tracker ids (`SEC-16`, `DX-17`).
One stale claim fixed on the way: test_hls_reaper's docstring said the player checkpoints "every
10 s whether or not it is playing", which plex/stream.py calls wrong; it now says what the code does.
63 lines
1.9 KiB
TypeScript
63 lines
1.9 KiB
TypeScript
// @vitest-environment jsdom
|
|
//
|
|
// readSelectedId: the Playlists selected-id seed. Backfills a code review's deferred ?pl guard
|
|
// coverage — a ?pl bookmark wins over the stored selection but only when it's a positive integer;
|
|
// anything else (empty / zero / negative / fractional / non-numeric) falls back to the stored id.
|
|
import { describe, it, expect, beforeEach, vi } from "vitest";
|
|
|
|
const { stored } = vi.hoisted(() => ({ stored: { v: null as string | null } }));
|
|
vi.mock("../lib/storage", async (importOriginal) => {
|
|
const actual = await importOriginal<typeof import("../lib/storage")>();
|
|
return { ...actual, getAccountRaw: () => stored.v };
|
|
});
|
|
|
|
import { readSelectedId } from "./playlistsInit";
|
|
|
|
const setUrl = (search: string) => window.history.replaceState(null, "", search || "/");
|
|
|
|
beforeEach(() => {
|
|
setUrl("/");
|
|
stored.v = null;
|
|
});
|
|
|
|
describe("readSelectedId ?pl guard", () => {
|
|
it("accepts a positive-integer ?pl", () => {
|
|
setUrl("?pl=5");
|
|
expect(readSelectedId()).toBe(5);
|
|
});
|
|
|
|
it("a ?pl bookmark wins over the stored selection", () => {
|
|
setUrl("?pl=5");
|
|
stored.v = "7";
|
|
expect(readSelectedId()).toBe(5);
|
|
});
|
|
|
|
it.each(["", "0", "-2", "1.5", "abc"])("rejects ?pl=%s and falls back to stored", (raw) => {
|
|
setUrl(`?pl=${raw}`);
|
|
stored.v = "7";
|
|
expect(readSelectedId()).toBe(7);
|
|
});
|
|
|
|
it("rejects a bad ?pl and returns null when there is no stored selection", () => {
|
|
setUrl("?pl=0");
|
|
expect(readSelectedId()).toBeNull();
|
|
});
|
|
|
|
it("uses the stored selection when there is no ?pl", () => {
|
|
stored.v = "9";
|
|
expect(readSelectedId()).toBe(9);
|
|
});
|
|
|
|
it.each(["", "0", "-2", "1.5", "abc"])(
|
|
"rejects a non-positive-integer STORED value %s (guarded like the URL)",
|
|
(raw) => {
|
|
stored.v = raw;
|
|
expect(readSelectedId()).toBeNull();
|
|
},
|
|
);
|
|
|
|
it("returns null when neither ?pl nor a stored selection is present", () => {
|
|
expect(readSelectedId()).toBeNull();
|
|
});
|
|
});
|