peter
8fb276aa90
A feed card cost ~10 Tab stops, so the tenth card sat ~135 Tabs from the top of the page, and the only keyboard focus ring (a 60% accent outline on the thumbnail) all but vanished on the dark glass. First slice of the E11 keyboard layer (S4a); Home, Plex and the tables follow in S4b/S4c. - `lib/listNav`: one window listener over every registered list, walked in document order. `j`/`k` step item to item (on into the next list — owner decision D4), the arrows move around a grid, Enter clicks the item's own `data-nav-open` element, so it opens exactly like a click. An item root is never a Tab stop: it gets `tabindex=-1` only while the keyboard is on it, and keeps it until the next item takes it, so the player's focus restore lands back on the card. The first `j` takes the first card you can see, not the top of the list. - `VirtualGrid` takes part with `keyboardNav` (column count + scrolling an unmounted row in); `VirtualFeed` turns it on, so the feed, the library and the channel page all have it. - Keymap: two-step sequences (`g h`) whose pending step belongs to the scope that started it; the page-level scopes (`page`, `search`, `list`) are quiet while a layer that owns the keyboard is open, enforced in `dispatch`. A test pins the owner's rule that none of them needs a modifier on the Hungarian layout. - `g h/f/c/p/x/n/m/d/s/,` jump to a module this account can reach; `s` focuses the header search box and selects the old query; Escape in it hands the keyboard back to the page (Plex's typeahead spends its first Escape on its panel). - Hover popovers are passive layers: an open tooltip still takes Escape first but no longer silences the page keys. - Focus ring (owner decision D2 = B): solid 2px accent around the whole item; the app-wide button/ link/row ring goes from 60% to solid too. The item keeps a transparent resting outline because the video card transitions `all` — without it every `j` flashed a 3px white ring (measured in Chrome). - Help sheet: the new keys, in a fixed order after the surface's own; a `g` chord only for a reachable module; opened over a player or dialog it leaves out the page-level keys and the context-menu key, which nothing can reach there (the latter pre-existing since E10). - CLAUDE.md: a canonical-patterns row for list/grid keys (`useListNav` + `navItemAttrs` + `data-nav-open`, not a private arrow-key handler).
67 lines
2.5 KiB
TypeScript
67 lines
2.5 KiB
TypeScript
// @vitest-environment jsdom
|
|
//
|
|
// E11 S4: a hover surface (tooltip, hover card) is a PASSIVE layer. It still sits on the layer stack —
|
|
// Escape closes it before the surface beneath — but it does not own the keyboard, so the page-level
|
|
// keys (`j`/`k`, `s`, the `g` chords) keep working while one happens to be open under a resting pointer.
|
|
// Without the flag, hovering any hinted icon silently disabled keyboard navigation.
|
|
//
|
|
// jsdom lays nothing out, and floating-ui's `hide` middleware then reports the reference as scrolled
|
|
// out of view — and an invisible surface is deliberately NOT a layer (AnchoredPopover). A test on that
|
|
// would pass without the flag, so the reference and the viewport get real boxes first, and the test
|
|
// proves the surface is a layer (Escape closes it) before trusting the "not blocking" half.
|
|
import { afterAll, afterEach, beforeAll, describe, expect, it, vi } from "vitest";
|
|
import { act, cleanup, fireEvent, render, screen, waitFor } from "@testing-library/react";
|
|
import Tooltip from "./Tooltip";
|
|
import { anyBlockingLayer } from "../../lib/layerStack";
|
|
|
|
const box = { x: 200, y: 200, top: 200, left: 200, width: 60, height: 24, right: 260, bottom: 224 };
|
|
|
|
beforeAll(() => {
|
|
class Stub {
|
|
observe() {}
|
|
unobserve() {}
|
|
disconnect() {}
|
|
takeRecords() {
|
|
return [];
|
|
}
|
|
}
|
|
globalThis.ResizeObserver ??= Stub as unknown as typeof ResizeObserver;
|
|
vi.spyOn(Element.prototype, "getBoundingClientRect").mockReturnValue({
|
|
...box,
|
|
toJSON: () => box,
|
|
} as DOMRect);
|
|
for (const [prop, value] of [
|
|
["clientWidth", 1280],
|
|
["clientHeight", 800],
|
|
] as const) {
|
|
Object.defineProperty(document.documentElement, prop, { configurable: true, value });
|
|
}
|
|
});
|
|
afterAll(() => vi.restoreAllMocks());
|
|
afterEach(cleanup);
|
|
|
|
describe("an open tooltip", () => {
|
|
it("is a layer Escape reaches, but does not block the page keys", async () => {
|
|
render(
|
|
<Tooltip hint="A hint" always>
|
|
<button>icon</button>
|
|
</Tooltip>,
|
|
);
|
|
const trigger = screen.getByText("icon").parentElement as HTMLElement;
|
|
act(() => {
|
|
fireEvent.pointerEnter(trigger);
|
|
fireEvent.mouseEnter(trigger);
|
|
fireEvent.mouseMove(trigger);
|
|
});
|
|
const surface = await screen.findByRole("tooltip");
|
|
await waitFor(() => expect(surface.style.visibility).not.toBe("hidden"));
|
|
|
|
expect(anyBlockingLayer()).toBe(false);
|
|
|
|
act(() => {
|
|
fireEvent.keyDown(document, { key: "Escape" });
|
|
});
|
|
await waitFor(() => expect(screen.queryByRole("tooltip")).toBeNull());
|
|
});
|
|
});
|