siftlode/frontend/src/components/PlexPersonView.dom.test.tsx

// @vitest-environment jsdom
//
// E5 S4: the actor detail page. Covers the two pieces the /code-review flagged as untested — the
// cast-row rewiring (a cast click now OPENS the person page via onOpenPerson, falling back to the old
// filter gesture only when no onOpenPerson is wired) and PlexPersonView's render (headshot/name hero,
// the Movies/Shows sections, and the "filter library by this person" action). i18n is key-passthrough
// and the api is mocked so the query resolves synchronously in the test.
import { describe, it, expect, afterEach, beforeAll, vi } from "vitest";
import { render, screen, fireEvent, cleanup } from "@testing-library/react";
import { QueryClient, QueryClientProvider } from "@tanstack/react-query";

beforeAll(() => {
  // CastStrip now scrolls inside a Carousel, whose useHScroll wires a ResizeObserver; jsdom ships none.
  class Stub {
    observe() {}
    unobserve() {}
    disconnect() {}
    takeRecords() {
      return [];
    }
  }
  globalThis.ResizeObserver ??= Stub as unknown as typeof ResizeObserver;
});

vi.mock("react-i18next", async (importOriginal) => {
  const actual = await importOriginal<typeof import("react-i18next")>();
  return { ...actual, useTranslation: () => ({ t: (key: string) => key }) };
});

const plexPerson = vi.fn();
const plexSetState = vi.fn((..._a: unknown[]) => Promise.resolve());
vi.mock("../lib/api", () => ({
  api: {
    plexPerson: (...a: unknown[]) => plexPerson(...a),
    plexSetState: (...a: unknown[]) => plexSetState(...a),
  },
  EMPTY_PLEX_FILTERS: {},
  plexFilterCount: () => 0,
}));

import { CastStrip } from "./plexCards";
import { PlexPersonView } from "./plexViews";

afterEach(cleanup);

const card = (id: string, title: string, type: "movie" | "show" = "movie") => ({
  id,
  type,
  title,
  year: 2000,
  duration_seconds: 3600,
  thumb: `/api/plex/image/${id}`,
  playable: "direct",
  status: "new",
  position_seconds: 0,
});

function wrap(ui: React.ReactElement) {
  const qc = new QueryClient({ defaultOptions: { queries: { retry: false } } });
  return render(<QueryClientProvider client={qc}>{ui}</QueryClientProvider>);
}

describe("CastStrip cast click", () => {
  it("opens the person page (onOpenPerson) rather than filtering, when both are wired", () => {
    const onOpenPerson = vi.fn();
    const onFilter = vi.fn();
    render(
      <CastStrip cast={[{ name: "Jane Doe" }]} onOpenPerson={onOpenPerson} onFilter={onFilter} />,
    );
    fireEvent.click(screen.getByTitle("plex.info.viewPerson"));
    expect(onOpenPerson).toHaveBeenCalledWith("Jane Doe");
    expect(onFilter).not.toHaveBeenCalled();
  });

  it("falls back to the filter gesture when only onFilter is wired (e.g. the overlay)", () => {
    const onFilter = vi.fn();
    render(<CastStrip cast={[{ name: "Jane Doe" }]} onFilter={onFilter} />);
    fireEvent.click(screen.getByTitle("plex.info.filterActor"));
    expect(onFilter).toHaveBeenCalledWith({ actors: ["Jane Doe"] });
  });
});

describe("PlexPersonView", () => {
  it("renders the Movies + Shows sections and the filter-by-person action", async () => {
    plexPerson.mockResolvedValue({
      name: "Jane Doe",
      photo: null,
      biography: "A celebrated actor.",
      birthday: "1970-01-01",
      place_of_birth: "Springfield",
      known_for_department: "Acting",
      also_known_as: ["Janie D"],
      known_for: [card("kf1", "Famous Film")],
      movies: [card("m1", "Movie One")],
      shows: [card("s1", "Show One", "show")],
    });
    const onFilter = vi.fn();
    wrap(
      <PlexPersonView
        name="Jane Doe"
        onBack={() => {}}
        onOpenCard={() => {}}
        onInfoCard={() => {}}
        onFilter={onFilter}
      />,
    );
    // Both section grids render their cards once the mocked query resolves.
    await screen.findByText("Movie One");
    expect(screen.getByText("Show One")).toBeTruthy();
    expect(screen.getByText("plex.person.movies")).toBeTruthy(); // section headings (key passthrough)
    expect(screen.getByText("plex.person.shows")).toBeTruthy();

    // E5 S6 bio hero: department, biography, birth facts, aka.
    expect(screen.getByText("Acting")).toBeTruthy();
    expect(screen.getByText("A celebrated actor.")).toBeTruthy();
    expect(screen.getByText(/1970-01-01/)).toBeTruthy();
    expect(screen.getByText(/plex\.person\.aka/)).toBeTruthy();
    expect(screen.getByText(/Janie D/)).toBeTruthy();
    // "Known for" rail renders its card.
    expect(screen.getByText("plex.person.knownFor")).toBeTruthy();
    expect(screen.getAllByText("Famous Film").length).toBeGreaterThan(0);

    fireEvent.click(screen.getByText("plex.person.filterBy"));
    expect(onFilter).toHaveBeenCalledWith({ actors: ["Jane Doe"] });
    expect(plexPerson).toHaveBeenCalledWith("Jane Doe");
  });

  it("shows the empty message when the person has no titles", async () => {
    plexPerson.mockResolvedValue({
      name: "Nobody",
      photo: null,
      also_known_as: [],
      known_for: [],
      movies: [],
      shows: [],
    });
    wrap(
      <PlexPersonView
        name="Nobody"
        onBack={() => {}}
        onOpenCard={() => {}}
        onInfoCard={() => {}}
        onFilter={() => {}}
      />,
    );
    await screen.findByText("plex.person.empty");
  });
});