peter
4aaaaa7860
The code cited its plan instead of saying why: `E28 review J4`, `(R6 S3b)`, `S1 justified…`,
`deep-review round 5`. That plan lives in the private ops repo, so for every reader of this one the
citation was noise, and a sentence whose subject was the plan step ("round 2 showed…") hid its
lesson behind an id. Each one is gone and the "why" kept: a bare citation is deleted, a sentence
carrying a lesson is reworded around it ("a later attempt showed…").
Measured (`scripts/audit_metrics.py`, product code): 652 lines in 270 files carried an epic code by
the definition the next commit holds (507 / 241 by the old, two-digit-only one) -> 0. Across all
code, tests, scripts and configs: ~1100 epic-code lines plus ~320 sprint/round ids.
Behaviour unchanged, checked mechanically: every changed .py file has the same AST once docstrings
are blanked; css/sh/toml/yml/json files are identical once comments are stripped; the only
non-comment changes in TS/JS are test titles, one description string in a contract table, and five
ESLint messages, whose text is all the gates snapshot diff holds. Not touched: Markdown (docs and
the changelog keep their history), Alembic migrations, TV episode notation (`S2 · E5`), DESIGN.md
ids (`C1`, `B4`, `S3h`), tracker ids (`SEC-16`, `DX-17`).
One stale claim fixed on the way: test_hls_reaper's docstring said the player checkpoints "every
10 s whether or not it is playing", which plex/stream.py calls wrong; it now says what the code does.
80 lines
2.5 KiB
TypeScript
80 lines
2.5 KiB
TypeScript
// The Library/Shared row-action gate. A generic uploaded file (media_kind='file') is
|
|
// download+share only (no Play/Edit/Details); an edit clip and an upload can't be re-downloaded.
|
|
// These pin the gate so a regression that shows Play/Edit on a file, or re-download on an upload,
|
|
// is caught (the affordance itself, not just the backend guard behind it).
|
|
import { describe, it, expect } from "vitest";
|
|
import { libraryRowActions, sharedRowActions } from "./downloadActions";
|
|
import type { DownloadJob } from "./api";
|
|
|
|
const job = (
|
|
over: Partial<DownloadJob>,
|
|
asset: Partial<NonNullable<DownloadJob["asset"]>> | null,
|
|
) =>
|
|
({
|
|
id: 1,
|
|
status: "done",
|
|
job_kind: "download",
|
|
can_download: true,
|
|
asset: asset && {
|
|
id: 1,
|
|
status: "ready",
|
|
title: "x",
|
|
duration_s: 90,
|
|
media_kind: "video",
|
|
container: "mp4",
|
|
...asset,
|
|
},
|
|
...over,
|
|
}) as unknown as DownloadJob;
|
|
|
|
describe("libraryRowActions", () => {
|
|
it("a media (video) item gets play, edit, details, redownload", () => {
|
|
expect(libraryRowActions(job({}, {}))).toEqual({
|
|
play: true,
|
|
edit: true,
|
|
editDetails: true,
|
|
redownload: true,
|
|
});
|
|
});
|
|
|
|
it("a generic file gets NO play/edit/details (download+share only)", () => {
|
|
const a = libraryRowActions(job({}, { media_kind: "file", duration_s: null }));
|
|
expect(a.play).toBe(false);
|
|
expect(a.edit).toBe(false);
|
|
expect(a.editDetails).toBe(false);
|
|
});
|
|
|
|
it("an upload cannot be re-downloaded (no re-fetchable source)", () => {
|
|
expect(libraryRowActions(job({ job_kind: "upload" }, { media_kind: "file" })).redownload).toBe(
|
|
false,
|
|
);
|
|
});
|
|
|
|
it("an edit clip cannot be re-downloaded", () => {
|
|
expect(libraryRowActions(job({ job_kind: "edit" }, {})).redownload).toBe(false);
|
|
});
|
|
|
|
it("edit is hidden when the media has no duration", () => {
|
|
expect(libraryRowActions(job({}, { duration_s: 0 })).edit).toBe(false);
|
|
});
|
|
});
|
|
|
|
describe("sharedRowActions", () => {
|
|
it("a downloadable media item gets play, save, edit", () => {
|
|
expect(sharedRowActions(job({}, {}))).toEqual({ play: true, save: true, edit: true });
|
|
});
|
|
|
|
it("nothing is offered when the owner disabled download", () => {
|
|
expect(sharedRowActions(job({ can_download: false }, {}))).toEqual({
|
|
play: false,
|
|
save: false,
|
|
edit: false,
|
|
});
|
|
});
|
|
|
|
it("a shared generic file gets only save (no player/trim)", () => {
|
|
const a = sharedRowActions(job({}, { media_kind: "file", duration_s: null }));
|
|
expect(a).toEqual({ play: false, save: true, edit: false });
|
|
});
|
|
});
|