peter
471846d784
eslint now also enforces: - the React Compiler diagnostics that `recommended` leaves out (todo, memo-dependencies and ten zero-hit tripwires); - a description on every suppression, and no blanket disables; - no focused or skipped tests (vitest and playwright); - the typed pair no-floating-promises and no-deprecated. Lint also covers e2e/ and the TypeScript build configs, which `eslint .` had been skipping in silence. Every hit is fixed or suppressed inline with a named reason: - The 31 try statements the compiler cannot lower yet carry a suppression until S3 rewrites them. Five other compiler skips were plain fixes: a module counter bumped inside a hook, a ref read in a default parameter, and a local named like the <section> it renders. - The real defects behind floating promises are fixed. ChatDock threw at nobody when the device key store could not be opened. VideoEditor's play() rejection went unhandled. loadYouTubeApi never rejected, so a blocked IFrame API left the player on an empty stage forever; it now fails on a script error or after 15 s, shows its own error with the way out, and lets the next open try again. - MutableRefObject, FormEvent and lucide's deprecated brand icon are replaced. The YouTube glyph now lives in lib/brandIcons. - The lint-probe harness lets its virtual file names into TypeScript's default project, so the contract tests still run the real config.
59 lines
2.1 KiB
TypeScript
59 lines
2.1 KiB
TypeScript
// @vitest-environment jsdom
|
|
//
|
|
// The Settings prefs are seeded from the account's server prefs in the `me` cache — BootGate mounts the
|
|
// tree only once it is there. The adopt effect this replaced corrected them AFTER mounting; with it
|
|
// gone, a seed that read only this browser's copy would never show a performance mode or hints setting
|
|
// changed on another device. And the seed is not an edit: it must not be saved straight back.
|
|
import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
|
|
import { act, cleanup, render } from "@testing-library/react";
|
|
import { QueryClient, QueryClientProvider } from "@tanstack/react-query";
|
|
import { PrefsProvider } from "./PrefsProvider";
|
|
import { usePrefs } from "./prefsContext";
|
|
import { api } from "../lib/api";
|
|
import { ACTIVE_ACCOUNT_KEY } from "../lib/activeAccount";
|
|
import { accountKey, LS } from "../lib/storage";
|
|
import { qk } from "../lib/queryKeys";
|
|
|
|
const seen: { perf: boolean; hints: boolean }[] = [];
|
|
function Probe() {
|
|
const { perf, hints } = usePrefs();
|
|
seen.push({ perf, hints });
|
|
return null;
|
|
}
|
|
|
|
beforeEach(() => {
|
|
localStorage.clear();
|
|
sessionStorage.setItem(ACTIVE_ACCOUNT_KEY, "5");
|
|
seen.length = 0;
|
|
vi.useFakeTimers();
|
|
});
|
|
afterEach(() => {
|
|
cleanup();
|
|
vi.useRealTimers();
|
|
vi.restoreAllMocks();
|
|
});
|
|
|
|
describe("PrefsProvider seed", () => {
|
|
it("renders the account's server prefs from the first render, and does not save them back", () => {
|
|
localStorage.setItem(accountKey(LS.perfMode, 5)!, "0"); // this browser last had it off
|
|
localStorage.setItem(accountKey(LS.hints, 5)!, "1");
|
|
const save = vi.spyOn(api, "savePrefs").mockResolvedValue(undefined as never);
|
|
const qc = new QueryClient();
|
|
qc.setQueryData(qk.me(), { id: 5, preferences: { performanceMode: true, hints: false } });
|
|
render(
|
|
<QueryClientProvider client={qc}>
|
|
<PrefsProvider>
|
|
<Probe />
|
|
</PrefsProvider>
|
|
</QueryClientProvider>,
|
|
);
|
|
|
|
expect(seen[0]).toEqual({ perf: true, hints: false });
|
|
// past the auto-save debounce
|
|
act(() => {
|
|
vi.advanceTimersByTime(1000);
|
|
});
|
|
expect(save).not.toHaveBeenCalled();
|
|
});
|
|
});
|