peter
4aaaaa7860
The code cited its plan instead of saying why: `E28 review J4`, `(R6 S3b)`, `S1 justified…`,
`deep-review round 5`. That plan lives in the private ops repo, so for every reader of this one the
citation was noise, and a sentence whose subject was the plan step ("round 2 showed…") hid its
lesson behind an id. Each one is gone and the "why" kept: a bare citation is deleted, a sentence
carrying a lesson is reworded around it ("a later attempt showed…").
Measured (`scripts/audit_metrics.py`, product code): 652 lines in 270 files carried an epic code by
the definition the next commit holds (507 / 241 by the old, two-digit-only one) -> 0. Across all
code, tests, scripts and configs: ~1100 epic-code lines plus ~320 sprint/round ids.
Behaviour unchanged, checked mechanically: every changed .py file has the same AST once docstrings
are blanked; css/sh/toml/yml/json files are identical once comments are stripped; the only
non-comment changes in TS/JS are test titles, one description string in a contract table, and five
ESLint messages, whose text is all the gates snapshot diff holds. Not touched: Markdown (docs and
the changelog keep their history), Alembic migrations, TV episode notation (`S2 · E5`), DESIGN.md
ids (`C1`, `B4`, `S3h`), tracker ids (`SEC-16`, `DX-17`).
One stale claim fixed on the way: test_hls_reaper's docstring said the player checkpoints "every
10 s whether or not it is playing", which plex/stream.py calls wrong; it now says what the code does.
49 lines
1.9 KiB
TypeScript
49 lines
1.9 KiB
TypeScript
import type { AuditRow } from "./api";
|
|
|
|
// The audit log's scheduler noise, folded (the owner's pick): the background jobs write a row per
|
|
// run that changed something, so an hour of "enrichment done" filled the first screen and pushed the
|
|
// admins' own actions down. A job's SUCCESSFUL runs become one row that names how many there were and
|
|
// opens to each — whatever ran between them (another job, an admin's action): the owner read a fold
|
|
// that broke at every other job as the same row five times. Only that job's own failed or skipped run
|
|
// breaks it: that row stays on its own, at its moment, where it is seen, and the job's older successes
|
|
// start a new fold below it. Rows arrive newest first; a fold stands at its newest run's place.
|
|
|
|
/** An audit row as the table lists it: a lone row, or the newest of a job's folded runs (`runs`, the
|
|
* whole fold newest first, the row itself included). */
|
|
export type AuditListRow = AuditRow & { runs?: AuditRow[] };
|
|
|
|
/** The job a row is a run of, or null for any other row. */
|
|
function jobOf(row: AuditRow): string | null {
|
|
return row.action === "job_run" && row.target_type === "job" && row.target_id
|
|
? row.target_id
|
|
: null;
|
|
}
|
|
|
|
export function foldJobRuns(rows: readonly AuditRow[]): AuditListRow[] {
|
|
const out: AuditListRow[] = [];
|
|
// Each job's open fold: the row its next older success joins.
|
|
const open = new Map<string, AuditListRow>();
|
|
for (const row of rows) {
|
|
const job = jobOf(row);
|
|
if (job === null) {
|
|
out.push(row);
|
|
continue;
|
|
}
|
|
if (row.after?.status !== "ok") {
|
|
// A failure or a skip stands alone and closes the job's fold.
|
|
open.delete(job);
|
|
out.push(row);
|
|
continue;
|
|
}
|
|
const head = open.get(job);
|
|
if (head) {
|
|
head.runs = [...(head.runs ?? [head]), row];
|
|
continue;
|
|
}
|
|
const fresh: AuditListRow = { ...row };
|
|
open.set(job, fresh);
|
|
out.push(fresh);
|
|
}
|
|
return out;
|
|
}
|