peter
6b0401b922
114 exception handlers neither logged nor re-raised. The defect was never that
they are silent — plenty of them should be — it is that their silence said
nothing, so nobody could tell a decision from an oversight. Each one has now been
read. 44 got a line; the other 70 carry `# silent-ok: <why>`.
What the silent ones had been hiding, in the cases that got a line:
- A failed ffprobe sent every HDR file down the 8-bit pipeline, so playback
degraded to a software transcode with nothing saying why; a failed audio probe
collapsed a multi-audio file to one track and the player showed no language
picker; a failed first-PTS probe left subtitles seconds out of sync.
- A subtitle sidecar that existed but would not parse made a PARTIAL track read as
complete, permanently — the viewer loses every cue past the cached window.
- An unreadable crop/trim/cut-list in an edit spec was dropped, so the clip came
out uncropped, untrimmed, or shorter than the one the user built.
- A dropped `max_height` downloaded at best quality against an explicit cap.
- A failed videos.list enrich made every candidate undroppable-from-judgement and
therefore dropped: a working search rendered as "no results".
- An unusable password hash answered as "wrong password", locking the owner out
and telling them they mistyped; a rotated TOKEN_ENCRYPTION_KEY turned every
stored token into "not connected".
- A stored admin setting that would not coerce fell back to the env default while
the settings page went on showing the saved value.
- A one-off InnerTube config failure pinned the whole process to the hard-coded
fallback key, and searches return nothing when that goes stale.
- The HLS sweep reported 0 swept — like a clean run — when it could not list its
own root, leaving every crashed session's segments on disk forever.
Four of them are counted rather than logged per item (dropped cues, dropped cut
list segments, unreclaimed GC files) and reported once per call, because the
alternative is one line per cue over a whole subtitle track.
ruff gains S110 and BLE001. Every blind `except Exception` that remains carries
`# noqa: BLE001 — <why>`, which is the point: catching everything is sometimes
right, and always worth a sentence. plex/sync.py's three best-effort backfill
catches now keep the traceback — a blind catch over a batch that fetches AND
writes could be Plex, the database or our own bug, and `%s` of the exception told
them apart badly. main.py's boot-time log-level read likewise.
logs.event's `code` is positional-only now: `event("x", code=...)` was a TypeError,
and `code` is exactly the word a caller reaches for when the thing that failed has
one of its own.
tests/test_swallowed_exceptions.py is the wider rule ruff cannot see: a handler
that neither logs nor re-raises must say why. Both cases mutation-checked — a
marker removed and a log line removed each fail it, naming the handler.
69 lines
2.9 KiB
Python
69 lines
2.9 KiB
Python
"""In-process WebSocket connection registry for live server→client push.
|
|
|
|
Generic groundwork (notification module phase 2 is the first user): connections are kept in
|
|
this process's memory, keyed by user_id, so a request handler can push an event to all of a
|
|
user's open tabs/devices. Single-uvicorn-process assumption — if we ever run multiple workers,
|
|
replace the in-memory map with a Redis pub/sub fan-out behind the same `push()` interface (same
|
|
note as app.ratelimit).
|
|
|
|
`push()` is intentionally SYNC-callable: ordinary (sync) route handlers run in a threadpool, so
|
|
they schedule the actual send onto the WebSocket event loop via run_coroutine_threadsafe. The
|
|
connect/disconnect/_push coroutines all run on that one loop, so the connection map is only ever
|
|
mutated from a single thread.
|
|
"""
|
|
|
|
import asyncio
|
|
from collections import defaultdict
|
|
|
|
from starlette.websockets import WebSocket
|
|
from app import logs
|
|
|
|
log = logs.get_logger(__name__)
|
|
|
|
|
|
class ConnectionManager:
|
|
def __init__(self) -> None:
|
|
self._conns: dict[int, set[WebSocket]] = defaultdict(set)
|
|
self._loop: asyncio.AbstractEventLoop | None = None
|
|
|
|
async def connect(self, user_id: int, ws: WebSocket) -> None:
|
|
self._loop = asyncio.get_running_loop()
|
|
await ws.accept()
|
|
self._conns[user_id].add(ws)
|
|
|
|
async def disconnect(self, user_id: int, ws: WebSocket) -> None:
|
|
conns = self._conns.get(user_id)
|
|
if conns:
|
|
conns.discard(ws)
|
|
if not conns:
|
|
self._conns.pop(user_id, None)
|
|
|
|
async def _push(self, user_id: int, payload: dict) -> None:
|
|
for ws in list(self._conns.get(user_id, ())):
|
|
try:
|
|
await ws.send_json(payload)
|
|
except Exception as exc: # noqa: BLE001 — one dead socket must not stop the others
|
|
# Stale socket; it'll be cleaned up by its own disconnect handler. But this is
|
|
# also where a live update goes missing: the UI simply never changes, and there
|
|
# is no request behind it whose failure anyone could look up.
|
|
log.debug(
|
|
"a live update could not be pushed to a socket",
|
|
extra=logs.event(
|
|
"realtime.push_failed", user_id=user_id, reason=type(exc).__name__
|
|
),
|
|
)
|
|
|
|
def push(self, user_id: int, payload: dict) -> None:
|
|
"""Schedule a push onto the WebSocket event loop. Safe to call from a sync route
|
|
handler (threadpool). No-op if no WebSocket has ever connected (no loop captured)."""
|
|
loop = self._loop
|
|
if loop is None:
|
|
return
|
|
try:
|
|
asyncio.run_coroutine_threadsafe(self._push(user_id, payload), loop)
|
|
except Exception: # noqa: BLE001 — a closed loop or socket must not fail the caller
|
|
log.debug("ws push failed", exc_info=True)
|
|
|
|
|
|
manager = ConnectionManager()
|