peter
ca9ca85b18
The 7 baselined Optional accesses in plex/stream.py were one fact the type did not carry: the initial spawn (replace_only=None) always supersedes, so only the fallback respawn can get None. An assert at the call site says so; the pyright baseline drops 195 -> 188. test_abuse_limits: the public-URL and YouTube enqueue tests stopped at the profile lookup (400 no_profile) and passed on that unrelated refusal. They now send an inline spec and assert the job is queued. The same shape — a request whose response is discarded — sat at 53 more places across the suite (all returned what they should, measured with a TestClient probe); each now asserts its status, and test_response_checked keeps it that way (seen red).
78 lines
2.8 KiB
Python
78 lines
2.8 KiB
Python
"""A card asks the Plex image proxy for a small cut; a detail page keeps the full one (E31 S4e).
|
||
|
||
Cards fetched the 400×600 poster for a ~144px picture and the 1280×720 backdrop for a ~212px shelf
|
||
picture. The `_sm` variants are cut by Plex at a card's size and cached apart from the full ones; an
|
||
unknown variant still gets the full poster. DB lane (the proxy opens its own short session).
|
||
"""
|
||
|
||
from fastapi.testclient import TestClient
|
||
|
||
import app.state as app_state
|
||
from app.main import app
|
||
from app.models import PlexItem, PlexLibrary
|
||
from app.plex import imgcache
|
||
from app.routes.plex import playback
|
||
|
||
|
||
class _FakePlex:
|
||
calls: list[tuple[str, int | None, int | None]] = []
|
||
|
||
def __init__(self, db) -> None:
|
||
pass
|
||
|
||
def __enter__(self):
|
||
return self
|
||
|
||
def __exit__(self, *exc) -> None:
|
||
return None
|
||
|
||
def image_bytes(self, key, width=None, height=None):
|
||
_FakePlex.calls.append((key, width, height))
|
||
return b"\xff\xd8jpeg", "image/jpeg"
|
||
|
||
|
||
def _setup(db, make_user, monkeypatch, tmp_path) -> TestClient:
|
||
user = make_user()
|
||
lib = PlexLibrary(plex_key="90", title="Movies", kind="movie", enabled=True)
|
||
db.add(lib)
|
||
db.flush()
|
||
db.add(
|
||
PlexItem(
|
||
rating_key="pm1",
|
||
library_id=lib.id,
|
||
kind="movie",
|
||
title="A Movie",
|
||
thumb_key="/library/metadata/pm1/thumb/1",
|
||
art_key="/library/metadata/pm1/art/1",
|
||
)
|
||
)
|
||
db.commit()
|
||
monkeypatch.setattr(app_state, "_configured_cache", True)
|
||
monkeypatch.setattr(playback, "resolved_user_id", lambda request: (user.id, True))
|
||
monkeypatch.setattr(playback, "PlexClient", _FakePlex)
|
||
monkeypatch.setattr(imgcache, "CACHE_DIR", tmp_path)
|
||
_FakePlex.calls = []
|
||
return TestClient(app)
|
||
|
||
|
||
def test_each_variant_is_cut_at_its_own_size(db, make_user, monkeypatch, tmp_path):
|
||
client = _setup(db, make_user, monkeypatch, tmp_path)
|
||
for variant in ("thumb", "thumb_sm", "art", "art_sm"):
|
||
assert client.get(f"/api/plex/image/pm1?variant={variant}").status_code == 200
|
||
assert _FakePlex.calls == [
|
||
("/library/metadata/pm1/thumb/1", 400, 600),
|
||
("/library/metadata/pm1/thumb/1", 240, 360),
|
||
("/library/metadata/pm1/art/1", 1280, 720),
|
||
("/library/metadata/pm1/art/1", 480, 270),
|
||
]
|
||
# Each cut is cached under its own name: asking again reaches Plex no more.
|
||
for variant in ("thumb", "thumb_sm", "art", "art_sm"):
|
||
assert client.get(f"/api/plex/image/pm1?variant={variant}").status_code == 200
|
||
assert len(_FakePlex.calls) == 4
|
||
|
||
|
||
def test_an_unknown_variant_gets_the_full_poster(db, make_user, monkeypatch, tmp_path):
|
||
client = _setup(db, make_user, monkeypatch, tmp_path)
|
||
assert client.get("/api/plex/image/pm1?variant=huge").status_code == 200
|
||
assert _FakePlex.calls == [("/library/metadata/pm1/thumb/1", 400, 600)]
|