peter
47d968eeea
Deep-review round 4, targeted at round 3's changes (f569b19c..e7f38396). Accounts - Switching, adding or signing out an account moved the tab's pin before the page unloaded, so the players' resume beacons fired on the way out under the NEW account: one account's playback position saved into the other. The pin is now handed to the next page (pinOnNextPage) and taken over at import; clearActiveAccount is gone. - Switching to a suspended account was refused but left it in the switcher, refused on every click; a deactivated one was not refused at all, and made the default it signed every account in the browser out on the next request. Every account _session_user would refuse — gone, deactivated, suspended, revoked — is refused and dropped from the list. Share page (/watch) - An IPv6 client is limited by its /64 (client_ip becomes client_key, for every limiter): keyed on the full address, one subscriber could rotate through endless identities. The comments now state what the per-link ceiling costs: guessing from five networks can keep a link shut for its window, and guesses already running when it fills are still checked. - The link is looked up before the limiter records the attempt, so made-up tokens no longer grow it by an entry each. Forms - Failing the same way twice is announced again: the sign-in, passphrase and setup errors are keyed on the attempt (a clear and a set in one handler left the alert node untouched). - The install wizard's own validation showed the generic error — it threw plain objects its catch did not read. It sets the step's message. Tests: a re-pin leaving the previous account's notices behind; the pin hand-over; switching to an ended account; the /64 viewer; made-up tokens; the repeated alerts. Each mutation-checked RED for its own reason.
38 lines
1.5 KiB
TypeScript
38 lines
1.5 KiB
TypeScript
// @vitest-environment jsdom
|
|
//
|
|
// A switch or sign-out hands the tab's next page its account instead of moving the pin: the page being left
|
|
// still unloads as its own account. The players' resume beacons read the pin as they fire on the way out,
|
|
// and with the pin already moved they saved one account's playback position into the other.
|
|
import { beforeEach, describe, expect, it, vi } from "vitest";
|
|
|
|
beforeEach(() => {
|
|
sessionStorage.clear();
|
|
sessionStorage.setItem("siftlode.activeAccount", "3");
|
|
vi.resetModules(); // the hand-over is taken at import: each import below is a page load
|
|
});
|
|
|
|
describe("pinOnNextPage", () => {
|
|
it("leaves the pin alone until the next page, which takes the account over once", async () => {
|
|
const leaving = await import("./activeAccount");
|
|
leaving.pinOnNextPage(7);
|
|
expect(leaving.activeAccountId()).toBe(3); // the unload still acts as 3
|
|
|
|
vi.resetModules();
|
|
const next = await import("./activeAccount");
|
|
expect(next.activeAccountId()).toBe(7);
|
|
|
|
next.pinActiveAccount(9); // BootGate corrects it
|
|
vi.resetModules(); // and an F5 keeps the correction
|
|
expect((await import("./activeAccount")).activeAccountId()).toBe(9);
|
|
});
|
|
|
|
it("hands over no account at all, so the next page adopts the session's default", async () => {
|
|
const leaving = await import("./activeAccount");
|
|
leaving.pinOnNextPage(null);
|
|
expect(leaving.activeAccountId()).toBe(3);
|
|
|
|
vi.resetModules();
|
|
expect((await import("./activeAccount")).activeAccountId()).toBeNull();
|
|
});
|
|
});
|