peter
9538fb1b7a
The feed applied its starred default via a localStorage mirror (LS.defaultViewFilters) written by SavedViewsProvider and read by FeedFiltersProvider on load. That raced the login effect: on a genuinely fresh browser (no LS.filters and no mirror yet) the feed could seed DEFAULT_FILTERS and never re-apply the default until a reload. Plex had no default-application at all. Replace the mirror with a single path: SavedViewsProvider applies the starred default via cfg.setFilters on the views query's FIRST resolve, but only into a genuinely fresh module (no stored filters for the account, and — feed only — no URL filter override). Applying persists it, so it happens once and the last-view-wins path takes over, matching the documented storage semantics. Because it runs off cfg.setFilters it delivers the Plex port for free. Extract pickDefaultToSeed (pure, unit-tested) and cover the first-resolve/stored/no-default cases for both modules in a provider test. Removes the now-dead LS.defaultViewFilters key and its mirror read.
48 lines
1.8 KiB
TypeScript
48 lines
1.8 KiB
TypeScript
import { describe, it, expect } from "vitest";
|
|
import { pickDefaultToSeed, preferSticky } from "./savedViews";
|
|
|
|
const v = (id: number) => ({ id, name: `v${id}` });
|
|
|
|
describe("preferSticky", () => {
|
|
it("returns null when nothing matches", () => {
|
|
expect(preferSticky([], 3)).toBeNull();
|
|
expect(preferSticky([], null)).toBeNull();
|
|
});
|
|
|
|
it("returns the only match regardless of stickyId", () => {
|
|
expect(preferSticky([v(5)], null)?.id).toBe(5);
|
|
expect(preferSticky([v(5)], 99)?.id).toBe(5);
|
|
});
|
|
|
|
it("prefers the sticky view among several identical-filter matches", () => {
|
|
// A (id 1) is earlier in the list, B (id 2) was explicitly applied (sticky).
|
|
expect(preferSticky([v(1), v(2)], 2)?.id).toBe(2);
|
|
});
|
|
|
|
it("falls back to the first match when the sticky id isn't among the matches", () => {
|
|
expect(preferSticky([v(1), v(2)], 99)?.id).toBe(1);
|
|
expect(preferSticky([v(1), v(2)], null)?.id).toBe(1);
|
|
});
|
|
});
|
|
|
|
describe("pickDefaultToSeed", () => {
|
|
const dv = (id: number, is_default = false) => ({ id, name: `v${id}`, is_default });
|
|
|
|
it("returns the starred default when the module is a fresh start", () => {
|
|
expect(pickDefaultToSeed([dv(1), dv(2, true)], true)?.id).toBe(2);
|
|
});
|
|
|
|
it("returns null when the module already has stored filters / a URL override (canSeed=false)", () => {
|
|
expect(pickDefaultToSeed([dv(1), dv(2, true)], false)).toBeNull();
|
|
});
|
|
|
|
it("returns null when there is no starred default, even on a fresh start", () => {
|
|
expect(pickDefaultToSeed([dv(1), dv(2)], true)).toBeNull();
|
|
expect(pickDefaultToSeed([], true)).toBeNull();
|
|
});
|
|
|
|
it("picks the first default deterministically if several are somehow flagged", () => {
|
|
expect(pickDefaultToSeed([dv(1, true), dv(2, true)], true)?.id).toBe(1);
|
|
});
|
|
});
|