peter
4aaaaa7860
The code cited its plan instead of saying why: `E28 review J4`, `(R6 S3b)`, `S1 justified…`,
`deep-review round 5`. That plan lives in the private ops repo, so for every reader of this one the
citation was noise, and a sentence whose subject was the plan step ("round 2 showed…") hid its
lesson behind an id. Each one is gone and the "why" kept: a bare citation is deleted, a sentence
carrying a lesson is reworded around it ("a later attempt showed…").
Measured (`scripts/audit_metrics.py`, product code): 652 lines in 270 files carried an epic code by
the definition the next commit holds (507 / 241 by the old, two-digit-only one) -> 0. Across all
code, tests, scripts and configs: ~1100 epic-code lines plus ~320 sprint/round ids.
Behaviour unchanged, checked mechanically: every changed .py file has the same AST once docstrings
are blanked; css/sh/toml/yml/json files are identical once comments are stripped; the only
non-comment changes in TS/JS are test titles, one description string in a contract table, and five
ESLint messages, whose text is all the gates snapshot diff holds. Not touched: Markdown (docs and
the changelog keep their history), Alembic migrations, TV episode notation (`S2 · E5`), DESIGN.md
ids (`C1`, `B4`, `S3h`), tracker ids (`SEC-16`, `DX-17`).
One stale claim fixed on the way: test_hls_reaper's docstring said the player checkpoints "every
10 s whether or not it is playing", which plex/stream.py calls wrong; it now says what the code does.
53 lines
1.7 KiB
Python
53 lines
1.7 KiB
Python
"""Two rows of CLAUDE.md's canonical-patterns table, held in code.
|
|
|
|
Both had drifted while the table said otherwise: seven `db.query(...)` calls stood beside the
|
|
`select()` the table names, and four modules carried a private `_now` / `now_utc` helper (nine uses)
|
|
where the table says inline `datetime.now(timezone.utc)`. A rule only prose holds drifts; ruff cannot
|
|
ban a method call on an instance or a function's name, so this reads the AST of every app module.
|
|
Pure-logic: no DB.
|
|
"""
|
|
|
|
import ast
|
|
import pathlib
|
|
import re
|
|
|
|
import app
|
|
|
|
APP = pathlib.Path(app.__file__).resolve().parent
|
|
NOW_HELPER = re.compile(r"_?now(_\w+)?|now_utc|utcnow")
|
|
|
|
|
|
def _modules() -> list[tuple[str, ast.Module]]:
|
|
return [
|
|
(p.relative_to(APP.parent).as_posix(), ast.parse(p.read_text(encoding="utf-8")))
|
|
for p in sorted(APP.rglob("*.py"))
|
|
]
|
|
|
|
|
|
def test_queries_use_select_not_the_legacy_query_api():
|
|
found = [
|
|
f"{path}:{node.lineno}"
|
|
for path, tree in _modules()
|
|
for node in ast.walk(tree)
|
|
if isinstance(node, ast.Call)
|
|
and isinstance(node.func, ast.Attribute)
|
|
and node.func.attr == "query"
|
|
]
|
|
assert found == [], "use db.execute(select(...)) — SQLAlchemy 2.0 — not db.query(...)"
|
|
|
|
|
|
def test_the_current_time_is_inline_not_a_helper():
|
|
found = [
|
|
f"{path}:{node.lineno} {node.name}"
|
|
for path, tree in _modules()
|
|
for node in ast.walk(tree)
|
|
if isinstance(node, ast.FunctionDef | ast.AsyncFunctionDef)
|
|
and NOW_HELPER.fullmatch(node.name)
|
|
]
|
|
assert found == [], "write datetime.now(timezone.utc) inline, not a now()/_now() helper"
|
|
|
|
|
|
def test_the_scan_sees_the_app():
|
|
# a scan that reads nothing is green over nothing
|
|
assert len(_modules()) > 50
|