Files
siftlode/frontend/src/lib/useUndoable.ts
T
peter e006cc879f refactor(frontend): satisfy noUncheckedIndexedAccess (S3b)
Enable noUncheckedIndexedAccess and fix all 98 call sites it surfaced across 18
files. Every fix is behaviour-preserving — the flag flagged reads TypeScript
couldn't prove in-bounds, all of which were already guarded by a length/index check,
a findIndex result, or a non-empty invariant:

- read-once so a ternary's narrowing sticks (Feed overrides, linkify mention);
- non-null assertion AFTER an existing guard (PlayerModal/VideoEditor queue+cut-list
  indexing, modules step, useUndoable stacks) with a comment stating the invariant;
- nullish fallback where undefined is a real possibility (GlassTuner slider ?? def,
  ConfigPanel active group ?? [], descriptionLinks id ?? null);
- optional chaining where the entry genuinely can be absent (PlexBrowse IO entry);
- a non-empty tuple type for the RELATIVE_UNITS constant (encodes "always has [0]").

The single highest-leverage fix: PlayerModal's `active` became `queue?.[index] ??
video` (always Video), clearing 34 of the 45 errors in that file at once. Verified:
tsc/eslint/prettier clean, 56 vitest + 34 pytest + 17/17 e2e green (the e2e suite
exercises the feed/player/channel components touched here).
2026-07-21 04:11:19 +02:00

109 lines
3.5 KiB
TypeScript

import { useCallback, useReducer, useRef } from "react";
// A generic, reusable undo/redo container for a single piece of state.
//
// It keeps a past/present/future snapshot stack: `set` records the current value into the
// past and clears the redo stack; `undo`/`redo` walk the stack. Every value change (set,
// undo, redo) calls `onApply(value)` — the side effect that makes the change real (e.g.
// persist to the server). `reset` installs a fresh value and clears history WITHOUT calling
// onApply (use it when the underlying data is reloaded from the source of truth).
//
// Not playlist-specific: any component with an undoable value (sort order, a draft, a set
// of filters…) can use it. State lives in a ref so the callbacks are stable and never read
// a stale snapshot; a reducer-based force-render keeps the view in sync.
export interface Undoable<T> {
value: T;
set: (next: T) => void;
reset: (value: T) => void;
rebase: (map: (value: T) => T) => void;
undo: () => void;
redo: () => void;
canUndo: boolean;
canRedo: boolean;
}
interface History<T> {
past: T[];
present: T;
future: T[];
}
export function useUndoable<T>(
initial: T,
opts?: { onApply?: (value: T) => void; limit?: number },
): Undoable<T> {
const [, force] = useReducer((n: number) => n + 1, 0);
const ref = useRef<History<T>>({ past: [], present: initial, future: [] });
const onApplyRef = useRef(opts?.onApply);
onApplyRef.current = opts?.onApply;
const limit = opts?.limit ?? 100;
const set = useCallback(
(next: T) => {
const s = ref.current;
if (Object.is(next, s.present)) return;
const past = [...s.past, s.present];
if (past.length > limit) past.shift();
ref.current = { past, present: next, future: [] };
force();
onApplyRef.current?.(next);
},
[limit],
);
const undo = useCallback(() => {
const s = ref.current;
if (!s.past.length) return;
const prev = s.past[s.past.length - 1]!; // past is non-empty (guarded above)
ref.current = {
past: s.past.slice(0, -1),
present: prev,
future: [s.present, ...s.future],
};
force();
onApplyRef.current?.(prev);
}, []);
const redo = useCallback(() => {
const s = ref.current;
if (!s.future.length) return;
const next = s.future[0]!; // future is non-empty (guarded above)
const rest = s.future.slice(1);
ref.current = { past: [...s.past, s.present], present: next, future: rest };
force();
onApplyRef.current?.(next);
}, []);
const reset = useCallback((value: T) => {
ref.current = { past: [], present: value, future: [] };
force();
}, []);
// Apply the same transformation to EVERY snapshot — past, present and future — and keep the
// history. For changes that are outside the undoable dimension but invalidate the snapshots:
// removing a playlist item is not itself undoable, yet dropping it from each stored order keeps
// the user's reorder history valid and usable instead of throwing it away (which is what a
// `reset` does). No `onApply`: the caller is already persisting the change by its own route.
const rebase = useCallback((map: (value: T) => T) => {
const s = ref.current;
ref.current = {
past: s.past.map(map),
present: map(s.present),
future: s.future.map(map),
};
force();
}, []);
const h = ref.current;
return {
value: h.present,
set,
reset,
rebase,
undo,
redo,
canUndo: h.past.length > 0,
canRedo: h.future.length > 0,
};
}