peter
4aaaaa7860
The code cited its plan instead of saying why: `E28 review J4`, `(R6 S3b)`, `S1 justified…`,
`deep-review round 5`. That plan lives in the private ops repo, so for every reader of this one the
citation was noise, and a sentence whose subject was the plan step ("round 2 showed…") hid its
lesson behind an id. Each one is gone and the "why" kept: a bare citation is deleted, a sentence
carrying a lesson is reworded around it ("a later attempt showed…").
Measured (`scripts/audit_metrics.py`, product code): 652 lines in 270 files carried an epic code by
the definition the next commit holds (507 / 241 by the old, two-digit-only one) -> 0. Across all
code, tests, scripts and configs: ~1100 epic-code lines plus ~320 sprint/round ids.
Behaviour unchanged, checked mechanically: every changed .py file has the same AST once docstrings
are blanked; css/sh/toml/yml/json files are identical once comments are stripped; the only
non-comment changes in TS/JS are test titles, one description string in a contract table, and five
ESLint messages, whose text is all the gates snapshot diff holds. Not touched: Markdown (docs and
the changelog keep their history), Alembic migrations, TV episode notation (`S2 · E5`), DESIGN.md
ids (`C1`, `B4`, `S3h`), tracker ids (`SEC-16`, `DX-17`).
One stale claim fixed on the way: test_hls_reaper's docstring said the player checkpoints "every
10 s whether or not it is playing", which plex/stream.py calls wrong; it now says what the code does.
44 lines
1.6 KiB
TypeScript
44 lines
1.6 KiB
TypeScript
// @vitest-environment jsdom
|
|
//
|
|
// A link at the end of a sentence lost the punctuation after it — the trailing
|
|
// `.,;:!?)]` was trimmed off the href and then dropped from the text too — and a URL whose own path
|
|
// ends in a balanced ")" (a Wikipedia article) was cut short and broken.
|
|
import { afterEach, describe, expect, it, vi } from "vitest";
|
|
import { cleanup, render } from "@testing-library/react";
|
|
import type { TFunction } from "i18next";
|
|
|
|
import { renderDescription } from "./descriptionLinks";
|
|
|
|
afterEach(cleanup);
|
|
|
|
function shown(text: string) {
|
|
const { container } = render(
|
|
<div>
|
|
{renderDescription(text, {
|
|
currentId: "x",
|
|
onSeek: vi.fn(),
|
|
onLoadVideo: vi.fn(),
|
|
t: ((k: string) => k) as unknown as TFunction,
|
|
})}
|
|
</div>,
|
|
);
|
|
return {
|
|
text: container.textContent,
|
|
hrefs: [...container.querySelectorAll("a")].map((a) => a.getAttribute("href")),
|
|
};
|
|
}
|
|
|
|
describe("a link in a description", () => {
|
|
it("keeps the punctuation after it in the text, out of the link", () => {
|
|
const r = shown("See https://example.com/page. And (https://example.org/x), too!");
|
|
expect(r.text).toBe("See https://example.com/page. And (https://example.org/x), too!");
|
|
expect(r.hrefs).toEqual(["https://example.com/page", "https://example.org/x"]);
|
|
});
|
|
|
|
it("keeps a balanced parenthesis that belongs to the address", () => {
|
|
const r = shown("Read https://en.wikipedia.org/wiki/Mercury_(planet).");
|
|
expect(r.hrefs).toEqual(["https://en.wikipedia.org/wiki/Mercury_(planet)"]);
|
|
expect(r.text).toBe("Read https://en.wikipedia.org/wiki/Mercury_(planet).");
|
|
});
|
|
});
|