peter
4aaaaa7860
The code cited its plan instead of saying why: `E28 review J4`, `(R6 S3b)`, `S1 justified…`,
`deep-review round 5`. That plan lives in the private ops repo, so for every reader of this one the
citation was noise, and a sentence whose subject was the plan step ("round 2 showed…") hid its
lesson behind an id. Each one is gone and the "why" kept: a bare citation is deleted, a sentence
carrying a lesson is reworded around it ("a later attempt showed…").
Measured (`scripts/audit_metrics.py`, product code): 652 lines in 270 files carried an epic code by
the definition the next commit holds (507 / 241 by the old, two-digit-only one) -> 0. Across all
code, tests, scripts and configs: ~1100 epic-code lines plus ~320 sprint/round ids.
Behaviour unchanged, checked mechanically: every changed .py file has the same AST once docstrings
are blanked; css/sh/toml/yml/json files are identical once comments are stripped; the only
non-comment changes in TS/JS are test titles, one description string in a contract table, and five
ESLint messages, whose text is all the gates snapshot diff holds. Not touched: Markdown (docs and
the changelog keep their history), Alembic migrations, TV episode notation (`S2 · E5`), DESIGN.md
ids (`C1`, `B4`, `S3h`), tracker ids (`SEC-16`, `DX-17`).
One stale claim fixed on the way: test_hls_reaper's docstring said the player checkpoints "every
10 s whether or not it is playing", which plex/stream.py calls wrong; it now says what the code does.
53 lines
1.8 KiB
TypeScript
53 lines
1.8 KiB
TypeScript
// @vitest-environment jsdom
|
|
//
|
|
// A toast with an action (the list page's "Undo") outlives a short toast setting: its button is the
|
|
// only way back, so it gets ACTION_TTL_MIN at least (owner's call). The setting still wins when it
|
|
// is longer, "never" still means never, and a plain toast keeps the reader's time.
|
|
import { describe, it, expect, afterEach, beforeEach, vi } from "vitest";
|
|
import {
|
|
ACTION_TTL_MIN,
|
|
clearAll,
|
|
configureNotifications,
|
|
getActiveToasts,
|
|
notify,
|
|
} from "./notifications";
|
|
|
|
beforeEach(() => vi.useFakeTimers());
|
|
afterEach(() => {
|
|
clearAll();
|
|
configureNotifications({ durationMs: 6000 });
|
|
vi.useRealTimers();
|
|
});
|
|
|
|
const undo = { label: "Undo", onClick: () => {} };
|
|
const shown = (id: number) => getActiveToasts().some((n) => n.id === id);
|
|
|
|
describe("an action toast's lifetime", () => {
|
|
it("stays for the floor when the reader's toasts last 3 s", () => {
|
|
configureNotifications({ durationMs: 3000 });
|
|
const plain = notify({ message: "plain" });
|
|
const withUndo = notify({ message: "removed", action: undo });
|
|
vi.advanceTimersByTime(3001);
|
|
expect(shown(plain)).toBe(false);
|
|
expect(shown(withUndo)).toBe(true);
|
|
vi.advanceTimersByTime(ACTION_TTL_MIN - 3001);
|
|
expect(shown(withUndo)).toBe(false);
|
|
});
|
|
|
|
it("keeps a longer setting", () => {
|
|
configureNotifications({ durationMs: 12000 });
|
|
const id = notify({ message: "removed", action: undo });
|
|
vi.advanceTimersByTime(ACTION_TTL_MIN + 1);
|
|
expect(shown(id)).toBe(true);
|
|
vi.advanceTimersByTime(12000 - ACTION_TTL_MIN);
|
|
expect(shown(id)).toBe(false);
|
|
});
|
|
|
|
it("never dismisses when the reader chose never", () => {
|
|
configureNotifications({ durationMs: 0 });
|
|
const id = notify({ message: "removed", action: undo });
|
|
vi.advanceTimersByTime(60000);
|
|
expect(shown(id)).toBe(true);
|
|
});
|
|
});
|