peter
4aaaaa7860
The code cited its plan instead of saying why: `E28 review J4`, `(R6 S3b)`, `S1 justified…`,
`deep-review round 5`. That plan lives in the private ops repo, so for every reader of this one the
citation was noise, and a sentence whose subject was the plan step ("round 2 showed…") hid its
lesson behind an id. Each one is gone and the "why" kept: a bare citation is deleted, a sentence
carrying a lesson is reworded around it ("a later attempt showed…").
Measured (`scripts/audit_metrics.py`, product code): 652 lines in 270 files carried an epic code by
the definition the next commit holds (507 / 241 by the old, two-digit-only one) -> 0. Across all
code, tests, scripts and configs: ~1100 epic-code lines plus ~320 sprint/round ids.
Behaviour unchanged, checked mechanically: every changed .py file has the same AST once docstrings
are blanked; css/sh/toml/yml/json files are identical once comments are stripped; the only
non-comment changes in TS/JS are test titles, one description string in a contract table, and five
ESLint messages, whose text is all the gates snapshot diff holds. Not touched: Markdown (docs and
the changelog keep their history), Alembic migrations, TV episode notation (`S2 · E5`), DESIGN.md
ids (`C1`, `B4`, `S3h`), tracker ids (`SEC-16`, `DX-17`).
One stale claim fixed on the way: test_hls_reaper's docstring said the player checkpoints "every
10 s whether or not it is playing", which plex/stream.py calls wrong; it now says what the code does.
27 lines
1.3 KiB
TypeScript
27 lines
1.3 KiB
TypeScript
import { useCallback, useLayoutEffect, useRef, type RefObject } from "react";
|
|
|
|
/** A ref that holds the latest COMMITTED `value`, for a stable callback that must still read fresh
|
|
* props: an event handler, a timer, an API that takes its callbacks once. When only effects read the
|
|
* value, use `useEffectEvent` instead.
|
|
*
|
|
* Written in a layout effect, never during render. A render-phase `ref.current = value` makes the
|
|
* React Compiler skip the whole component, and it is wrong under concurrent rendering anyway:
|
|
* a render React throws away would still have overwritten the value. Read it outside render only. */
|
|
export function useLatest<T>(value: T): RefObject<T> {
|
|
const ref = useRef(value);
|
|
useLayoutEffect(() => {
|
|
ref.current = value;
|
|
});
|
|
return ref;
|
|
}
|
|
|
|
/** A callback with a STABLE identity that always runs the latest `fn` — for a handler handed to
|
|
* something memoized (a column set, a menu model) that must not rebuild whenever the handler's
|
|
* inputs change. Call it from events only, never during render: it runs the last COMMITTED `fn`. */
|
|
export function useStableCallback<A extends unknown[], R>(
|
|
fn: (...args: A) => R,
|
|
): (...args: A) => R {
|
|
const latest = useLatest(fn);
|
|
return useCallback((...args: A) => latest.current(...args), [latest]);
|
|
}
|