peter 8525666913 test: round 4 — an assertion that could not fail, and a comment that did not add up ...

Two findings, both in the review's own work; nothing in the product code. That is
the shift that ends the loop: 22 → 13 → 6 → 2, and the last two are a test and a
comment rather than a defect.

The "an override that is fine is still honoured" leg of the bounds-fallback test
stored `spec.max` — which, for this key, IS the env default, because the spec's
max is derived from it. So the assertion was satisfied by the fallback it existed
to rule out: mutating `_coerce` to reject EVERY int override left all three legs
green. It stores `spec.max - 1` now and asserts the value differs from the
default, so the leg can actually fail.

And the shrink test's comment claimed `3 - 5 = -2` for an expression that computes
`chips.length - visible` = `2 - 3 = -1` — naming neither operand nor the result,
in a comment that was rewritten one round earlier precisely for miscounting.

2026-09-22 00:22:30 +02:00

..

fixtures

feat: client log with request ids, joined to the server's

2026-09-17 01:44:29 +02:00

conftest.py

test: a request that raises is rolled back, as production rolls it back

2026-09-19 22:48:20 +02:00

test_abuse_limits.py

fix(e12): close what round one broke, and revert two fixes that overreached

2026-09-05 04:02:57 +02:00

test_adapters.py

fix: name the error yt-dlp actually raises for a cookie-emptied client set

2026-09-16 04:29:13 +02:00

test_admin_invites.py

fix(api): a token hiccup is not "reconnect"; reorders and approvals are one unit each

2026-09-19 19:19:29 +02:00

test_admin_logs.py

fix(diagnostics): honest live console after review

2026-09-19 03:42:26 +02:00

test_admin_pending_access.py

fix(auth): close what the epic's own review found (E9.5 review round 1)

2026-09-04 22:42:15 +02:00

test_auth_session.py

fix(api): mutations answer ok; route helpers flush and leave the commit to the handler

2026-09-19 18:21:06 +02:00

test_body_limit.py

test: round 4 — an assertion that could not fail, and a comment that did not add up

2026-09-22 00:22:30 +02:00

test_channel_backfill.py

test: a handler that flushes a write and never commits it fails its test

2026-09-19 19:19:30 +02:00

test_channel_subscribe_upstream.py

fix(logs): deep-review round 1 — say each failure once, and scrub it everywhere

2026-09-18 03:16:15 +02:00

test_channel_tags.py

test: a handler that flushes a write and never commits it fails its test

2026-09-19 19:19:30 +02:00

test_config_commit_ownership.py

style: apply ruff format across backend + scripts (line-length 100)

2026-08-23 07:43:06 +02:00

test_db_lane.py

style: apply ruff format across backend + scripts (line-length 100)

2026-08-23 07:43:06 +02:00

test_debug_sessions.py

fix(issues): the preview must not ask the tracker for a repository context

2026-09-20 07:51:08 +02:00

test_demo_refusal_detail.py

feat: Settings → Diagnostics, a consented log level and the tab's own log

2026-09-17 02:42:12 +02:00

test_diagnostics.py

feat(diagnostics): the debug recorder — start, the pill, steps, screenshots, stop (E16 S2)

2026-09-19 22:08:10 +02:00

test_discover.py

fix(api): a waiting reorder deals from the fresh order; the commit check sees staged writes

2026-09-19 19:30:27 +02:00

test_download_credentials.py

fix: name the error yt-dlp actually raises for a cookie-emptied client set

2026-09-16 04:29:13 +02:00

test_download_deprioritize.py

perf(downloads): de-prioritize worker transcodes + idle-back-off polls to stop LAN slowdown

2026-08-28 02:37:56 +02:00

test_download_errors.py

fix: a YouTube stream refused after extraction is the gate, not a network fault

2026-09-16 03:43:29 +02:00

test_download_failure_catalog.py

fix(logs): deep-review round 3 — a failure nobody could record is one scrubbed line

2026-09-18 23:44:42 +02:00

test_download_job_locks.py

fix(downloads): E11.5 epic-end review round 2

2026-09-14 01:42:57 +02:00

test_download_limits.py

fix(e12): the restart hint pointed at the one command that undoes a rollback

2026-09-05 04:18:33 +02:00

test_download_output.py

fix(downloads): classify media_kind from a file probe, not yt-dlp info

2026-08-30 03:32:14 +02:00

test_download_ref_count.py

style: apply ruff format across backend + scripts (line-length 100)

2026-08-23 07:43:06 +02:00

test_download_transitions.py

style: apply ruff format across backend + scripts (line-length 100)

2026-08-23 07:43:06 +02:00

test_downloads_finalize.py

style: apply ruff format across backend + scripts (line-length 100)

2026-08-23 07:43:06 +02:00

test_email_alerts.py

feat(email): write to people in their own language (E9.5 S7)

2026-09-04 20:29:33 +02:00

test_email_canonical.py

fix(auth): close the three leftovers E9.5 logged but kept out of its diff

2026-09-05 01:35:09 +02:00

test_email_html_part.py

feat(email): write to people in their own language (E9.5 S7)

2026-09-04 20:29:33 +02:00

test_facebook_impersonation.py

fix(downloads): E11.5 epic-end review round 1

2026-09-14 00:50:05 +02:00

test_failure_lines.py

fix(logs): deep-review round 3 — a failure nobody could record is one scrubbed line

2026-09-18 23:44:42 +02:00

test_feed_cursor.py

test: a handler that flushes a write and never commits it fails its test

2026-09-19 19:19:30 +02:00

test_feed_fallback.py

fix(sync): only a refusal about the channel spends its fallback window

2026-09-19 05:54:19 +02:00

test_feed_keyset.py

style: apply ruff format across backend + scripts (line-length 100)

2026-08-23 07:43:06 +02:00

test_feed_views.py

fix(e8): deep-review hardening + cut 0.73.0

2026-08-26 05:25:47 +02:00

test_ffmpeg_callbacks.py

style: apply ruff format across backend + scripts (line-length 100)

2026-08-23 07:43:06 +02:00

test_followed_channels.py

fix(sync): read a dark RSS feed through the API instead

2026-09-19 04:51:31 +02:00

test_formats.py

fix(boot): review round 1 — reconcile the tab pin, one loading clock, honest probe failures

2026-09-15 00:53:15 +02:00

test_gc.py

perf(downloads): de-prioritize worker transcodes + idle-back-off polls to stop LAN slowdown

2026-08-28 02:37:56 +02:00

test_hls_reaper.py

test: a handler that flushes a write and never commits it fails its test

2026-09-19 19:19:30 +02:00

test_http_details.py

fix(i18n): every refusal the API answers is structured and said in the reader's language

2026-09-19 07:34:17 +02:00

test_last_login.py

fix(api): mutations answer ok; route helpers flush and leave the commit to the handler

2026-09-19 18:21:06 +02:00

test_like_literals.py

fix(search): typed text is a literal in every LIKE pattern

2026-09-19 01:33:32 +02:00

test_links.py

feat(downloads): local file upload ingest — media library backend (E7 S5a)

2026-08-29 08:02:11 +02:00

test_log_pii.py

fix(youtube): a refused YouTube action answers a 422 that says what to do

2026-09-19 06:55:40 +02:00

test_logger_names.py

fix(logs): deep-review round 1 — say each failure once, and scrub it everywhere

2026-09-18 03:16:15 +02:00

test_login_states.py

fix(auth): name the state and the address behind a refused sign-in (E9.5 S4)

2026-09-04 01:56:55 +02:00

test_logs.py

fix(logs): the browser's copy of a polled read is quiet too

2026-09-19 05:03:31 +02:00

test_logsink.py

fix(logs): deep-review round 2 — a stack names code, not data, and survives a failed write

2026-09-18 22:50:37 +02:00

test_mail_language.py

fix(auth): close what the epic's own review found (E9.5 review round 1)

2026-09-04 22:42:15 +02:00

test_me_email_flag.py

fix: address the feature review — accurate copy, reachable controls, real coverage

2026-09-01 23:31:49 +02:00

test_migrations.py

style: apply ruff format across backend + scripts (line-length 100)

2026-08-23 07:43:06 +02:00

test_naming.py

style: apply ruff format across backend + scripts (line-length 100)

2026-08-23 07:43:06 +02:00

test_not_found_detail.py

fix(api,ui): a refused write says why, wherever the refusal happens

2026-09-12 05:50:31 +02:00

test_notifications.py

style: apply ruff format across backend + scripts (line-length 100)

2026-08-23 07:43:06 +02:00

test_oauth_redirect.py

style: apply ruff format across backend + scripts (line-length 100)

2026-08-23 07:43:06 +02:00

test_og.py

style: apply ruff format across backend + scripts (line-length 100)

2026-08-23 07:43:06 +02:00

test_override_dep_convention.py

test: a request that raises is rolled back, as production rolls it back

2026-09-19 22:48:20 +02:00

test_playlist_merge.py

fix(review): resolve deep-review findings across quickfix batch #2

2026-08-29 03:52:13 +02:00

test_playlist_move.py

test: close the last coverage debt the roadmap still listed

2026-09-19 18:14:18 +02:00

test_plex_cards.py

E5 S1: shared Carousel primitive + Plex card-art serializer

2026-08-20 08:50:47 +02:00

test_plex_clear_resume_push.py

test: a handler that flushes a write and never commits it fails its test

2026-09-19 19:19:30 +02:00

test_plex_collection_sort.py

test: a handler that flushes a write and never commits it fails its test

2026-09-19 19:19:30 +02:00

test_plex_collections_filter.py

test: a handler that flushes a write and never commits it fails its test

2026-09-19 19:19:30 +02:00

test_plex_detail.py

test: a handler that flushes a write and never commits it fails its test

2026-09-19 19:19:30 +02:00

test_plex_discover.py

test: a handler that flushes a write and never commits it fails its test

2026-09-19 19:19:30 +02:00

test_plex_facets_grid_parity.py

style: apply ruff format across backend + scripts (line-length 100)

2026-08-23 07:43:06 +02:00

test_plex_facets.py

test: a handler that flushes a write and never commits it fails its test

2026-09-19 19:19:30 +02:00

test_plex_field_scoped_search.py

test: a handler that flushes a write and never commits it fails its test

2026-09-19 19:19:30 +02:00

test_plex_finish.py

fix(api): mutations answer ok; route helpers flush and leave the commit to the handler

2026-09-19 18:21:06 +02:00

test_plex_hls_file_route.py

test(be): every dependency override goes through override_dep

2026-09-19 17:26:07 +02:00

test_plex_jsonb_normalize.py

style: apply ruff format across backend + scripts (line-length 100)

2026-08-23 07:43:06 +02:00

test_plex_keyword_filter.py

test: a handler that flushes a write and never commits it fails its test

2026-09-19 19:19:30 +02:00

test_plex_lang.py

test: a handler that flushes a write and never commits it fails its test

2026-09-19 19:19:30 +02:00

test_plex_last_watched_sort.py

test: a handler that flushes a write and never commits it fails its test

2026-09-19 19:19:30 +02:00

test_plex_overlay.py

refactor(plex): move content_libs down into the query layer

2026-09-06 03:31:02 +02:00

test_plex_person_bio.py

test: a handler that flushes a write and never commits it fails its test

2026-09-19 19:19:30 +02:00

test_plex_person.py

test: a handler that flushes a write and never commits it fails its test

2026-09-19 19:19:30 +02:00

test_plex_playback_class.py

test: a handler that flushes a write and never commits it fails its test

2026-09-19 19:19:30 +02:00

test_plex_playback_session.py

test: a handler that flushes a write and never commits it fails its test

2026-09-19 19:19:30 +02:00

test_plex_query_conversion.py

test: a handler that flushes a write and never commits it fails its test

2026-09-19 19:19:30 +02:00

test_plex_stream.py

fix(plex): playback sessions per viewer, bounded in total; a fair share of subtitle passes

2026-09-19 07:16:17 +02:00

test_plex_subtitle_auth.py

test: a handler that flushes a write and never commits it fails its test

2026-09-19 19:19:30 +02:00

test_plex_subtitle_prepare.py

fix(plex): playback sessions per viewer, bounded in total; a fair share of subtitle passes

2026-09-19 07:16:17 +02:00

test_plex_sync_prune.py

style: apply ruff format across backend + scripts (line-length 100)

2026-08-23 07:43:06 +02:00

test_plex_sync_txn.py

style: apply ruff format across backend + scripts (line-length 100)

2026-08-23 07:43:06 +02:00

test_plex_tmdb.py

style: apply ruff format across backend + scripts (line-length 100)

2026-08-23 07:43:06 +02:00

test_plex_watch_sync.py

fix(plex): resolve movies stuck "in progress" on the 15-min incremental sync

2026-08-28 01:34:02 +02:00

test_progress_bounds.py

fix(api): progress checkpoints past the int4 column are a 422, and idle HLS sessions are reaped on a timer

2026-09-11 18:05:30 +02:00

test_public_unlock_limit.py

fix: review round 4 — an account switch unloads as the old account, a share link's lockout costs five networks

2026-09-15 02:53:22 +02:00

test_python_engine_contract.py

build: pin one Python version across the app, the images and the gate

2026-09-20 23:02:11 +02:00

test_quota_ownership.py

style: apply ruff format across backend + scripts (line-length 100)

2026-08-23 07:43:06 +02:00

test_ratelimit.py

fix: review round 3 — a new tab keeps its account's notices, a revoked tab account lands on the default

2026-09-15 02:25:00 +02:00

test_request_models.py

style: apply ruff format across backend + scripts (line-length 100)

2026-08-23 07:43:06 +02:00

test_reset_link_states.py

fix(auth): stop drawing a reset form the link can no longer fill (E9.5 S4)

2026-09-04 02:38:01 +02:00

test_review_round.py

test(auth): pin what rounds 1 and 2 left unpinned (E9.5 review round 3)

2026-09-04 23:04:09 +02:00

test_route_conventions.py

fix(diagnostics): deep-review round 2 — a send that claims, not one that blocks

2026-09-20 00:51:12 +02:00

test_run_ffmpeg.py

style: apply ruff format across backend + scripts (line-length 100)

2026-08-23 07:43:06 +02:00

test_saved_views_source.py

test: a handler that flushes a write and never commits it fails its test

2026-09-19 19:19:30 +02:00

test_scheduler.py

style: apply ruff format across backend + scripts (line-length 100)

2026-08-23 07:43:06 +02:00

test_search_scrape_ingest.py

test: a handler that flushes a write and never commits it fails its test

2026-09-19 19:19:30 +02:00

test_security.py

style: apply ruff format across backend + scripts (line-length 100)

2026-08-23 07:43:06 +02:00

test_set_password_link.py

feat(admin): an account panel, and a set-password link that needs no email

2026-09-05 01:46:58 +02:00

test_smoke.py

style: apply ruff format across backend + scripts (line-length 100)

2026-08-23 07:43:06 +02:00

test_storage.py

style: apply ruff format across backend + scripts (line-length 100)

2026-08-23 07:43:06 +02:00

test_swallowed_exceptions.py

fix(logs): rule on every swallowed exception in the backend

2026-09-18 01:20:42 +02:00

test_sync_guards.py

fix(sync): the stored RSS warning says what the API fallback read

2026-09-19 05:05:13 +02:00

test_sysconfig_registry.py

feat: closed-set admin knobs are pickers, not free text

2026-09-17 00:03:56 +02:00

test_tag_suggest.py

fix(e8): deep-review hardening + cut 0.73.0

2026-08-26 05:25:47 +02:00

test_thumbnail_poster.py

style: apply ruff format across backend + scripts (line-length 100)

2026-08-23 07:43:06 +02:00

test_titles.py

style: apply ruff format across backend + scripts (line-length 100)

2026-08-23 07:43:06 +02:00

test_upload.py

fix(downloads): take the duration from the file when yt-dlp gives none

2026-09-13 23:12:16 +02:00

test_urlguard.py

fix(e12): close what round one broke, and revert two fixes that overreached

2026-09-05 04:02:57 +02:00

test_userscope.py

style: apply ruff format across backend + scripts (line-length 100)

2026-08-23 07:43:06 +02:00

test_utils.py

style: apply ruff format across backend + scripts (line-length 100)

2026-08-23 07:43:06 +02:00

test_welcome_mail.py

fix(api): mutations answer ok; route helpers flush and leave the commit to the handler

2026-09-19 18:21:06 +02:00

test_worker_supervisor.py

fix(logs): deep-review round 2 — a stack names code, not data, and survives a failed write

2026-09-18 22:50:37 +02:00

test_youtube_no_channel.py

fix(logs): keep polling reads and a channel-less account out of the warnings

2026-09-19 04:51:31 +02:00

test_youtube_refusals.py

fix(api): a token hiccup is not "reconnect"; reorders and approvals are one unit each

2026-09-19 19:19:29 +02:00

test_ytdlp_logging.py

fix(logs): deep-review round 3 — a failure nobody could record is one scrubbed line

2026-09-18 23:44:42 +02:00