peter
8525666913
test: round 4 — an assertion that could not fail, and a comment that did not add up
...
Two findings, both in the review's own work; nothing in the product code. That is
the shift that ends the loop: 22 → 13 → 6 → 2, and the last two are a test and a
comment rather than a defect.
The "an override that is fine is still honoured" leg of the bounds-fallback test
stored `spec.max` — which, for this key, IS the env default, because the spec's
max is derived from it. So the assertion was satisfied by the fallback it existed
to rule out: mutating `_coerce` to reject EVERY int override left all three legs
green. It stores `spec.max - 1` now and asserts the value differs from the
default, so the leg can actually fail.
And the shrink test's comment claimed `3 - 5 = -2` for an expression that computes
`chips.length - visible` = `2 - 3 = -1` — naming neither operand nor the result,
in a comment that was rewritten one round earlier precisely for miscounting.
2026-09-22 00:22:30 +02:00
..
2026-09-19 04:51:43 +02:00
2026-09-21 23:33:02 +02:00
2026-09-16 00:49:23 +02:00
2026-09-19 07:46:33 +02:00
2026-09-13 20:47:13 +02:00
2026-09-19 08:07:25 +02:00
2026-09-17 02:59:09 +02:00
2026-09-17 02:59:09 +02:00
2026-09-17 02:59:09 +02:00
2026-09-19 05:47:16 +02:00
2026-09-19 05:47:16 +02:00
2026-09-17 02:59:09 +02:00
2026-09-17 02:59:09 +02:00
2026-09-19 08:07:25 +02:00
2026-09-19 22:08:10 +02:00
2026-09-20 00:09:52 +02:00
2026-09-05 16:58:29 +02:00
2026-09-17 02:59:09 +02:00
2026-09-05 01:35:09 +02:00
2026-09-21 01:44:21 +02:00
2026-09-21 01:44:21 +02:00
2026-08-08 00:50:05 +02:00
2026-09-19 08:07:25 +02:00
2026-08-25 01:44:34 +02:00
2026-09-19 07:46:33 +02:00
2026-09-19 08:07:25 +02:00
2026-09-13 06:08:05 +02:00
2026-09-13 06:08:05 +02:00
2026-09-13 06:08:05 +02:00
2026-09-11 01:38:31 +02:00
2026-09-13 00:17:09 +02:00
2026-09-17 02:59:09 +02:00
2026-09-17 02:59:09 +02:00
2026-09-21 01:44:21 +02:00
2026-09-05 16:58:29 +02:00
2026-09-21 23:32:22 +02:00
2026-09-21 23:32:22 +02:00
2026-09-21 23:32:22 +02:00
2026-09-21 23:32:22 +02:00
2026-09-16 01:05:53 +02:00
2026-09-17 02:59:09 +02:00
2026-09-17 02:59:09 +02:00
2026-08-26 02:39:00 +02:00
2026-09-21 23:59:59 +02:00
2026-09-05 16:58:29 +02:00
2026-09-21 01:44:21 +02:00
2026-09-17 01:44:29 +02:00
2026-09-06 05:07:06 +02:00
2026-09-21 01:44:21 +02:00
2026-09-19 05:54:19 +02:00
2026-09-17 23:45:41 +02:00
2026-09-17 23:45:41 +02:00
2026-09-21 01:44:21 +02:00
2026-09-17 02:59:09 +02:00
2026-09-17 02:59:09 +02:00
2026-09-21 01:44:21 +02:00
2026-09-21 01:44:21 +02:00
2026-09-21 01:44:21 +02:00
2026-09-05 16:58:29 +02:00
2026-09-19 22:08:10 +02:00
2026-09-21 01:44:21 +02:00
2026-09-17 02:59:09 +02:00
2026-07-27 22:10:03 +02:00
2026-09-17 02:59:09 +02:00
2026-09-21 01:44:21 +02:00
2026-09-19 17:53:22 +02:00
2026-09-14 00:50:05 +02:00
2026-09-13 21:53:25 +02:00
2026-09-21 23:32:22 +02:00
2026-09-17 02:59:09 +02:00
2026-09-19 05:47:17 +02:00
2026-09-19 04:51:31 +02:00
2026-09-05 16:58:29 +02:00
2026-09-13 06:08:05 +02:00
2026-09-13 06:08:05 +02:00
2026-09-21 01:44:21 +02:00
2026-09-17 02:59:09 +02:00
2026-09-17 02:59:09 +02:00
2026-09-17 02:59:09 +02:00
2026-09-17 02:59:09 +02:00
2026-09-17 02:59:09 +02:00
2026-09-21 01:44:21 +02:00
2026-09-17 02:59:09 +02:00
2026-09-19 05:54:19 +02:00
2026-09-17 02:59:09 +02:00
2026-09-17 02:59:09 +02:00
2026-09-05 16:58:29 +02:00
2026-09-15 02:53:22 +02:00
2026-09-21 01:44:21 +02:00
2026-09-19 17:58:39 +02:00
2026-09-19 17:07:11 +02:00
2026-09-19 17:07:11 +02:00
2026-09-21 01:44:21 +02:00
2026-09-20 04:30:42 +02:00
2026-09-21 01:44:21 +02:00
2026-09-15 02:53:22 +02:00
2026-09-17 02:59:09 +02:00
2026-09-14 23:58:30 +02:00
2026-09-17 02:59:09 +02:00
2026-09-13 06:08:05 +02:00
2026-09-19 22:26:49 +02:00
2026-09-19 22:26:49 +02:00
2026-09-13 07:00:51 +02:00
2026-09-21 01:44:21 +02:00
2026-09-17 02:59:09 +02:00
2026-09-19 07:51:33 +02:00
2026-09-17 03:53:40 +02:00
2026-09-21 01:44:21 +02:00
2026-09-08 00:06:34 +02:00
2026-09-19 17:07:11 +02:00
2026-09-08 00:06:34 +02:00
2026-09-19 17:07:11 +02:00
2026-09-21 00:12:44 +02:00
2026-09-19 05:47:17 +02:00
2026-09-17 02:59:09 +02:00
2026-09-12 05:49:58 +02:00
2026-09-11 23:43:23 +02:00
2026-09-21 01:44:21 +02:00
2026-09-19 19:30:27 +02:00
2026-09-19 19:30:27 +02:00
2026-09-17 02:59:09 +02:00
2026-09-21 01:44:21 +02:00
2026-09-21 23:32:22 +02:00
2026-09-21 23:32:22 +02:00
2026-09-19 18:14:18 +02:00
2026-09-19 07:46:33 +02:00
2026-09-19 17:12:47 +02:00
2026-09-19 17:58:40 +02:00
2026-09-19 18:14:18 +02:00
2026-09-19 17:23:55 +02:00
2026-09-21 01:44:21 +02:00
2026-09-17 02:59:09 +02:00
2026-08-20 05:40:59 +02:00
2026-08-20 05:40:59 +02:00
2026-09-17 02:59:09 +02:00
2026-09-17 02:59:09 +02:00
2026-09-21 01:44:21 +02:00
2026-09-21 00:20:05 +02:00
2026-09-19 08:07:25 +02:00
2026-09-13 05:38:36 +02:00
2026-09-19 07:40:48 +02:00
2026-09-19 08:07:25 +02:00
2026-09-17 02:59:09 +02:00
2026-09-19 08:07:25 +02:00
2026-09-17 02:59:09 +02:00
2026-09-19 08:07:25 +02:00
2026-09-13 05:38:36 +02:00
2026-09-19 07:46:33 +02:00
2026-08-21 08:11:18 +02:00
2026-09-21 01:44:21 +02:00
2026-08-23 18:39:22 +02:00
2026-09-05 16:58:29 +02:00
2026-08-21 00:08:19 +02:00
2026-09-17 02:59:09 +02:00
2026-09-19 18:14:18 +02:00
2026-09-12 16:21:51 +02:00
2026-09-19 06:58:11 +02:00
2026-09-14 23:58:30 +02:00
2026-09-20 04:30:42 +02:00
2026-09-21 01:44:21 +02:00
2026-09-19 17:12:47 +02:00
2026-09-20 23:21:08 +02:00
2026-09-19 08:07:25 +02:00
2026-09-12 16:22:27 +02:00
2026-09-19 17:23:55 +02:00
2026-09-19 19:19:43 +02:00
2026-09-15 00:53:15 +02:00
2026-09-17 02:59:09 +02:00
2026-09-17 02:59:09 +02:00
2026-09-17 02:59:09 +02:00
2026-09-17 02:59:09 +02:00
2026-09-21 01:44:21 +02:00
2026-09-19 17:12:47 +02:00
2026-09-10 19:31:05 +02:00
2026-08-23 04:40:09 +02:00
2026-08-23 04:40:09 +02:00
2026-09-17 02:59:09 +02:00
2026-09-17 02:59:09 +02:00
2026-09-19 08:07:25 +02:00
2026-09-17 02:59:09 +02:00
2026-09-17 02:59:09 +02:00
2026-09-13 05:38:36 +02:00
2026-09-17 02:59:09 +02:00
2026-09-17 02:59:09 +02:00
2026-09-17 02:59:09 +02:00
2026-09-19 17:53:22 +02:00
2026-09-16 01:05:53 +02:00
2026-09-17 02:59:09 +02:00
2026-09-17 02:59:09 +02:00
2026-09-17 02:59:09 +02:00
2026-09-17 02:59:09 +02:00
2026-09-21 00:12:44 +02:00
2026-09-21 23:59:59 +02:00
2026-09-21 23:32:32 +02:00
2026-08-17 22:18:07 +02:00
2026-09-13 04:16:20 +02:00
2026-09-19 17:58:39 +02:00
2026-09-17 02:59:09 +02:00
2026-09-19 04:51:43 +02:00
2026-09-17 02:59:09 +02:00
2026-09-19 05:47:17 +02:00
2026-09-21 01:44:21 +02:00
2026-09-19 17:23:55 +02:00
2026-09-21 01:44:21 +02:00
2026-09-17 02:59:09 +02:00
2026-09-19 08:07:25 +02:00
2026-09-19 08:07:25 +02:00
2026-09-22 00:22:30 +02:00
2026-09-21 23:59:59 +02:00
2026-09-17 02:59:09 +02:00
2026-09-11 18:04:54 +02:00
2026-09-19 08:07:25 +02:00
2026-08-30 02:04:17 +02:00
2026-09-19 07:46:33 +02:00
2026-09-20 00:09:52 +02:00
2026-09-19 06:55:40 +02:00
2026-09-17 02:59:09 +02:00
2026-09-17 02:59:09 +02:00
2026-09-17 02:59:09 +02:00
2026-09-19 17:30:31 +02:00
2026-09-21 01:44:21 +02:00
2026-09-17 02:59:09 +02:00
2026-09-17 02:59:09 +02:00
2026-09-05 16:58:29 +02:00
2026-09-05 16:58:29 +02:00
2026-09-17 02:59:09 +02:00
2026-09-17 02:59:09 +02:00
2026-09-19 05:47:17 +02:00
2026-09-13 20:47:13 +02:00
2026-09-19 08:07:25 +02:00
2026-08-26 00:44:27 +02:00
2026-09-19 07:46:33 +02:00
2026-09-17 02:59:09 +02:00
2026-09-19 04:51:43 +02:00
2026-09-15 02:25:00 +02:00
2026-09-21 01:44:21 +02:00
2026-09-21 01:44:21 +02:00
2026-09-17 02:59:09 +02:00
2026-09-12 16:22:06 +02:00
2026-09-17 02:59:09 +02:00
2026-09-17 02:59:09 +02:00
2026-09-21 00:12:44 +02:00
2026-09-17 02:59:09 +02:00
2026-09-17 02:59:09 +02:00