The code cited its plan instead of saying why: `E28 review J4`, `(R6 S3b)`, `S1 justified…`,
`deep-review round 5`. That plan lives in the private ops repo, so for every reader of this one the
citation was noise, and a sentence whose subject was the plan step ("round 2 showed…") hid its
lesson behind an id. Each one is gone and the "why" kept: a bare citation is deleted, a sentence
carrying a lesson is reworded around it ("a later attempt showed…").
Measured (`scripts/audit_metrics.py`, product code): 652 lines in 270 files carried an epic code by
the definition the next commit holds (507 / 241 by the old, two-digit-only one) -> 0. Across all
code, tests, scripts and configs: ~1100 epic-code lines plus ~320 sprint/round ids.
Behaviour unchanged, checked mechanically: every changed .py file has the same AST once docstrings
are blanked; css/sh/toml/yml/json files are identical once comments are stripped; the only
non-comment changes in TS/JS are test titles, one description string in a contract table, and five
ESLint messages, whose text is all the gates snapshot diff holds. Not touched: Markdown (docs and
the changelog keep their history), Alembic migrations, TV episode notation (`S2 · E5`), DESIGN.md
ids (`C1`, `B4`, `S3h`), tracker ids (`SEC-16`, `DX-17`).
One stale claim fixed on the way: test_hls_reaper's docstring said the player checkpoints "every
10 s whether or not it is playing", which plex/stream.py calls wrong; it now says what the code does.
116 lines
4.6 KiB
TypeScript
116 lines
4.6 KiB
TypeScript
// @vitest-environment jsdom
|
|
//
|
|
// The count pill while a new search's count loads. keepPreviousData holds the last filter's count, and a
|
|
// broad word's count takes seconds ("a": ~3 s on the prod-sized library): the pill showed the old
|
|
// number as if it were the new search's. It now dims and is aria-busy until the new count lands.
|
|
import { describe, it, expect, vi, beforeAll, afterEach } from "vitest";
|
|
import { render, screen, waitFor, cleanup } from "@testing-library/react";
|
|
import { QueryClient, QueryClientProvider } from "@tanstack/react-query";
|
|
|
|
vi.mock("react-i18next", async (importOriginal) => ({
|
|
...(await importOriginal<typeof import("react-i18next")>()),
|
|
useTranslation: () => ({ t: (key: string) => key, i18n: { language: "en" } }),
|
|
}));
|
|
vi.mock("./wizardContext", () => ({ useWizard: () => ({ openWizard: vi.fn() }) }));
|
|
vi.mock("./VirtualFeed", () => ({ default: () => null }));
|
|
vi.mock("./SelectedViewChip", () => ({ default: () => null }));
|
|
vi.mock("./ActiveFilterChips", () => ({ default: () => null }));
|
|
|
|
import Feed from "./Feed";
|
|
import { api, DEFAULT_TAG_MODES, type FeedFilters } from "../lib/api";
|
|
import { qk } from "../lib/queryKeys";
|
|
import type { ReactElement } from "react";
|
|
import { PageToolbarSlot } from "./ui/pageToolbarSlot";
|
|
|
|
beforeAll(() => {
|
|
class Stub {
|
|
observe() {}
|
|
unobserve() {}
|
|
disconnect() {}
|
|
takeRecords() {
|
|
return [];
|
|
}
|
|
}
|
|
globalThis.ResizeObserver ??= Stub as unknown as typeof ResizeObserver;
|
|
globalThis.IntersectionObserver ??= Stub as unknown as typeof IntersectionObserver;
|
|
});
|
|
afterEach(() => {
|
|
cleanup();
|
|
vi.restoreAllMocks();
|
|
});
|
|
|
|
const FILTERS: FeedFilters = {
|
|
tags: [],
|
|
tagModes: DEFAULT_TAG_MODES,
|
|
channelIds: [],
|
|
q: "",
|
|
sort: "newest",
|
|
scope: "my",
|
|
includeNormal: true,
|
|
includeShorts: false,
|
|
includeLive: false,
|
|
show: "unwatched",
|
|
};
|
|
|
|
// The pill lives in the toolbar, which portals into the shell's band: give it one.
|
|
const slot = document.body.appendChild(document.createElement("div"));
|
|
const feed = (q: string, qc: QueryClient): ReactElement => (
|
|
<QueryClientProvider client={qc}>
|
|
<PageToolbarSlot.Provider value={slot}>
|
|
<Feed
|
|
filters={{ ...FILTERS, q }}
|
|
setFilters={() => {}}
|
|
view="cards"
|
|
setView={() => {}}
|
|
canRead
|
|
ytSearch=""
|
|
onYtSearch={() => {}}
|
|
onExitYtSearch={() => {}}
|
|
/>
|
|
</PageToolbarSlot.Provider>
|
|
</QueryClientProvider>
|
|
);
|
|
|
|
describe("Feed — the count while a new search's count loads", () => {
|
|
it("dims the previous count and marks it busy until the new one lands", async () => {
|
|
vi.spyOn(api, "feed").mockResolvedValue({ items: [], next_cursor: null } as never);
|
|
let settle: (v: unknown) => void = () => {};
|
|
vi.spyOn(api, "feedSummary").mockImplementation(((f: FeedFilters) =>
|
|
f.q === "kitchen"
|
|
? Promise.resolve({ count: 1937, facets: {} })
|
|
: new Promise((r) => (settle = r))) as never);
|
|
const qc = new QueryClient({ defaultOptions: { queries: { retry: false } } });
|
|
qc.setQueryData(qk.me(), { id: 1, can_write: true, prefs: {} });
|
|
const pill = () => screen.getByTestId("item-count");
|
|
|
|
const view = render(feed("kitchen", qc));
|
|
await waitFor(() => expect(pill().getAttribute("title")).toBe("1,937"));
|
|
expect(pill().getAttribute("aria-busy")).toBeNull();
|
|
|
|
view.rerender(feed("a", qc));
|
|
await waitFor(() => expect(pill().getAttribute("aria-busy")).toBe("true"));
|
|
expect(pill().getAttribute("title")).toBe("1,937"); // still the old figure, now marked as such
|
|
|
|
settle({ count: 178991, facets: {} });
|
|
await waitFor(() => expect(pill().getAttribute("title")).toBe("178,991"));
|
|
expect(pill().getAttribute("aria-busy")).toBeNull();
|
|
});
|
|
|
|
it("says the count failed instead of showing the empty box of a first load", async () => {
|
|
vi.spyOn(api, "feed").mockResolvedValue({ items: [], next_cursor: null } as never);
|
|
vi.spyOn(api, "feedSummary").mockImplementation(((f: FeedFilters) =>
|
|
f.q === "kitchen"
|
|
? Promise.resolve({ count: 1937, facets: {} })
|
|
: Promise.reject(new Error("boom"))) as never);
|
|
const qc = new QueryClient({ defaultOptions: { queries: { retry: false } } });
|
|
qc.setQueryData(qk.me(), { id: 1, can_write: true, prefs: {} });
|
|
const pill = () => screen.getByTestId("item-count");
|
|
|
|
const view = render(feed("kitchen", qc));
|
|
await waitFor(() => expect(pill().getAttribute("title")).toBe("1,937"));
|
|
view.rerender(feed("a", qc));
|
|
await waitFor(() => expect(pill().getAttribute("title")).toBe("common.countFailed"));
|
|
expect(pill().getAttribute("aria-busy")).toBeNull();
|
|
});
|
|
});
|