peter
4aaaaa7860
The code cited its plan instead of saying why: `E28 review J4`, `(R6 S3b)`, `S1 justified…`,
`deep-review round 5`. That plan lives in the private ops repo, so for every reader of this one the
citation was noise, and a sentence whose subject was the plan step ("round 2 showed…") hid its
lesson behind an id. Each one is gone and the "why" kept: a bare citation is deleted, a sentence
carrying a lesson is reworded around it ("a later attempt showed…").
Measured (`scripts/audit_metrics.py`, product code): 652 lines in 270 files carried an epic code by
the definition the next commit holds (507 / 241 by the old, two-digit-only one) -> 0. Across all
code, tests, scripts and configs: ~1100 epic-code lines plus ~320 sprint/round ids.
Behaviour unchanged, checked mechanically: every changed .py file has the same AST once docstrings
are blanked; css/sh/toml/yml/json files are identical once comments are stripped; the only
non-comment changes in TS/JS are test titles, one description string in a contract table, and five
ESLint messages, whose text is all the gates snapshot diff holds. Not touched: Markdown (docs and
the changelog keep their history), Alembic migrations, TV episode notation (`S2 · E5`), DESIGN.md
ids (`C1`, `B4`, `S3h`), tracker ids (`SEC-16`, `DX-17`).
One stale claim fixed on the way: test_hls_reaper's docstring said the player checkpoints "every
10 s whether or not it is playing", which plex/stream.py calls wrong; it now says what the code does.
90 lines
3.4 KiB
TypeScript
90 lines
3.4 KiB
TypeScript
// @vitest-environment jsdom
|
|
//
|
|
// Contract of the header library-scope pill (scopes + browse modes): it renders the
|
|
// three library scopes PLUS the Playlist/Collection browse-mode entries, marks the active one, writes a
|
|
// picked scope to the provider, and drives the playlists/collections views through the PlexViewBridge.
|
|
// i18n is key-passthrough and both the provider and the bridge are mocked; SegmentedToggle is a plain
|
|
// button group (no floating-ui), so no observer stubs are needed.
|
|
import { describe, it, expect, afterEach, beforeEach, vi } from "vitest";
|
|
import { render, screen, fireEvent, cleanup } from "@testing-library/react";
|
|
|
|
vi.mock("react-i18next", async (importOriginal) => {
|
|
const actual = await importOriginal<typeof import("react-i18next")>();
|
|
return { ...actual, useTranslation: () => ({ t: (key: string) => key }) };
|
|
});
|
|
|
|
const plexState = { scope: "both" } as { scope: string };
|
|
const setScope = vi.fn();
|
|
vi.mock("./plexContext", () => ({
|
|
usePlex: () => plexState,
|
|
usePlexActions: () => ({ setScope }),
|
|
}));
|
|
|
|
// The bridge: a controllable current view kind + an open spy.
|
|
const controls = { kind: "discover" as string, open: vi.fn() };
|
|
vi.mock("./plexViewContext", () => ({
|
|
usePlexViewControls: () => controls,
|
|
}));
|
|
|
|
import PlexScopeToggle from "./PlexScopeToggle";
|
|
|
|
beforeEach(() => {
|
|
plexState.scope = "both";
|
|
controls.kind = "discover";
|
|
setScope.mockReset();
|
|
controls.open.mockReset();
|
|
});
|
|
afterEach(cleanup);
|
|
|
|
const buttons = () => [
|
|
...screen.getByRole("group", { name: "plex.filter.scope" }).querySelectorAll("button"),
|
|
];
|
|
const labels = () => buttons().map((b) => b.textContent);
|
|
const pressed = () =>
|
|
buttons()
|
|
.filter((b) => b.getAttribute("aria-pressed") === "true")
|
|
.map((b) => b.textContent);
|
|
|
|
describe("PlexScopeToggle", () => {
|
|
it("renders the three scopes plus the two browse modes, the current scope pressed", () => {
|
|
plexState.scope = "movie";
|
|
render(<PlexScopeToggle />);
|
|
expect(labels()).toEqual([
|
|
"plex.filter.scopeOpt.both",
|
|
"plex.filter.scopeOpt.movie",
|
|
"plex.filter.scopeOpt.show",
|
|
"plex.filter.scopeOpt.playlists",
|
|
"plex.filter.scopeOpt.collections",
|
|
]);
|
|
expect(pressed()).toEqual(["plex.filter.scopeOpt.movie"]);
|
|
});
|
|
|
|
it("writes a picked scope back to the provider (no view switch when already on a title view)", () => {
|
|
render(<PlexScopeToggle />);
|
|
fireEvent.click(screen.getByRole("button", { name: "plex.filter.scopeOpt.show" }));
|
|
expect(setScope).toHaveBeenCalledWith("show");
|
|
expect(controls.open).not.toHaveBeenCalled();
|
|
});
|
|
|
|
it("opens the playlists view (not a scope change) for the Playlist mode", () => {
|
|
render(<PlexScopeToggle />);
|
|
fireEvent.click(screen.getByRole("button", { name: "plex.filter.scopeOpt.playlists" }));
|
|
expect(controls.open).toHaveBeenCalledWith({ kind: "playlists" });
|
|
expect(setScope).not.toHaveBeenCalled();
|
|
});
|
|
|
|
it("marks the Collection mode active when the current view is collections", () => {
|
|
controls.kind = "collections";
|
|
render(<PlexScopeToggle />);
|
|
expect(pressed()).toEqual(["plex.filter.scopeOpt.collections"]);
|
|
});
|
|
|
|
it("returns to the title grid when a scope is picked from a browse mode", () => {
|
|
controls.kind = "playlists";
|
|
render(<PlexScopeToggle />);
|
|
fireEvent.click(screen.getByRole("button", { name: "plex.filter.scopeOpt.movie" }));
|
|
expect(setScope).toHaveBeenCalledWith("movie");
|
|
expect(controls.open).toHaveBeenCalledWith({ kind: "grid" });
|
|
});
|
|
});
|