peter
4aaaaa7860
The code cited its plan instead of saying why: `E28 review J4`, `(R6 S3b)`, `S1 justified…`,
`deep-review round 5`. That plan lives in the private ops repo, so for every reader of this one the
citation was noise, and a sentence whose subject was the plan step ("round 2 showed…") hid its
lesson behind an id. Each one is gone and the "why" kept: a bare citation is deleted, a sentence
carrying a lesson is reworded around it ("a later attempt showed…").
Measured (`scripts/audit_metrics.py`, product code): 652 lines in 270 files carried an epic code by
the definition the next commit holds (507 / 241 by the old, two-digit-only one) -> 0. Across all
code, tests, scripts and configs: ~1100 epic-code lines plus ~320 sprint/round ids.
Behaviour unchanged, checked mechanically: every changed .py file has the same AST once docstrings
are blanked; css/sh/toml/yml/json files are identical once comments are stripped; the only
non-comment changes in TS/JS are test titles, one description string in a contract table, and five
ESLint messages, whose text is all the gates snapshot diff holds. Not touched: Markdown (docs and
the changelog keep their history), Alembic migrations, TV episode notation (`S2 · E5`), DESIGN.md
ids (`C1`, `B4`, `S3h`), tracker ids (`SEC-16`, `DX-17`).
One stale claim fixed on the way: test_hls_reaper's docstring said the player checkpoints "every
10 s whether or not it is playing", which plex/stream.py calls wrong; it now says what the code does.
31 lines
1.2 KiB
Python
31 lines
1.2 KiB
Python
"""An admin action that counts something keeps the count as data in its audit row's `after`, under
|
|
the key the audit log names in the reader's language (`scheduler.result.<key>`, frontend
|
|
auditColumns.tsx) — not only in the English `summary`. A renamed key would fall back to the raw word.
|
|
DB lane (Postgres).
|
|
"""
|
|
|
|
from sqlalchemy import select
|
|
|
|
from app.models import AuditLog
|
|
|
|
|
|
def _after(db, action: str) -> dict:
|
|
db.expire_all()
|
|
return db.execute(select(AuditLog.after).where(AuditLog.action == action)).scalar_one()
|
|
|
|
|
|
def test_clearing_the_audit_log_keeps_the_count_as_data(as_user, db, make_user):
|
|
admin = make_user(email="boss@example.com", role="admin")
|
|
db.add_all([AuditLog(action="sync_pause"), AuditLog(action="sync_resume")])
|
|
db.commit()
|
|
assert as_user(admin).delete("/api/admin/audit").json()["cleared"] == 2
|
|
assert _after(db, "audit_clear") == {"cleared": 2}
|
|
|
|
|
|
def test_a_discovery_purge_keeps_its_counts_as_data(as_user, db, make_user):
|
|
admin = make_user(email="boss@example.com", role="admin")
|
|
body = as_user(admin).post("/api/admin/purge-discovery").json()
|
|
body.pop("ok")
|
|
assert _after(db, "discovery_purge") == body
|
|
assert {"videos_deleted", "channels_deleted", "search_videos_deleted"} <= set(body)
|