peter
4aaaaa7860
The code cited its plan instead of saying why: `E28 review J4`, `(R6 S3b)`, `S1 justified…`,
`deep-review round 5`. That plan lives in the private ops repo, so for every reader of this one the
citation was noise, and a sentence whose subject was the plan step ("round 2 showed…") hid its
lesson behind an id. Each one is gone and the "why" kept: a bare citation is deleted, a sentence
carrying a lesson is reworded around it ("a later attempt showed…").
Measured (`scripts/audit_metrics.py`, product code): 652 lines in 270 files carried an epic code by
the definition the next commit holds (507 / 241 by the old, two-digit-only one) -> 0. Across all
code, tests, scripts and configs: ~1100 epic-code lines plus ~320 sprint/round ids.
Behaviour unchanged, checked mechanically: every changed .py file has the same AST once docstrings
are blanked; css/sh/toml/yml/json files are identical once comments are stripped; the only
non-comment changes in TS/JS are test titles, one description string in a contract table, and five
ESLint messages, whose text is all the gates snapshot diff holds. Not touched: Markdown (docs and
the changelog keep their history), Alembic migrations, TV episode notation (`S2 · E5`), DESIGN.md
ids (`C1`, `B4`, `S3h`), tracker ids (`SEC-16`, `DX-17`).
One stale claim fixed on the way: test_hls_reaper's docstring said the player checkpoints "every
10 s whether or not it is playing", which plex/stream.py calls wrong; it now says what the code does.
86 lines
3.2 KiB
TypeScript
86 lines
3.2 KiB
TypeScript
// @vitest-environment jsdom
|
|
//
|
|
// The outside-press half of useDismiss. The hook subscribes its `mousedown` listener once per
|
|
// open/close, which is what keeps a popover from re-subscribing on every parent render — but it
|
|
// means the listener must not CAPTURE the caller's handler or the ref LIST, or it keeps using the
|
|
// versions that existed when the popover opened. Both are read through refs; these tests
|
|
// are what says so.
|
|
import { useRef, useState } from "react";
|
|
import { describe, it, expect, vi, afterEach } from "vitest";
|
|
import { render, screen, fireEvent, cleanup } from "@testing-library/react";
|
|
|
|
import { useDismiss } from "./useDismiss";
|
|
|
|
afterEach(cleanup);
|
|
|
|
/** A panel that stays open while the caller swaps the handler it wants called. */
|
|
function SwappableHandler({ first, second }: { first: () => void; second: () => void }) {
|
|
const panel = useRef<HTMLDivElement>(null);
|
|
const [useSecond, setUseSecond] = useState(false);
|
|
useDismiss(true, useSecond ? second : first, panel);
|
|
return (
|
|
<div>
|
|
<div ref={panel}>panel</div>
|
|
<button onClick={() => setUseSecond(true)}>swap</button>
|
|
<div data-testid="outside">outside</div>
|
|
</div>
|
|
);
|
|
}
|
|
|
|
/** A panel that starts out registering one element and adds a second while it is open. */
|
|
function GrowingRefs({ onClose }: { onClose: () => void }) {
|
|
const panel = useRef<HTMLDivElement>(null);
|
|
const trigger = useRef<HTMLButtonElement>(null);
|
|
const [withTrigger, setWithTrigger] = useState(false);
|
|
useDismiss(true, onClose, withTrigger ? [panel, trigger] : [panel]);
|
|
return (
|
|
<div>
|
|
<div ref={panel}>panel</div>
|
|
<button onClick={() => setWithTrigger(true)}>register trigger</button>
|
|
<button ref={trigger}>trigger</button>
|
|
<div data-testid="outside">outside</div>
|
|
</div>
|
|
);
|
|
}
|
|
|
|
describe("useDismiss · outside press", () => {
|
|
it("closes on a press outside and stays put on a press inside", () => {
|
|
const onClose = vi.fn();
|
|
render(<SwappableHandler first={onClose} second={vi.fn()} />);
|
|
|
|
fireEvent.mouseDown(screen.getByText("panel"));
|
|
expect(onClose).not.toHaveBeenCalled();
|
|
|
|
fireEvent.mouseDown(screen.getByTestId("outside"));
|
|
expect(onClose).toHaveBeenCalledTimes(1);
|
|
});
|
|
|
|
it("calls the handler the caller has NOW, not the one it had when the popover opened", () => {
|
|
const first = vi.fn();
|
|
const second = vi.fn();
|
|
render(<SwappableHandler first={first} second={second} />);
|
|
|
|
fireEvent.click(screen.getByText("swap"));
|
|
fireEvent.mouseDown(screen.getByTestId("outside"));
|
|
|
|
expect(second).toHaveBeenCalledTimes(1);
|
|
expect(first).not.toHaveBeenCalled();
|
|
});
|
|
|
|
it("honours a ref the caller started passing after the popover opened", () => {
|
|
const onClose = vi.fn();
|
|
render(<GrowingRefs onClose={onClose} />);
|
|
|
|
fireEvent.mouseDown(screen.getByText("trigger"));
|
|
expect(onClose).toHaveBeenCalledTimes(1); // not registered yet — outside
|
|
|
|
onClose.mockClear();
|
|
fireEvent.click(screen.getByText("register trigger"));
|
|
fireEvent.mouseDown(screen.getByText("trigger"));
|
|
expect(onClose).not.toHaveBeenCalled(); // now it is one of ours
|
|
|
|
fireEvent.mouseDown(screen.getByTestId("outside"));
|
|
expect(onClose).toHaveBeenCalledTimes(1);
|
|
});
|
|
});
|