peter
8759b5860d
22 test files set `app.dependency_overrides[...]` by hand and tore down with a blanket `.clear()` in a `finally`, which wipes every override rather than the test's own and stops fixtures composing. They now take the `override_dep` fixture (helpers get it passed in), whose teardown restores each key's prior value; no clear() carried meaning between two phases of a test. A convention test fails any test file that writes `dependency_overrides` directly.
69 lines
3.2 KiB
Python
69 lines
3.2 KiB
Python
"""DB-backed regression for the 0.53.1 hotfix (R6 S3b-test): GET /api/plex/facets?scope=show
|
|
must return 200 — not the "cannot extract elements from a scalar" 500 — for a metadata-poor
|
|
library whose show has a JSONB-scalar `null` genres (a pre-0.53.1 row). The endpoint's
|
|
`jsonb_typeof(genres)='array'` read-guard is what makes it safe; this test would 500 without it.
|
|
|
|
Uses the DB lane (`db` fixture) — skipped when no Postgres is reachable.
|
|
"""
|
|
|
|
from fastapi.testclient import TestClient
|
|
from sqlalchemy import text
|
|
|
|
import app.state as state
|
|
from app.auth import current_user
|
|
from app.db import get_db
|
|
from app.main import app
|
|
from app.models import PlexItem, PlexLibrary, PlexShow, User
|
|
|
|
|
|
def test_facets_returns_studio_vocabulary(db, monkeypatch, override_dep):
|
|
"""E5 S7: /facets returns the studio vocabulary (distinct studio + count) for the sidebar picker."""
|
|
lib = PlexLibrary(plex_key="1", title="Movies", kind="movie", enabled=True)
|
|
db.add(lib)
|
|
db.flush()
|
|
db.add_all(
|
|
[
|
|
PlexItem(rating_key="m1", library_id=lib.id, kind="movie", title="A", studio="Pixar"),
|
|
PlexItem(rating_key="m2", library_id=lib.id, kind="movie", title="B", studio="Pixar"),
|
|
PlexItem(rating_key="m3", library_id=lib.id, kind="movie", title="C", studio="A24"),
|
|
PlexItem(rating_key="m4", library_id=lib.id, kind="movie", title="D"), # no studio
|
|
]
|
|
)
|
|
user = User(email="studiofacets@example.com")
|
|
db.add(user)
|
|
db.commit()
|
|
monkeypatch.setattr(state, "_configured_cache", True)
|
|
override_dep(get_db, lambda: db)
|
|
override_dep(current_user, lambda: user)
|
|
resp = TestClient(app).get("/api/plex/facets?scope=movie")
|
|
assert resp.status_code == 200, resp.text
|
|
studios = {s["value"]: s["count"] for s in resp.json()["studios"]}
|
|
assert studios == {"Pixar": 2, "A24": 1}
|
|
|
|
|
|
def test_facets_survives_json_null_genres(db, monkeypatch, override_dep):
|
|
lib = PlexLibrary(plex_key="1", title="Shows", kind="show", enabled=True)
|
|
db.add(lib)
|
|
db.flush()
|
|
db.add(PlexShow(rating_key="s1", library_id=lib.id, title="No Genre Show"))
|
|
user = User(email="facets@example.com")
|
|
db.add(user)
|
|
db.commit()
|
|
# The request gate 503s an unconfigured instance; flip the process-level "configured" flag the
|
|
# gate reads. monkeypatch auto-restores it, so it can't leak "configured" into another test.
|
|
monkeypatch.setattr(state, "_configured_cache", True)
|
|
# Simulate a pre-0.53.1 row: genres persisted as a JSONB scalar `null` (what SQLAlchemy wrote
|
|
# before none_as_null=True), NOT SQL NULL — this is the value jsonb_array_elements_text() chokes
|
|
# on. A Python None now maps to SQL NULL, so we set the scalar directly.
|
|
db.execute(text("UPDATE plex_shows SET genres = 'null'::jsonb WHERE rating_key = 's1'"))
|
|
db.commit()
|
|
|
|
override_dep(get_db, lambda: db)
|
|
override_dep(current_user, lambda: user)
|
|
client = TestClient(app) # no context-manager: skip lifespan (scheduler/HLS sweep)
|
|
resp = client.get("/api/plex/facets?scope=show")
|
|
|
|
assert resp.status_code == 200, resp.text
|
|
# The scalar-null show contributes no genres — and, crucially, doesn't abort the whole endpoint.
|
|
assert resp.json()["genres"] == []
|