peter
4aaaaa7860
The code cited its plan instead of saying why: `E28 review J4`, `(R6 S3b)`, `S1 justified…`,
`deep-review round 5`. That plan lives in the private ops repo, so for every reader of this one the
citation was noise, and a sentence whose subject was the plan step ("round 2 showed…") hid its
lesson behind an id. Each one is gone and the "why" kept: a bare citation is deleted, a sentence
carrying a lesson is reworded around it ("a later attempt showed…").
Measured (`scripts/audit_metrics.py`, product code): 652 lines in 270 files carried an epic code by
the definition the next commit holds (507 / 241 by the old, two-digit-only one) -> 0. Across all
code, tests, scripts and configs: ~1100 epic-code lines plus ~320 sprint/round ids.
Behaviour unchanged, checked mechanically: every changed .py file has the same AST once docstrings
are blanked; css/sh/toml/yml/json files are identical once comments are stripped; the only
non-comment changes in TS/JS are test titles, one description string in a contract table, and five
ESLint messages, whose text is all the gates snapshot diff holds. Not touched: Markdown (docs and
the changelog keep their history), Alembic migrations, TV episode notation (`S2 · E5`), DESIGN.md
ids (`C1`, `B4`, `S3h`), tracker ids (`SEC-16`, `DX-17`).
One stale claim fixed on the way: test_hls_reaper's docstring said the player checkpoints "every
10 s whether or not it is playing", which plex/stream.py calls wrong; it now says what the code does.
32 lines
1.9 KiB
JSON
32 lines
1.9 KiB
JSON
// The backend type-check lane — the gate's ninth lane, and the first thing that has ever
|
|
// type-checked the ~36k lines of `app/`. Read as JSONC: pyright accepts comments here.
|
|
//
|
|
// basedpyright, not mypy: measured on this tree with the dependencies actually installed, both land
|
|
// ~190-200 errors with the same distribution, so the choice was made on the things that differ —
|
|
// basedpyright is ~2x faster, needs no MYPYPATH to resolve our `app.*` imports, and has a FIRST-CLASS
|
|
// baseline (`--writebaseline`), which is the whole ratchet. mypy would have needed a third-party tool
|
|
// for that.
|
|
//
|
|
// It runs in the pytest test image, never on the host: `requirements.lock` cannot be installed on
|
|
// Windows at all (uvloop refuses to build there), so a host run would type-check against absent
|
|
// third-party packages and report nonsense. The version is pinned in requirements-dev.txt, which the
|
|
// image installs — so the lane's version IS the pin, with no host-vs-pin check to drift.
|
|
//
|
|
// `pythonVersion` is not free-standing: `/.python-version` is the single source of truth and
|
|
// `tests/test_python_engine_contract.py` fails this gate if this file, the two Dockerfiles, the CI
|
|
// container or ruff's target-version disagree with it.
|
|
//
|
|
// `include` covers `alembic` for the same reason the ruff lane was widened to it: migrations run on
|
|
// every container start, so one that raises there crash-loops prod, and "it is generated code" is
|
|
// not an argument when the generated code is what boots the system. `tests/` is deliberately OUT —
|
|
// a test's job is to fail loudly when it is wrong, which is the opposite of the silent runtime
|
|
// failure this lane exists to catch, and annotating fixtures to a checker's satisfaction is churn
|
|
// the ratchet exists to avoid.
|
|
{
|
|
"include": ["app", "alembic"],
|
|
"extraPaths": ["."],
|
|
"typeCheckingMode": "standard",
|
|
"pythonVersion": "3.12",
|
|
"pythonPlatform": "Linux"
|
|
}
|